Why code review is important.

story of our life

Any programmer who compares (or thinks he does, as in this case) a boolean expression with 'true' deserves to get his ass kicked by a robot.

@Grumpy where do you see comparison here??

@Arlekin Note the words "thinks he does" in my comment.

@Grumpy oh well, you are right... i must be really tired, time to go to sleep... on the other hand though... devRant!

@NickB Just the variable name would suffice, it will be then evaluated.

@NickB well, instead of writing if(murderingRobots = true) you would need if(murderingRobots == true).

Or like he said
if (murderingRobots) { }

This is why unit tests are important. :)

@Jase Note the words "thinks he does" in my comment.

(This is the second time I have to write this).

@Demiourgos Ouch, the pain! No, no and no again; you should NOT write
if(murderingRobots == true)
because that's just as dumb as writing
if((murderingRobots == true) == true)
or
if(((murderingRobots == true) == true) == true)
etc etc.
if(murderingRobots)
is the correct way.

When I was first starting out programming I made the mistake of doing while(variable = true)
Took me awhile to figure out why I was getting an infinite loop.
Never again did i evaluate booleans this way

Testing in production

@NickB Actually, it doesn't, because it like writing
if (((murderingRobots == true) == true) == true)

if (murderingRobots)
is the sane way.