35
YADU
167d

Would you merge this shit into your project?

Comments
  • 7
    No... I'm not risking the master branch...
  • 12
    fuck yeah merge it
  • 5
    "uh I can't hear you I'm going through a tunnel!"

    -closed-
  • 3
    If it has automated tests included, for sure.
  • 3
    If it works, fuck it๐Ÿคท๐Ÿผ
  • 4
    >contributor
  • 3
    hell no, you merge one and before you know it your project becomes some kind of weeaboo spawning ground.
  • 3
    If it works, and it’s actually improving something then yeah sure why the hell not?
  • 3
    @Earu you don't wanna encourage these people
  • 2
    @AmbientTea yeah I guess you're right, might accidentally open a portal to the anime world... Best not to risk it
  • 2
    I'm on the "if it works sure" side
  • 0
    @YADU

    Agreed, there's more to it than 'this code technically works'.

    Need some reasonable communication and encouraging making PRs into jokes on a regular basis for something that ... isn't a joke, bad idea IMO.
  • 0
    I think one joke or meme PR as long as it’s not all of them is ok. And as long as the addition is worth it, to me it out-values the potential “decrease in credibility”/“encouraging bad behavior”/whatever you want to call that
  • 0
    definitely
  • 0
    For those who are against making jokes on repos: Python is full of them

    import this
    imoort antigravity
    from __future__ import braces

    https://www.python.org/doc/humor/

    It's even named after a comedian, Monty Python

    This joke might be of a "weird" taste to you, but that's just you. If you advocate against this joke in this repo, you must also advocate against the jokes in Python
  • 1
    @eo2875 I do advocate against the jokes in Python as well, I think they're awful
  • 1
    FUCK YEAH I WOULD
  • 3
    Well, does it work? Could be dealing with some kind of genius
  • 2
    @rant1ng anime programming loli? I would probably watch that if it was an anime.
  • 1
    @OmerFlame I hate to say it but I'd probably watch that too๐Ÿ˜‚
Add Comment