17
hell
7y

TL;DR;

Idiot hard coded database host on the app... Pushed to prod and suddenly shit wasn't working... Took me 10 minutes to figure out what was going on...

Wrote a passive aggressive git message and commited.
Before updating prod my boss turns around to me and the following took place:

Boss: is there any problem with the server?

Me: yes, someone (i know who was ) hard coded the test db IP and it broke the backend.

Boss: oh, but will it affect the mobile app?

Me: well, it won't work but I'm already pushing the fix.

Boss: no..err.. I mean... Will I have to make any change to the mobile app?

Me inside: wtf dude... For real?! Get your shit together...

Me: no. It good, I already fixed it.

Boss: OK. Thanks

TL;DR;

Moron hard coded dB's host and stupid boss can't get shit together nor ask who did it to take precautions...

Comments
  • 0
    What framework was this app in? Most frameworks take the idiocy of fellow programers into account
  • 1
    @dpd003 codeigniter
  • 1
    You don't have any form of code review in your company? Like gerrit or pull requests? Try to implement it in your company even on your own (like I did). It will save you a lot of time because you can prevent changes like that going to production
  • 1
    @beriba yeah, I would like to but I realized that everything new I introduce is gonna be on me and I really have no time/patience left to do anything :/

    I know my peers won't follow things properly and my boss (lead dev) sometimes acts like a stupid that don't see around him when it comes to managing our team regarding code quality.

    :/
  • 1
    @azous Of course it will be on you. But the same applies to looking for stupid changes. And they can come up a year later in the worst moment. I implemented gerrit, jenkins, graylog, grafana, chef and tons of other technologies in my company. Of course it's all on me because only I'm able to do any maintenance task with those technologies. But they saved me a lot of time in the past. Now it's just a pure profit for something like $50/month (servers cost). Try with one thing (code review for instance) and see how it goes. If you don't want to implement gerrit, try pull requests on bitbucket.
  • 1
    Do you guys use .env file with your ci projects so you can set all the db, mailing and what ever variables you need in one spot on each environment you have and then only worry about updating them as you add new variables?
  • 0
    @beriba yeah, I manage the servers with ansible and we are currently using gitlab, I'm gonna take a look at this but I would really like to take actions upon stupid behavior but I know it won't happen here :/
  • 0
    @dpd003 no, gonna check it out, thanks
  • 1
    @azous As far as I know gitlab has code review functionality
  • 1
    @beriba it does, but every time I see my peers struggling to git clone something I cringe thinking about pull requests 😭
  • 1
    @azous I made it the hard way. I learned people how to use gerrit, I told them that I'm always here in case of any questions and I forced them to use it. Now they know how to use it and after some time there were no more questions. People are lazy and sometimes you have to force them to do something for all of you to profit
  • 0
    yeah organize a workshop
Add Comment