tl;dr: Bossmang blaming my code for a database connection issue thrown from outside of my code. Bossmang doesn’t listen. Bossmang doesn’t want to believe it’s a connection issue.

———

Bossmang: The code you wrote is causing insane spec failures in the release branch! It’s hard to follow because it’s so insane, but the cause is your code not properly handling undefined settings! Look at this! <spec>

Me: Specs pass on my machine. I ran it with both a set and nil value. <screenshots>

Bossmang: It works when you set it to nil.

Me: But a setting that doesn’t exist returns nil? <screenshot>

Bossmang: Not seeming to.... So this is the spec failure from the release: “No connection pool with id primary found. <stacktrace that starts outside of my code>”

Me: ... That’s a DB connection error. It’s also being thrown outside of my code, and from a `super` call to Rails.

Bossmang: But <unrelated> and <unrelated> and <other spec> is failing, and if I set the version, it has <other failure> instead! That calls your code first.

Me: It’s a database error. Also: <explains probable, unrelated cause of other failures, like someone didn’t mock a fucking external api call>

Bossmang: But if I restore a DB backup, it fails again.

Me: Restoring uses a dB connection, which could be exhausting the pool depending on the daemons you have running.

Bossmang: perhaps.

...

Bossmang: I still think it’s related to spec ordering.

🤦🏻‍♀️🤦🏻‍♀️🤦🏻‍♀️🤦🏻‍♀️🤦🏻‍♀️
This is tiring.