What’s your preference for a simple if without shorthand:

if ($variable == ‘test’) echo ‘’hello’;

if ($variable == ‘test’) { echo ‘’hello’; }

if ($variable == ‘test’) {
echo ‘’hello’;
}

Always the third. Clear, consistent, less error prone

This.

if (condition) {
// do something
}

Always 3, but it depends. 1 can be good in some cases for readability.

1 for small quick things.
But 3 is how it’s meant to be written (following the PSR)

puts "Hello" if condition

echo $variable=='test'?'hello': '';
*hides and runs

1 if short oneliner.

Long oneliner:

If (gaaa)
gàaaaaaaaaaaaaaaaaaa();

3 is the most legible

@cursee
if (condition)
{
//Whatever
}

@mojo2012 same for me unless its just a return. Then I actually prefer the 1 line in terms of readability.

4.
if( bool)
// do something

@erroronline1 😣 you joke, but I have inherited a project full of this.

if ($variable == "test")
echo "hello" ;

No {} since only one line.

@C0D4 well... erm... yeah... a joke... haha!
serious. i know it is likely bad practice. but i am lazy and no one ever sees my code. i'd not recommend it to a learner though.

@erroronline1 that’s what my last cooworker said, now here I am 🤕🔫

@C0D4 i am sorry 😞

@erroronline1 it’s ok, just tell me you don’t use alt syntax as well ( something I thought died in PHP4 ) and I’ll forgive you when you start unraveling your ternary operators.

http://php.net/manual/en/...

@C0D4 wow! i wasn't aware of this. although i am a slow learner i see this wouldn't end well...

3rd!!!

3rd.

Also @C0D4, I use alt syntax when I place clear html between them, else I use that 3rd notation.

i loved first, but i have a pipeline with phpcs PSR2 standard test that made me use third...

and honesly i didnt see anyone use second :)

$boolValue && someFunc ()

Works great :-D

@C0D4 explain to me, whats bad about ternary operators?

@Codex404
They lead to unclear operations very quickly, especially when people start nesting them and having multi logic paths and variable assignments occurring, and multiple outputs. This shit can’t be tested nor can it be easily followed to work out the actual expected behaviour.

For single liners and the quick bool occurring I can live with them, but I’ve seen things I can’t bleach from my eyes.

@C0D4 but thats programming all together. If you abuse a tool its horrible.

if ("test" == $variable) { echo "hello"; }
I am sure you know the reason ;)