Senior Tech lead keeps yapping about "we need more comments in the code"... Yeah right... I reviewed his PR t

Ranter

rantydev

296

Comments

4

rantsauce

7083

2y

# define method

def killme; end;
3

Xamenyap

1176

2y

Your senior tech lead and my junior dev would make a great pair! Check my latest rant to know why
1

rantydev

296

2y

@Xamenyap indeed a match made in heaven!

But ya know... They're junior... They maybe don't know better.
0

Xamenyap

1176

2y

@rantydev true, in my case he has the excuse of being a junior. A good tech lead should know how to write good comments.
But I'm not surprised, I've seen a fair amount of incompetent tech leads before.
0

sideshowbob76

776

2y

Senior? ”Add MORE comments!?” 🫣
2

Voxera

11847

2y

A perfect example why comments should be used sparingly and ONLY when the code is not self explanatory.
0

sideshowbob76

776

2y

”All” MR/code reviews I write

”Remove comments”
”Change variable/method/class/file name to something understandable”

I make the same mistakes (not comments). I never comment code.
1

nachocode

6453

2y

#if condition
if(condition)
0

Oktokolo

12341

2y

Come on! This has to be rant bait! How long did you had to search for a "senior" that stupid?!
1

rantydev

296

2y

@Oktokolo Hahahahaha I wish

I wish
0

IntrusionCM

15177

2y

@rantydev

# read the code

# the code tells the truth

# nothing but the truth

# still telling the truth

# just read the code

I would have a lot of fun doing this...
0

AlmondSauce

16718

2y

How the hell did he become a senior tech lead?!
0

deadlyRants

5716

2y

@AlmondSauce By writing a lot of comments apparently
2

Voxera

11847

2y

@deadlyRants by not getting fired.

All to often senior is only an age bonus, not knowledge or capability title.
0

Earu

577

2y

IMHO comments are only needed if you do something a bit complex or out of the ordinary, the rest for decent programmers should be easy to understand

Add Comment

Senior Tech lead keeps yapping about "we need more comments in the code"... Yeah right... I reviewed his PR today: # Get the feature list builder.get_feature_list() # Assign the features to the columns target.columns = features ... FFS

rant

Senior Tech lead keeps yapping about "we need more comments in the code"... Yeah right...

I reviewed his PR today:

# Get the feature list
builder.get_feature_list()

# Assign the features to the columns
target.columns = features

...
FFS