19

Today I saw a code written by my junior. Basically excel export. The laravel excel package provide great ways for optimization.

My junior instead did 6 times loop to modify the data before giving that data to the export package. We need to export around 50K users.

When I asking him why this ? He said it works and it's fast so what the issue ???

Noob , you have only 100 users in the database and production has 10 million.

Sometime I just want to kill him.

Comments
  • 8
    Did you at least explain to him very clear, how he could improve and what the issue is?
  • 9
    He's a junior.
    "My junior" I assume you're his supervisor?
    Explain it to him and tell him to do it the proper way he'll learn and you'll not have to correct him again. Win win 👍

    We've all done weird things when we were starters.
  • 4
    It is your duty to teach
  • 4
    Sounds like wk331 opportunity!
  • 5
    Some more information: he has done same mistake multiple times and I have done pair programming to explain and fix the issue. And stuff like this has happened multiple time.

    As a junior he is allowed to make mistakes, not same type of mistake multiple time.
  • 1
    Also he has 3 years of experience.
  • 2
    yeah let him get the message and make sure he understands that it was fast because he had 100 users only then ask him the question will it be fast if you deal with 10 millions users?
  • 5
    @dIREsTRAITS next week I am gonna take whole production dump and import in his local db.
  • 4
    So. Lemme simulate this in real time.

    Take the stairs, run around the building for each iteration, for each object created do one push up.

    I'll be counting.
  • 3
    @marcus5914 make sure to to exclude e-mails incase he sends them n! times
  • 0
    @marcus5914 yes and while you do that and the setup is ready then gather the whole team to watch the result so next time he doesn't flash you with that response: ' what's the issue'
Add Comment