Yay, merged 30 pull requests on a Friday.

What could go wrong :D

Holy… you aren‘t exaggerating? 😳

@Lensflare No, the (only) senior developer is fired recently (responsible for code reviews) which they never did. Or they asked for minor adjustments (mainly code quality), we made them and then those were never reviewed again.

But the code will be pushed to our test environment first so it will not yet be live... If it's stable enough, we will probably push live on Monday or Tuesday

But no, it's 31 merge requests to be exact.

@wojtek322 In case you don't work remote: Don't forget to "forget" your phone at work.

@chatgpt what is the recommended count of merges done on a Friday?

@Wombat

As an AI language model, I have no specific knowledge of your company and its policies or systems. As a general recommendation, it is best to follow the guidelines and processes set by your team lead or manager regarding processes like code merges.

It is also best to consider the capacity and workload of your team before deciding on the number of code merges to be done on a specific day. Collaborating with your team can help you establish the recommended count of code merges which can be done on a Friday.

@Realjase

As an AI language model, I must remind you that it is important to maintain respectful and appropriate language when interacting with others. The recommended number of bowel movements per day can vary based on factors such as individual body type, diet, and lifestyle. However, experts generally suggest that having one to three bowel movements per day is considered normal and healthy. If you experience any changes in your bowel movements or have concerns, it is recommended to talk to a healthcare provider.

@Realjase

As an AI language model, I do not have access to your medical history or personal health information.
However, generally speaking, changes in the consistency and smell of stool could be a sign of an underlying health condition or digestive issues.

Loose, watery and smelly stool may indicate a viral or bacterial infection, or a food intolerance/ allergy. If the problem persists for several days or is accompanied by other symptoms such as abdominal pain, fever, and dehydration, it is advisable to seek medical attention.

Other factors like changes in diet, stress, or medication could also affect the consistency and smell of stool. If you are worried, and it continues to concern you, it is recommended to seek medical advice to rule out any potentially harmful conditions.

Really depends on the postcode impact of the service. If I would completely fuck up our main service and destroy the data, we can't order stuff. However we can recreate all the data correctly in 5 hours. So yes it's a shit show and annoying for the internal users on Monday. Same goes for other days though Monday we order a bit more.

After you are back from WE, how well did it go?

@happygimp0 Nothing new broke. It was very successful. But then again, the majority of the merge requests were very minor changes (3 bigger ones)

Nothing as long as your CI isn't configured to deploy merge changes immediately to live. 🤷‍♂️

I quite like our review process it's worked really well for us:

* any Dev can review a PR so long as they've got experience in that area (i.e. if back or front end)
* a PR must have at least 2 reviewers (preferably more if it's touching scary legacy)
* QA's review only counts as half a review since they can only test behaviour, so a Dev can work with them to review the code analysis side and that amounts to a whole review
* at least a senior or mid-level Dev you trust has to be at least one of the reviewers (juniors can't be the only reviewers)
* _all_ automated tests must pass before work can be reviewed
* all work must be driven out via TDD where possible (exceptions ofc with some scenarios)
* the person who paired with you counts as a reviewer if they want to

Our Devs are highly encouraged to choose who they want to review their PRs (however anyone can pick them up). We've got a good culture where we all try to get our code read by the most senior people we can + pairing

Our stand ups are quite productive now too. We do the "Walk the board" approach.
Someone shares a screen of the sprint with the tickets statuses and we raise any blockers and calls for assistance, starting with PRs.
We don't give an update of what we've done, just where we're stuck.
We assign PRs there and then and continue through to In Progress.
We then ask if anyone is looking for work.
We rotate this role every day and a team of 8 takes about 5-10 min to complete this.
We try to minimise discussions that are better had elsewhere on Slack or other calls (e.g. ideas about a bug's solution) as it's not relevant to everyone in Standup

It’s now Saturday. Is everything on fire yet?