62

I feel a high amount of self rightiousnes

Comments
  • 2
    This looks like code you'd see from a drag and drop tool.
  • 0
    Yep, apparently the text in that block is raw text without HTML being sent from an old obselet CRM that only includes < br /> tags
  • 3
    You don't need to use !important if you target the element properly, even if it's raw text, it will still be in some kind of container.
  • 2
    Well, the comment is really !important. 😊
  • 1
    I read somewhere a guy had created the 'shame.scss' file to put all crap code he had to push before deadline. I think yours is a good candidate for this practice.
  • 3
    @ajmada Harry Roberts (https://csswizardry.com/about/). It's in his talk on refactoring.
  • 1
    @pabmeister basically there's already shitty css coming from another place which has shitty selectors,

    And this page is being dynamically created from a haml template which I had no access to.

    so I had to use the !important,

    Trust me I've tried...
  • 0
    Isn't 1.6rem bigger than 16px?
  • 1
    @Raynbow it depends on the base style
  • 1
    May I ask why are you using font-familiy twice? Please ignore my lack of knowledge
  • 1
    @dextel2 the $font-family is a SASS variable that references the font property value
  • 0
    @terminalterror Yeah, that was him. Nice catch ;)
  • 1
    The !important is annoying but i can let it pass as an ugly patch.
    However, watching the useless double font-size with the "em" typo as "rem" made my eyes puke on my brains instantly.
Add Comment