6
dmonkey
40d

Tl;dr I am incredibly ashamed of my code at work.

I recently started working as a junior dev. I know many aspects of the stack I use, and I feel pretty comfortable when solving simple and specific problems.

But this is the first complete project I make, and I received no peer review until now. And my code sucks.

I tried my best to deliver a good and working code, but it became messy in too many places. Now it's too late to refactor.

Probably I just cannot see the right way of modeling specific situations, I don't feel I should blame the frameworks I'm using, but the point is that my code sucks. Or at least this is how I feel.

I'm going to leave this workplace soon (personal reasons, not related to this topic and/or the company), and I am kinda scared of the shit I'm about to leave to them. It's a very nice environment and they don't deserve this crap. Also I have some other good reasons to worry about this, but I cannot tell them.

My plan is to finish a couple or personal stuff I have to do and then spend as many hours I can on the project trying to finish it asap and make the code better (for now I've been working only 6hr/day).

I'm really thinking that I just suck at this.

Comments
  • 8
    Why did you only receive feedback now? As a junior, I'd expect continuous reviews so that I can learn early and fix code before I built on it more
  • 7
    I agree with @alexbrooklyn. Also, when working on something alone and not getting any feedback, the best of us tend to make a spaghetti mess
  • 4
    @alexbrooklyn I did not receive any feedback, I just had a look at the whole thing by myself. I agree on that, if they ask for any feedback on the company I'll tell them.

    @miksaraj This actually makes me feel better. Still, I need to practice more.

    Thank you both for your feedback. I feel better.
  • 2
    It's always like that when a junior dev works without peer review
  • 4
    > I'm really thinking that I just suck at this

    And you probably do. And that's all-natural. You're a junior - juniors are allowed to suck. Juniors are expected to suck. And break stuff.

    Now I see two paths forward from this point:
    1. keep on sucking, keep on being a junior;
    2. find out why the fuck does your code suck and how to make it suck less. I'd suggest asking seniors in the field for some insights/possible refactoring ideas and to point out where your code was doomed to derail. Shape your thinking, your software modelling skills. And do it while you've still got time, i.e. you can access that poor code of yours and get feedback on it. Otherwise, you'll be doomed to write shitty code again to have something to receive negative (hopefully constructive) feedback about!

    Pssst. I'd strongly advise you to take the 2nd path!
  • 5
    Ok. Here is my plan. You create private repo of your project and add whoever wants to join from here as a collabrator. Then we review your code and open issues. Then we start fixing your code and make it beautiful than ever. We will fix everything and finish your project by the end of this week. We are stronger if we unite! We are devs! We help each other and... Just kidding, you gotta fix your shit by yourself, sorry man. Good luck!
  • 2
    @hack your comment is just too funny, i had to read it twice
  • 2
  • 1
    @netikras Thanks I'll try... Right now I don't feel I should ask them because their seniors are very busy (yeah I know, it shouldn't be this way) but I'll follow your advice and seek help online.
  • 1
    @hack thanks, very helpful. Still almost funny though
  • 0
    @dmonkey I don't think your NDA allows you to post your poor code snippet online for others to review :)

    Oh come on. Noone's saying you cannot ask for their opinion. Just ask. Whether they'll find time for you or not - that's up to them. But if you don't ask - they will most definitely NEVER find time for you. Because they won't know you need it..

    Your growth is very strongly based on knowledge sharing, this includes getting knowledge from others and spreading yours out to them. If you have a question - ask (try looking it up in your notes and google first, but if you can find nothing or the question is too specific - just go straight to the seniority).

    I mean you will never get the answer if you don't even ask.. Who knows - perhaps some senior will find some 30 minutes for you after his 9-5! And if you add to your question a line saying that you want to learn from their feedback, that you want to grow and to be better at this - I'm almost certain at least one senior will reply.
  • 1
    @netikras You convinced me, I'll try. I must admit I am kind of shy of asking for help, not because I'm worried of being judged but because I feel like I'm a dead weight stealing other people's time...

    But yep it doesn't make sense.
    If I was senior I would gladly help anyone, so why shouldn't they do the same?

    Finally, of course I'd never share any explicit company code online, I'd just recreate a similar situation and ask for help.

    Anyway, thanks, you totally made me feel better.
  • 2
    Everyone sucks at the beginning (and usually middle too) don't beat yourself up too hard. I look at code i did a few years ago and cringe.
Add Comment