85

Dev submitting PR: “Testing instructions: Self explanatory”

Dev reviewing PR: You need to be a bit more verbose than that.

Dev submitting PR: “Testing instruction: Feature should work as expected”

Dev reviewing PR: *sigh*… Feature doesn’t work as expected

Dev submitting PR: WHAT IS NOT WORKING AS EXPECTED??? I NEED MORE DETAIL THAN THAT!!

Dev reviewing PR: …….So do I you muppet

Comments
  • 0
    @prodigy214

    0. Merge conflict resolved prior to QA
    1. Mandatory pull locally to verify meeting requirements
    2. Code review with the goal of creating the highest quality code possible
    3. All tests pass (automate this)
    4. New tests are created appropriately
  • 1
    Why would you submit a feature for peer review that doesn’t work
  • 1
    @AvatarOfKaine Oh you sweet summer child
  • 1
    @boombodies amusingly i am a summer child :P lmao that made my inner child smile sweetly. :)
  • 1
    more SPECIFIC/DESCRIPTIVE, not "verbose".
Add Comment