428
spjain
1y

How Programmers review code

Comments
  • 9
    Welcome to Devrant 😂
  • 42
    I want to say "Don't be ridiculous!", but you're so totally right.
  • 10
    Won't look good without a dark theme
  • 5
    Bikeshedding at its finest
  • 10
    Notice it's saying "Looks good", not "Looks like it will work good". Hahahaa, nitpicking.
  • 3
    @aceface What's "bikeshedding"?
  • 8
    @CrankyOldDev

    https://en.m.wikipedia.org/wiki/...

    TLDR; people have opinions about trivial things because its easy to understand. Not so with complex things, because they dont understand them.

    So, short code reviews get lots of comments because it's easier to pick them apart than longer code needing review
  • 3
    @aceface Interesting... never heard the term before. Not really intuitive but that's probably just a language/region thing. Bikeshedding where I'm from would involve romantic liaisons!! 😆

    But that aside, I have problems with the term. Everybody forms opinions on subjects even if they don't understand them. Especially if they don't understand them. Problem is they then get evangelical and they haven't a notion what they're talking about. Sorry for taking the thread on a tangent.
  • 5
    Friend wanted me to look over some hella long code, I looked for like a minute, got up, "looks like code"
  • 2
    I printed that one and have put it up in the kitchen a year back or so. Always remember this!!
  • 2
    @aceface thx to you and devRant in general for teaching me something new every day 👍😁
  • 2
    @aceface didn't know about bike-shed effect ! Tnx for sharing.
  • 3
    Exactly why I think code reviews are a fucking joke.
  • 1
    Of course

    Everything is good after 500 lines of cocaine
  • 0
    hey where did you get this picture of me?!? lol I think maybe is my long lost twin ;P
Your Job Suck?
Get a Better Job
Add Comment