Learn More
Resend Email
27
boombodies
3y

Dev: There’s a file in your PR with over 1000 lines of code, I think it should be broken apart into a couple smaller pieces to be a little more in line with the single responsibility principle

Muppet Dev: That file only has one responsibility! It can’t be broken apart!

Dev: How’s that?

Muppets: It’s single responsibility is managing that group of functionality

Dev: …

rant

single responsibility principle

garbage collection
Favorite
Ranter
Comments
  • 3
    3y
    Tell him to copy paste it in another file. Or make the system one big file so it can manage every responsibility bc you know, single responsibility thingy
  • 11
    3y
    Don't even discuss it with them. This is what they need to do to fix this problem. They don't want to? Reject the PR for complexity problems.

    I stopped reviewing PRs with more than 500 lines of code changes. If it's linked to a feature, ok, but otherwise clean that shit up.
  • 4
    3y
    πΏπ‘Žπ‘’π‘”β„Žπ‘  𝑖𝑛 1000 𝑙𝑖𝑛𝑒 π‘“π‘’π‘›π‘π‘‘π‘–π‘œπ‘›π‘ 
Related Rants
devRant © 2021 Hexical Labs LLC
Privacy Policy  |  Terms of Service
Add Comment