My code review nightmare?

All of the reviews that consisted of a group of devs+managers in a conference room and a big screen micro-analyzing every line of code.
"Why did you call the variable that? Wouldn't be be more efficient to use XYZ components? You should switch everything to use ServiceBus."
and/or using the 18+ page coding standard document as a weapon.

PHB:"On page 5, paragraph 9, sub-section A-123, the standards dictate to select all the necessary data from the database. Your query is only selecting 5 fields from the 15 field field table. You might need to access more data in the future and this approach reduces the amount of code change."
Me: "Um, if the data requirements change, wouldn't we have change code anyway?"
PHB: "Application requirements are determined by our users, not you. That's why we have standards."
Me: "Um, that's not what I ..."
PHB: "Next file, oh boy, this one is a mess. On page 9, paragraph 2, sub-section Z-987, the standards dictate to only select the absolute minimum amount of the data from the database. Your query is selecting 3 fields, but the application is only using 2."
Me: "Yes, the application not using the field right now, but the user stated they might need the data for additional review."
PHB: "Did they fill out the proper change request form?"
Me: "No, they ...wait...Aren't the standards on page 9 contradictory to the standards on page 5?"
PHB: "NO! You'll never break your cowboy-coding mindset if you continue to violate standards. You see, standards are our promise to customers to ensure quality. You don't want to break our promises...do you?"

Really fed up with my colleague and possibly my job. Am starting to doubt am cut out to be a developer

Am a junior java dev , been working working for this company for about 2 years now. Although they hired me to be a java dev, they pretty much exclusively had me working on JavaScript crap because none of the other more senior devs wanted to do even so much as poke JS with a long stick....

Oh and the salary was crap but i figured since i had barely 3 years of exp i thought i would stick with it for a while

But a few months ago after seeing other opportunities I got fed up and threatened to quit , already started interviewing etc
Got an offer, not exactly what i wanted but better than where i was. Went to quit but they freaked out and started throwing money at me. They matched and exceed the other salary and promised to addressed the issues that made me want to leave. Ie get me to work more on the java side of the project and have me work with someone more senior who could sort of mentor me, i had been working semi solo on the js shit till then...

The problem is that my supposed mentor is selfish prick... he is the sort of guy who comes in real early, basically he goes to early morning prayer then come in at some ungodly hour and fuckoff home around 3pm

He does all his work early morning then spends the rest of the day with his headphones on stealthily watching youtube, amazon, watching cricket, reading about Palestine , how oppressed muslims are or building a website for some mosque.

I asked him to let me sit with him so that I could just learn how this or that part of the sys worked , he agreed then the very next day comes in and does all the work before i get in at 9 , i asked him how he did it and he tells me oh just read the code.

Its not as simple as that, out codebase is an old pile of non standard legacy dog shit. Nothing works as it should, i tried to go through documentation online for the various stuff we use , but invariably get stuck when i try the usual approach because it turns out the original devs had essentially done a lot of custom hacks and cowboy coding to get stuff working, they screwed around with some of the framework jars & edited libraries to get stuff to work, resulting in some really weird OSGI errors.

My point is that i cant really just "read the code" or google ...
I gotta know a bit more what was actually modified and a lot of this knowledge isn't fucking documented, theres a lot of " ohhh that weird bug yeah yeah that happens cuz x did this hack some years ago to fix this issue and we kinda built on it, yeah we weren't supposed to do that but heyyy what u gonna do, just do this or that instead"

I was asked to set up a web service to export something, since thats his area of expertise and he is suppose to be teaching me the ropes, i asked him to explain where i should start and what would the general workflow be, his response is to tell me to just copy the IMPORT service and rename it to export then "just do it um change it or something" very helpful indeed (building enterprise application here nothing complex at all!!)

He sits right next to me so i can see how much works he actually does, i know when he just idly sitting there so thats when i ask him questions, he always has his earphones on so each time i gotta find a way to get his attention with a poke or a wave, he will give a heavy sigh and a weary look as he removes his headphones, listen to my question then give me the shortest answer possible before IMMEDIATELY turning away and putting his headphones on as fast as possible regardless of whether I actually understood or even heard what he said. If i ask another question ( am talking like an immediate follow up question for a clarification or something) he will
Do the whole sigh + tired look routing to make me know yeah you are disturbing me. ( god was so happy the day he accidentally sat on and broke them)

Yesterday i caught a glance at his screen as i was sitting down and i think he and another dev were talking about me
That am slow with my work and take forever to get into gear.

Starting to have doubts about my own ability n wether am really cut out to be a developer. I know i can work hard but its impossible to do so when you have no clue where to start and unable to look it up since all the custom hacks doesn't really allow any frame of reference.
Feels like am being handicapped and mocked, yesterday i just picked up my gear n left the office.

I never talk ill about my colleagues, whenever i have a 121 with my mgr i always all is fine, x n y are really helpful etc
I tried to indirectly tell my other colleague about this guy, he told me that guy had kinda mentally checked out of this job and was just going through on auto pilot and just laughed it off (they have been working together for almost a decade and a buddies) my other colleague is pretty nice but he usually swamped with work so i feel bad to trouble him.

Am really Fed up with it all

!rant

Had a meeting with the head of my department concerning the status of many of our current projects. Them projects are huge and it is 2 dedicated devs(me and the lead) working on them whilst training our CMS admin in development to help out(dude is talented af and really digs programming) and my manager was so worried about what he was gonna say.

The thing is, she doesn't know how to take a break, she never pushes us, but she does push herself and it pains the team to see her take so much heat. She really is a bomb manager, and we want her to be more at ease.

Well a couple of days ago the vips of the board decided to bombard her with shit since out dptmnt head was on sick leave. The stress they put on her was some military grade bs and even then she never...EVER took it out on anyone.

The head of our department walked in to talk to us about it. Dude is a tall older gentleman, suits up every day(Texas style meaning cowboy boots and everything) and is quite imposing. Has a stern look man, one of them 1000 mile stares and a huge mustache that more than surpasses mine(which mind you, my mustache is fucking outstanding)

Our boss walked into the meeting room, sat down and heard what she had to say, she was not excusing herself. As bomb as this gorgeous woman is she was all about telling him what we were going to show the board on next week's meeting.

He sat there quietly listening to her as well as the presentation that me and my boys had to do.

What happened next blew me the fuck out of this world.

He said that he was sorry that so much stress had come down to her and us whilst he was gone and that he was happy with the leadership showcased by her and the initiative that the team took to put forward a presentation for him and the board. He also said that he was going to make said presentation for us since the vips had no business stressing us out, he asked for our assistance for any of the technical stats since even though he was a programmer he is not aware of all the inner details of our apps. He said that it is commendable that such a small team can hold 2 campus(college level) and that he was aware of the technical proficiency of me and the lead and that he knows that our shit is not something that gets done overnight.

He then said that at any given time that we get antagonized by matters such as timeframes or shit like that that we can direct everyone to him, regardless of what.

.He was also really amazed at the progress we showed him on the current projects(most are on their respective testing phases).
He then reiterated on how proud he is of all of us before biding us a good weekend and leaving to his office

As i sat there watching how the world was lifted from my manager and happy that he enjoyed the progress of my work I could not help but feel a deep sense of admiration and respect for this mysterious man.

I would damn skippy take a bullet for him....just in case my draw gets sloppy that is, ain't no one taking aim at the boss.

Calling all Devs 🤙:

What's the _best_ worst code you've seen in the wild in your corporate codebases?

Include a snippet of the traumatic lines in your comments!

I'll start with a classic:
$send = $enabled ? true : false;

Sigh, what is it with these cowboy SQL Devs? Why the fuck is this a pattern for anything?

New contract, new idiots, sigh.

EDIT: Had to change picture because Prod is different to Dev (but no dev has been done since release....smh)