This code review gave me eye cancer.

So, first of all, let me apologize to anyone impacted by eye cancer, if that really is a thing... because that sounds absolutely horrible. But, believe me, this code was absolutely horrible, too.

I was asked to code review another team's script. I don't like reviewing code from other teams, as I'm pretty "intense" and a nit-picker -- my own team knows and expects this, but I tend to really piss off other people who don't expect my level of input on "what I really think" about their code...

So, I get this script to review. It's over 200 lines of bash (so right away, it's fair game for a boilerplate "this should be re-written in python" or similar reply)... but I dive in to see what they sent.

My eyes.

My eyes.

MY EYES.

So, I certainly cannot violate IP rules and post any of the actual code here (be thankful - be very thankful), but let me just say, I think it may be the worst code I've ever seen. And I've been coding and code-reviewing for upwards of 30 years now. And I've seen a LOT of bad code...

I imagine the author of this script was a rebellious teenager who found the google shell scripting style guide and screamed "YOU'RE NOT MY REAL DAD!" at it and then set out to flagrantly violate every single rule and suggestion in the most dramatic ways possible.

Then they found every other style guide they could, and violated all THOSE rules, too. Just because they were there.

Within the same script... within the SAME CODE BLOCK... 2-space indentation... 4-space indentation... 8-space indentation... TAB indentation... and (just to be complete) NO indentation (entire blocks of code within another function of conditional block, all left-justified, no indentation at all).

lowercase variable/function names, UPPERCASE names, underscore_separated_names, CamelCase names, and every permutation of those as well.

Comments? Not a single one to be found, aside from a 4-line stanza at the top, containing a brief description of that the script did and (to their shame), the name of the author. There were, however, ENTIRE BLOCKS of code commented out.

[ In the examples below, I've replaced indentation spacing with '-', as I couldn't get devrant to format the indentation in a way to suitably share my pain otherwise... ]

Within just a few lines of one another, functions defined as...

function somefunction {
----stuff
}

Another_Function() {
------------stuff
}

There were conditionals blocks in various forms, indentation be damned...

if [ ... ]; then
--stuff
fi

if [ ... ]
--then
----some_stuff
fi

if [ ... ]
then
----something
something_else
--another_thing
fi

And brilliantly un-reachable code blocks, like:

if [ -z "$SOME_VAR" ]; then
--SOME_VAR="blah"
fi

if [ -z "$SOME_VAR" ]
----then
----SOME_VAR="foo"
fi

if [ -z "$SOME_VAR" ]
--then
--echo "SOME_VAR must be set"
fi

Do you remember the classic "demo" programs people used to distribute (like back in the 90s) -- where the program had no real purpose other than to demonstrate various graphics, just for the sake of demonstrating graphics techniques? Or some of those really bad photo slideshows, were the person making the slideshow used EVERY transition possible (slide, wipe, cross-fade, shapes, spins, on and on)? All just for the sake of "showing off" what they could do with the software? I honestly felt like I was looking at some kind of perverse shell-script demo, where the author was trying to use every possible style or obscure syntax possible, just to do it.

But this was PRODUCTION CODE.

There was absolutely no consistency, even within 1-2 adjacent lines. There is no way to maintain this. It's nearly impossible even understand what it's trying to do. It was just pure insanity. Lines and lines of insanity.

I picture the author of this code as some sort of hybrid hipster-artist-goth-mental-patient, chain-smoking clove cigarettes in their office, flinging their own poo at their monitor, frothing at the mouth and screaming "I CODE MY TRUTH! THIS CODE IS MY ART! IT WILL NOT CONFORM TO YOUR WORLDLY STANDARDS!"

I gave up after the first 100 lines.

Gave up.

I washed my eyes out with bleach.

Then I contacted my HR hotline to see if our medical insurance covers eye cancer.

Navy story time, and this one is lengthy.
As a Lieutenant Jr. I served for a year on a large (>100m) ship, with the duties of assistant navigation officer, and of course, unofficial computer guy. When I first entered the ship (carrying my trusty laptop), I had to wait for 2 hours at the officer's wardroom... where I noticed an ethernet plug. After 15 minutes of waiting, I got bored. Like, really bored. What on TCP/IP could possibly go wrong?
So, scanning the network it is. Besides the usual security holes I came to expect in ""military secure networks"" (Windows XP SP2 unpatched and Windows 2003 Servers, also unpatched) I came along a variety of interesting computers with interesting things... that I cannot name. The aggressive scan also crashed the SMB service on the server causing no end of cute reactions, until I restarted it remotely.
But me and my big mouth... I actually talked about it with the ship's CO and the electronics officer, and promptly got the unofficial duty of computer guy, aka helldesk, technical support and I-try-to-explain-you-that-it-is-impossible-given-my-resources guy. I seriously think that this was their punishment for me messing around. At one time I received a call, that a certain PC was disconnected. I repeatedly told them to look if the ethernet cable was on. "Yes, of course it's on, I am not an idiot." (yea, right)
So I went to that room, 4 decks down and 3 sections aft. Just to push in the half-popped out ethernet jack. I would swear it was on purpose, but reality showed me I was wrong, oh so dead wrong.
For the full year of my commission, I kept pestering the CO to assign me with an assistant to teach them, and to give approval for some serious upgrades, patching and documenting. No good.
I set up some little things to get them interested, like some NMEA relays and installed navigation software on certain computers, re-enabled the server's webmail and patched the server itself, tried to clean the malware (aka. Sisyphus' rock), and tried to enforce a security policy. I also tried to convince the CO to install a document management system, to his utter horror and refusal (he was the hard copy type, as were most officers in the ship). I gave up on almost all besides the assistant thing, because I knew that once I left, everything would go to the high-entropy status of carrying papers around, but the CO kept telling me that would be unnecessary.
"You'll always be our man, you'll fix it (sic)".
What could go wrong?
I got my transfer with 1 week's notice. Panic struck. The CO was... well, he was less shocked than I expected, but still shocked (I learned later that he knew beforehand, but decided not to tell anybody anything). So came the most rediculous request of all:
To put down, within 1 A4 sheet, and in simple instructions, the things one had to do in order to fulfil the duties of the computer guy.
I. SHIT. YOU. NOT.
My answer:
"What I can do is write: 'Please read the following:', followed by the list of books one must read in order to get some introductory understanding of network and server management, with most accompanying skills."
I was so glad I got out of that hellhole.

Wrote my friend Sam a letter when I was still working in support. I think it still holds up today.

---

Dear Sam,

I understand that you will join us in our overseas office. Congratulations on landing that job. It’s good steady work. I’ve been doing it for the last ten years.

Your still young so maybe I can give you some little wisdom that will help you in your working years to come.

Let me begin by shedding some light on phone calls.

I try. I really do try Sam. But it is getting so hard for me to hold back the rage that builds up during certain phone calls. Especially the ‘Sorry, I just don’t know anything about computers! -giggle-’ ones.

Those are the times that I have no access to what they see. I’ve no team-viewer, can not take over that screen in any other way. And why-oh-why can I not take over that terminal session dear Sam? It’s because the caller can not double-click an icon or find a terminal session number.

And what is the reason for this? Because they ‘just don’t know anything about computers! -giggle-’. This is a sort of get-out-of-jail-free card. Beware of these callers Sam.

There is nothing so nerve-wrecking then finding yourself at the mercy of people describing Internet Explorer (do not even get me started) as ‘the big ‘E’, if they use Chrome for their webmail then they most likely will say ‘Mail’ if they mean Chrome. There is no logic Sam. That is just the way these people work.

They will suck all enjoyment out of your work. They will make you want to hunt them down in dark office hallways and show them your tears Sam. Because cry you will.

Sure, I understand that not everyone can be tech savvy. Why, if everyone would be, where would that leave us? No. I love the technologically challenged. They put the fiber in my internet. They make me LOL for real. After the initial anger subsides anyway.

But just below that well-willing folk, on the other side of that border… there they dwell: Management.

Nice cars, suits and iphones Sam. First thing a new manager will require is a brand spanking new business-card. It will hold his/her new title. Then an iphone or overpriced android model will follow suit.

Then they will barge into your office, holding it like it’s the next best thing since sliced bread.

Any manager will automatically assume that you will drop anything you are doing at the present moment to acknowledge the presence of greatness. Failing to do so will result in awkward yet fulfilling situations. I recommend that you do not take your hands of the keyboard and give only the slightest of nods after 5 minutes of complete silence and glaring.

Well… you feel the glare. You do not glare yourself. You do not break eye-contact with the monitor. It does not even matter if you are typing for real or not. I once clicked away happily for 5 minutes. I just typed ‘he is still there’ over and over again. Do not break down Sam. This moment will decide your relationship with this individual.

After the nod there will be a flood of words aimed in your general direction. You can disregard anything that is said. It boils down to ‘can not operate device’.

You then take the device from this person and put it next to you on your desk. You’ll ask the name of this simpleton, write it down on a sticky-note, slap that on the phone. Then you’ll write a random date in the not so near future on another sticky and hand that to the bewildered person in front of you.

It will usually utter some incoherent words about ‘needing, time or but’ (I find that ‘but’is a word they like. They tend to use it three or four times consecutive before you usher them through the door).

Now you’ve won Sam. Well… not really. But it will feel good, I can guarantee that.

This must do for now. A new suit is glaring at me for the last five minutes.

Felt good to do something productive with this time.

Take care,

Baltasar

P.s. I just noticed that there is some foam around his mouth. So if you encounter this, don’t worry: it seems to be perfectly normal.

The more I'm on here the more I remember all the shit I have had to deal with in the past.

Anyway, lets rant! I just moved cities after college to be closer to my family, I didnt have any work lined up at that stage but started job hunting the moment I was settled in, I did some freelance for smaller companies to stay afloat.

Eventually I got a job at this agency startup where "SEO" was there main focus, still very inexperienced they put me on frontend and data capturing but will teach me how to code using their systems in due time. At this stage I was getting paid minimum wage, but I was doing minimum work and it wasnt that bad.

A new investor bought 49% of the company and immediately moved into the office space to focus more on marketing (He was one of those scaly marketing guys that will sell you babies if he could get his hands on enough to make a profit).

This is where everything starts going to shit. He hires a bunch of "SEO Gurus", fills up the small office with people like sardines squished together. Development was still our main money maker at this stage, so there where 3 new more senior developers at this stage and I started learning a lot really fast.

Here are some of the issues we had to deal with:

1. Incentives - Great more money, haha! No, No, you where 5 minutes late so you only get half of the promised amount.

2. For every minute you are late we will deduct it from you paycheck (Did I mention I was getting paid minimum wage).

3. If you take a smoke break we will dock it from your pay.

4. Free gym membership to the gym downstairs, but you can only go once a week during your lunch.

5. No pay raises if you cant prove your worth on paper.

He on purposely made up shitty rules and regulations to keep us down and make as much profit as he could.

Here are some shitty stuff he has done:

1. We arent getting a 13th check this year because the company didnt make a big profit - while standing next to his brand new BMW.

2. Made changes over FTP on clients work because we where too slow to get to it, than blames me for it because its broken the next day and wants to give me a written warning for not resolving the issue Immediately. They went as far as wanting to fire me for this, gave me 1 day notice for meeting and that I can bring a lawyer to represent me (1 day notice is illegal, you need 5 days where I am from), so I brought a lawyer since my mom was a lawyer. They freaked the fuck out and started harassing me about this a week later.

3. Would have meetings all the time about how much money the company is making, but wont be raising our pay since no one has proven they are worth it yet.

4. Would full on yell at employees infront of the entire office if they accidentally made an mistake on a clients project.

One one occasion I took a week off for holiday, my coworker contacted me to ask a question and I answered that I will handle it when I am back the following week. Withing 2 hours my other boss phones me in a rage, "he is coming to fetch the company laptop from my house in 5 minutes, he will let me know when he arrives. Gives me no time to talk at all and hangs up - I have figured out what has happened by now so when he showed up he has this long speech about abandonment, and trust and loyalty to the company. So I pass him my laptop once he shut up and said: "You do know I am on holiday leave which you approved, right?", he goes even more silent and passes me back my laptop without saying anything, and drives off.

While the above was happening Douche manager back at the office has a rage as well and calls the whole office (25 people) to a meeting talking about how I abandoned the company and how disgraceful that is.

Those are the shitty experiences I can remember, there where many more like this. All of the above eventually led to me going into a deep depression and having panic attacks weekly, from being overworked or scared to step out of line. Its also the reason I almost stopped coding forever at that stage. I worked there for 2.5 years with the abuse.

I left 2 weeks after the last shit show, I am ok now and have my anxiety and depression well under control if not almost gone completely.

Ran into Douche Manager a few months ago after 9 years, the company got bought out and the first person they fired was him. LOL! He now has his own agency and is looking for Developers (They are hard to find he says), little does he know I spread his name far and wide to all and every Dev I knew and didnt know to avoid working for him at all costs. Seems like word of mouth still works in this digital age.

Thanks for reading this far!

Alright fellow sweaty programmers, mama Kiki is here to teach you the basics of hygiene.

TEETH
- If you have a toothpaste prescription, use it.
- Every single whitening toothpaste is a scam. Don’t use them.
- Every single over-the-counter toothpaste that decreases sensitivity does work. If your teeth are sensitive, use it.
- Otherwise, buy the cheapest name-brand toothpaste.
- Use dental floss. As long as it’s flat and waxed, the cheapest one will do.
- When flossing, never move the floss back and forth as if you try to saw through your gums. Just put the floss in, then out. Repeat if necessary.
- Don’t put your toothpaste on your toothbrush. Put a small amount of it directly in your mouth with a bit of water. Close your mouth and spread toothpaste all over your teeth using a rinsing motion, as if it was mouthwash. Now your teeth are completely covered.
- When brushing teeth, don’t use -90°/0°/90° angles. Use -35°/35°. This way you will spend less time while getting better cleansing. Bristle ends should touch where your teeth meet your gums.
- Get yourself a tongue scrubber. Scrub your tongue until what comes off of it is clean. Dirty tongue is why your breath smells bad, not dirty teeth.
- After you’re done, don’t rinse! Spit the toothpaste out, but let its residue stay there. The remineralization process is now started. If you follow the routine, you don’t need mouthwash at all.
- Drinking/eating sugary things, not washing your teeth and going straight to bed is the best way to get cavities ASAP. In your mouth, sugar quickly turns into the kind of acid that we use for soldering. It can strip the oxide layer off of copper. Do you know how after you drink Coke, your teeth become almost squeaky clean? That’s this. If you like sugary drinks, carefully drink them using a straw. Rinse immediately after you’re done drinking & eating.

SHAVING
- Get yourself an old-school safety T-razor, the one that takes suicide blades. It will last a lifetime. Mühle and Merkur are good manufacturers (not affiliated). Once you have it, for the rest of your life, you will only buy blades. This is the most environmentally friendly way to get a clean, close shave. Electric razors save water, but they often contain batteries.
- Because of how violently electric razor’s blades hit hair while cutting it, they chip your hair. This leads to your freshly grown hair being sharp, rough and unpleasant to the touch. The manual razor, on the other hand, produce clean edges. When your hair grows back, it will be softer than what you get with an electric razor.
- Feather brand blades (not affiliated) are the sharpest in the world. The sharper the blade, the less traumatic it is. Watch T-razor tutorials on YouTube. There are different shaving techniques that will get you a killer shave.
- T-razor blades last considerably longer than their modern soyboy single-use counterparts.
- Because of a single blade construction, T-razor almost never leaves irritation.
- Basically, modern single-use plastic blades are horrible for the environment, and they’re almost a scam for how much you get for your money. They’re only rivaled by printer ink. Use them only for intimate shaving, as they’re considerably handier down there.
- Always shave after hot shower.
- Before shaving, dry the skin surface. Apply shaving foam on dry skin only, as it contains chemicals that make your hair softer. When diluted, they’re not as effective, and shaving unsoftened hair is almost always unpleasant and dangerous.
- After applying the foam, wait about a minute for the foam to work. If the skin gets irritated, don’t wait for as long, or perhaps try a different foam brand.
- Before shaving, thoroughly clean your razor with hand sanitizer or ethanol. Ideally, it should be sterile. Using boiling hot water is also a good option, just be careful with it.
- After shaving, rinse off foam, immediately dry your skin with a clean towel, then apply aftershave. After applying it, don’t touch your skin until it completely dries. If you follow this routine, your skin won’t get any pimples, guaranteed.
- Scrubs won’t help you. Don’t use them.

More in the comments!

My coworkers and I work in close quarters in a laboratory all day. We all get along well, and since we don’t have “offices” and often work together on things, we are a pretty close team.

We recently got a new member, Jill, who is 22, and this is her first job out of college. She lives at home with her parents, who are incredibly well-off, and has lived at home all through college. The rest of us are late 20’s to late 30’s. Jill is very nice but also very sensitive and somewhat immature, and I’m not sure if she’s just not 100% sure how to deal with people in professional settings yet or what’s going on, but almost everything that comes out of her mouth has to do with money, mainly how much money her family has. If it might offer some context, Jill and her family are not from the U.S., but have been here since Jill was a teenager.

I usually just kind of inwardly roll my eyes and change the subject, but with the holidays it’s gotten considerably worse and Jill is driving my team and me crazy. Some examples of things she has said just in the past week are: “My dad’s buying my mom a new car for Christmas!” “I’m going to buy my mom a Gucci Keychain for Christmas. It’s $225 dollars!” “I’m so excited, my mom is buying my puppy a Tiffany collar for Christmas!”

The thing that sent me over the edge was when a male coworker asked for ladies’ opinions on a very nice coat he was considering buying for his girlfriend. My opinion was something along the lines of “I like it, but I would go with the gray because white coats get dirty very easily, in my experience,” whereas Jill’s opinion was “It’s not even a name brand, you should go with either a North Face or a Michael Kors.”

I am honestly not sure if Jill knows there are people in the world who are not as well-off as her family is, and that people who aren’t as “fortunate” don’t want to hear these kinds of things every day. We are not paupers, but we are definitely not buying our dogs Tiffany collars. Is there a way that I can tell her to please stop talking about how rich her family is, without sounding jealous or mean, or causing a lot of friction on my team? Like I said, she’s a nice person, but money is a touchy subject in any capacity and I think this might hinder her professionally in the future, not to mention that we’re all sick of hearing about it!