So I was code reviewing this guy's code before merging into the master branch.... and then I FOUND THIS FUCKING CODE, WHAT THE FUCK!!!!!!!!!!!!!!!! What the fuck is this ???

*Screaming in terror and confusion*

@SoldierOfCode yea , I can feel this too...and I already screaming...

could be an override.

I've seen enough async shit for one day, and you go and throw this... at me.

Fuck me dead @rutee07, I don't want to live anymore.

@C0D4 Bro, chillax..... we are on the same boat. I begin to question my life when I saw this in the PR.

@johnmelodyme

Hahaha, sorry, it's been one of those days where nothing you do, no matter what the fuck you do, breaks anyway.

Seriously wtf is Y.R.T 😧

some people don't deserve to write code when there's absolutely no way in knowing what it's doing.

@C0D4 Exactly What I was thinking about what the F is Y.R.T as he declare it in .gitignore. which I am confused even more .

Technically he ignored it, I can't read the file because it doesn't exist.

@johnmelodyme wait what!

So we call this random Y class... well I'm assuming it's a class, and prevent it from being added to the code base 🤨

Am I missing something or does this guy not know how things work?

@C0D4 I also think Y must be a public class. I am confused too, why he declare the module in .gitignore . he add this line K/ in there, I assume how many modules are ignored.

I believe the K is a folder if I am not wrong.

@johnmelodyme if K/ is in the git ignore then yea it's a folder somewhere.

But how you get from K to Y.R.T.t(), I pray for you

Hmm.

So, K is a folder
Y is a module or namespace
R is a class
T is a method
Leaving us with that little t
Hmm 🤔 a setter maybe?

But either way, fuck this guy!

@C0D4 I told him to refer to the documentation I wrote about the company's coding guideline.

I clear explain that the delaration of the variable must be clear something like let customer_id = 'something; ' for methods :

function get_customer_details(param1, param2) {}

I don't know how he understand his code.

I told him to redo it.

I love the "// this is a function".

@atheist that's unnecessary though

@atheist
// good luck

Would have been more accurate to what this is trying to do 😏

@johnmelodyme That's why I love it😉

Did he put the brackets around k just to make things clearer 😳

"What the fuck is this ??"
It is a function.

It's a good thing he added:

// this is a function

in case you forgot what it is

Why bother with 'payment_successful', just replace it with '😏'

Did they fucking made a patch for the minified version of something? Wtf

Bro do you even jsdoc

Damn bro! When did you go to Coding Hell?

that dev be humming the alphabet song while coding

It’s d clean code mortal enemy for sure haha

Ah yes, the You aRe Truly trash design pattern, used to annotate the programmer himself as a retard.

It's not very popular, but it has its uses

fire him :D unless he is a junior and did this mistake first time.

“This is a function”

But what if not i?
No return then?
🤔

@atheist that's how you know that this code is actually a work of art

@brrrTrrrDrrr I guess gore is a form of art.

Nice username btw.

Copy/paste from an optimized code I presume.

@wf3d If this is the case , im even more confused...

Looks like minified code, what the hell

Code is obviously copy-pasted from some minified script

But... That comment. That was likely added by him. Which is scary.

And that is why a good mathematician isn't neccessarily also a good coder.

Get HR to stop using algorithm-related interview questions!

Felt this, there was a guy at a company I worked at who took his revenge for the team not writing code in x86 by writing C like this. Single letter vars and methods, wasn't his fault or problem if the others weren't keen on playing detective every time they wanted to work on his code.

Dunno the context but I'd report this or give the guy a chewing out yourself, if you can. There is zero benefit to code that no fucker can even read, especially if it's dealing with actual money.

@MM83 even he will forget

Is this part of some minified code?
If not, you might want to minify your dev team a bit.

I'm intrigued and confused.

I don't get the confusion?
Like others noted this is a function and if i then yrtt payment succesful.
Yolo right?

@Root it wasn't a minified code. He explained to me he was lazy to name the function and class full name and also save space.

Weird.

@johnmelodyme I'd like to punch that person

@melezorus34 If you are in my country, I will fetch you all the way to his home. and gladly be my guest.

I’d be too lazy to pay him, and also save space on the team for someone better suited. :)

@Root Wow will be my excuse, maybe I can propose to my manager, hahaha

@Root The funny thing is he frequently told us that he worked for Facebook previously. (Well , I don't see any company named Facebook in Malaysia and in order to work with Facebook , he need to work in the US, and he doesn't have a passport. )

@johnmelodyme Oh dear.

@Root Yeap that's what @TeachMeCode will react too.

@Root @johnmelodyme 🦌lol

Looks like something GitHub Copilot would come up with.

I'd simply add a comment to this line of code, "Fix variable/method naming, write cleaner code" and not approve the PR

@Angry-dev he is junior actually .

@vergil and GitHub Copilot reaction will be like 😱😱😱😱😨😨😨😨😰😰😰😰😨😨😨😱😱😰😰😨😨😱😨😰😰😨😨😡😡😡🤬🤬🤬🤬😡😡😠😱😱🤯🤯🤯😱😱😱😰😰😖😖😞😞😓😓😥😥😢😢🥱🤮🤮🤮🥵🤢🤯💀

Normally I try to contribute something constructive to threads. Not this time.

Fuckity fuckity fuck

@C0D4 there is no reason for this to be async as there is no internally awaited code. 😶

@johnmelodyme just reject the PR with "insufficiently documented". 🤷‍♂️

@kwilliams I rejected the PR. And asked him directly wtf was going on.

@kwilliams and then this happened https://devrant.com/rants/4717638/...

This actually looks like production code. Did this genius build the project and copy the minified version of the function over the original?

What in god's name is this nonsense lmao

@jfgilmore yes I agree.

@RexGalilae I genuinely have no idea what he do.

@johnmelodyme maybe he's doing this to get around not being able to use his favourite library due to it but being approved by the tech lead

Dude you are acting very sus,
`git blame @RexGalilae+noreply@devrant.com`

@melezorus34
Lmao nah. Just trying to add some method to this madness

Writing in obfuscated code directly

You sure the guy's name doesn't end in Webpack or something?

Fuckin procrastination

"Payment successful"
Maybe he just had it and wrote a function to pay himself