This code review gave me eye cancer.

So, first of all, let me apologize to anyone impacted by eye cancer, if that really is a thing... because that sounds absolutely horrible. But, believe me, this code was absolutely horrible, too.

I was asked to code review another team's script. I don't like reviewing code from other teams, as I'm pretty "intense" and a nit-picker -- my own team knows and expects this, but I tend to really piss off other people who don't expect my level of input on "what I really think" about their code...

So, I get this script to review. It's over 200 lines of bash (so right away, it's fair game for a boilerplate "this should be re-written in python" or similar reply)... but I dive in to see what they sent.

My eyes.

My eyes.

MY EYES.

So, I certainly cannot violate IP rules and post any of the actual code here (be thankful - be very thankful), but let me just say, I think it may be the worst code I've ever seen. And I've been coding and code-reviewing for upwards of 30 years now. And I've seen a LOT of bad code...

I imagine the author of this script was a rebellious teenager who found the google shell scripting style guide and screamed "YOU'RE NOT MY REAL DAD!" at it and then set out to flagrantly violate every single rule and suggestion in the most dramatic ways possible.

Then they found every other style guide they could, and violated all THOSE rules, too. Just because they were there.

Within the same script... within the SAME CODE BLOCK... 2-space indentation... 4-space indentation... 8-space indentation... TAB indentation... and (just to be complete) NO indentation (entire blocks of code within another function of conditional block, all left-justified, no indentation at all).

lowercase variable/function names, UPPERCASE names, underscore_separated_names, CamelCase names, and every permutation of those as well.

Comments? Not a single one to be found, aside from a 4-line stanza at the top, containing a brief description of that the script did and (to their shame), the name of the author. There were, however, ENTIRE BLOCKS of code commented out.

[ In the examples below, I've replaced indentation spacing with '-', as I couldn't get devrant to format the indentation in a way to suitably share my pain otherwise... ]

Within just a few lines of one another, functions defined as...

function somefunction {
----stuff
}

Another_Function() {
------------stuff
}

There were conditionals blocks in various forms, indentation be damned...

if [ ... ]; then
--stuff
fi

if [ ... ]
--then
----some_stuff
fi

if [ ... ]
then
----something
something_else
--another_thing
fi

And brilliantly un-reachable code blocks, like:

if [ -z "$SOME_VAR" ]; then
--SOME_VAR="blah"
fi

if [ -z "$SOME_VAR" ]
----then
----SOME_VAR="foo"
fi

if [ -z "$SOME_VAR" ]
--then
--echo "SOME_VAR must be set"
fi

Do you remember the classic "demo" programs people used to distribute (like back in the 90s) -- where the program had no real purpose other than to demonstrate various graphics, just for the sake of demonstrating graphics techniques? Or some of those really bad photo slideshows, were the person making the slideshow used EVERY transition possible (slide, wipe, cross-fade, shapes, spins, on and on)? All just for the sake of "showing off" what they could do with the software? I honestly felt like I was looking at some kind of perverse shell-script demo, where the author was trying to use every possible style or obscure syntax possible, just to do it.

But this was PRODUCTION CODE.

There was absolutely no consistency, even within 1-2 adjacent lines. There is no way to maintain this. It's nearly impossible even understand what it's trying to do. It was just pure insanity. Lines and lines of insanity.

I picture the author of this code as some sort of hybrid hipster-artist-goth-mental-patient, chain-smoking clove cigarettes in their office, flinging their own poo at their monitor, frothing at the mouth and screaming "I CODE MY TRUTH! THIS CODE IS MY ART! IT WILL NOT CONFORM TO YOUR WORLDLY STANDARDS!"

I gave up after the first 100 lines.

Gave up.

I washed my eyes out with bleach.

Then I contacted my HR hotline to see if our medical insurance covers eye cancer.

I can’t count money as quick. I don’t know how to operate a cash register. I’m bad at following small tasks in the kitchen. Ex: girlfriend yells at me for putting unstrained yolk in recipe (after straining it).

I can’t lift heavy stuff. Out of breathe helping my mom move. My uncle told me, “if you can’t do that, how can you work?” Then he touts his son around proudly for being in the army. I felt like shit for years.

My cousins told me to get a job at McDonald’s to learn the value of a dollar. I spent all this time studying and hadn’t found a single job at the time (not that I was looking). I was living off financial aid and some income from an app that sold for a dollar on the App Store.

I would mess up if I worked there. It was depressing guys. These people who worked at McDonald’s and Starbucks. It was like a cool club that I couldn’t be a part of! I wanted to be that smooth barista at Starbucks with a smug look on my face. Making coffee for all the ladies and writing hearts next to their name on the cup.

The responsibilities of going to work day after day and blowing your paycheck at a meal at Denny’s with your friends. Complaining about not getting enough hours and talking about adult stuff! Sigh sigh sigh. Oh and taxes! Let’s complain about taxes on a single W-2 just for the hell of it (not sure why they do this when you can file a simple 1040EZ) even though we get a refund.

Then..

After many paid internships (roughly 3), now I may be receiving an offer that is 100k+ with a 401k and all benefits I can imagine. Free food up the wazoo. Gym on site. Happy hour Friday’s.

I brag about taking a shit for an hour at work and coworkers don’t give a shit. Or taking a day off to do personal errands anytime.

Having my own place in a nice area (though the cost of living is enough to take care of 3 families in another state). Supporting my girlfriend through school and helping her with her dreams of art.

Going to fancy dinners and not worrying about the bill afterwards.
Accidentally damaging my 2017 Honda Accord and not giving a fuck because I can pay $900 for repair with less than a week of work.

But I can’t help but think that all this time..

I could’ve just quit and worked at McDonalds. I could’ve been one of the cool kids..

There is no such thing as an 'idea' person.

Learn to art, learn to code, or learn to FUCK OFF!

Talented people can take bad ideas and make gold.

Without skill the best idea will turn out garbage.

Microsoft Office Sharepoint Server.

There is no technology on Earth that speaks worse of Microsoft than is this crap. Nothing they ever made (not even Comic Sans) is as bad as Sharepoint.

No proper editor. Everything is slooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooow. To run it you need a state-of-the-art server. There is no way to make the UI modern, as Sharepoint itself is built upon 1995 era HTML. Tables in tables in tables in tables in tables. And even if you do a web part that's readable, it will be wrapped in shit and presented to the client anyway.
It's so easy to break too. Most of the time I was just watching why the fuck it didn't work. Huge problem with caching as well. Deploying any change requires 10 minutes of manual labor.

I get why companies want to use it. Out of the box it's got quite a few very nice features, and aside from the problems setting it up, and hardware requirements, it works decently well.

But I won't come near it unless I'm paid 100$ per hour or starving to death.

Getting told by someone who is almost to stupid to open a word file how easy it would be to develop XYZ.

When I was at university in my last semester of my bachelor's, I was doing a game programming paper and our last assignment was to group up and make a game. So I go with one of the guys I know and this other dude since his previous game was really neat. Then two randoms joined that from my first impressions of their games wasn't much at all (one guy made four buttons click and called it a game in Java when we had to make games in c++ and the other guy used an example game and semi modded it.

Anyways we get to brain storming, totally waste too much time getting organised because the guy that volunteered (4 buttons guy) was slow to getting things sorted. Eventually we get to making the game and 4 buttons guy hasn't learnt how to use git, I then end up spending 3 hours over Skype explaining to him how to do this. He eventually learns how to do things and then volunteers to do the AI for the game, after about a week (this assignment is only 5 weeks long) he hasn't shown any progress, we eventually get to our 3rd week milestone no progress from him and the modder, with only three classes left we ask them both to get stuff done before a set deadline (modder wanted to do monsters and help 4 buttons with AI) both agreed and deadline rolls up and no work is shown at all, modest shows up extremely late and shows little work.

4 buttons guy leaves us a Skype message the day of our 2nd to last class,, saying he dropped the paper...

Modder did do some work but he failed to read all the documentation I left him (the game was a 2d multiplayer crafting game, I worked so hard to make a 2d map system with a world camera) he failed to read everything and his monsters used local coordinates and were stuck on screen!

With about a week left and not too many group meetings left we meet up to try and get stuff done, modder does nothing to help, the multiplayer is working my friend has done the crafting and weapon system and the map stuff is working out well. We're missing AI and combat, with our last few hours left we push to get as much stuff done, I somehow get stuck doing monster art, AI is done by the other two and I try to getting some of the combat and building done.

In the end we completely commented all of modders work because well it made us look bad lol. He later went to complain to my free claiming I did it and was a douchebag for doing so. We had to submit our developer logs and the three of us wrote about how shitty it was to deal with these two.

We tried out best not to isolate ourselves from them and definitely tried to help but we were swamped with our other assignments and what we had to work on.

In the end leaving and not helping right when the deadline is close was what I call the most shittiest thing team mates can do, I think sticking together even if we were to fail was at least a lot better.

School thought me which "cutting-edge" technologies I should avoid at all costs:

"I want to fucking die" - tier:
- JQuery UI
- JSP
- JSF
- Vanilla PHP
- Java 5 and earlier
- Java and Rest
- Old Eclipse

"Mastering the art of headbanging" - tier:
- JPA
- JQuery

You may argue that some of them are not as bad as I think of them but the I was introduced to them made me despise them. We were never introduced to the documentations. Only to the sheets our teacher prepared and I think he completely pissed the point of some of them.

Rest example:
/resource/{resource_id}/action/{action_id}/username/{username}/password/{password}

I fucking hate chained methods. Ok, not all of them. Query things like array.where.first... that stuff is ok.

Specially if it's part of the std lib of a lang, which would be probably written by a very competent coder and under scrutiny.
But if you're not that person, chances are you'll produce VASTLY inferior code.

I'm talking about things like:
expect(n).to.be(x).and.not(y)

And the reason I don't like it is because it's all fine and dandy at first.

But once you get to the corner cases, jesus christ, prepare to read some docpages.

You end up reading their entire fucking docs (which are suboptimal sometimes) trying to figure if this fucking dsl can do what you need.

Then you give up and ask in a github issue. And the dev first condescends you and then tells you that the beautiful eden of code he created doesn't let you do what you want.

The corner cases usually involve nesting or some very specific condition, albeit reasonable.

This kind of design is usually present in testing or validation js libraries. And I hate all of those for it.

If you want a modern js testing lib that doesn't suck ass, check avajs. It's as simple as testing should be.

No magic globals, no chaining, zero config. Fuck globals forced by libs.

But my favorite thing about it that is I can put a breakpoint wherever the fuck I want and the debugger stops right fucking there.

Code is basically lines of statements, that's it, and by overusing chaining, by encouraging the grouping of dozens of statements into one, you are preventing me from controlling these statements on MY code.

As an end dev, I only expect complexity increases to come from the problems themselves rather than from needlessly "beautified" apis.

When people create their own shitty dsl, an image comes to my mind of an incoherent rambling man that likes poetry a lot and creates his own martial art, which looks pretty but will get your ass kicked against the most basic styles of fighting.

I fucking hate esoteric code.

Even if I had to execute a list of functions, I'd rather send them in an array instead of being able to chain them because:
a) tree shaking would spare from all the functions i didn't import
b) that's what fucking arrays are for, to contain several things.

This bad style of coding is a result of how low the barrier to code in higher level langs are.

As a language or library gets easier to use you might think that's a positive thing. But at the same time it breeds laziness.

Js has such a low learning curve that it attacts the wrong kind of devs, the lazy, the uninspired, the medium.com reader, the "i just care about my paycheck" ones.

Someone might think that by bashing bad js devs I'm trying to elevate myself.

That'd be extremely stupid. That's like beating a retarded blind man in a game and then saying "look, I'm way better than this retarded blind man".

I'm not on a risky point of view, just take a stroll down npmjs.com. That place is a landfill. Not really npm's fault, in fact their search algorithm is good.

It's just the community.

Every lang has a ratio of competence. Of competent to incompetent devs.

You have the lang devs and most intelligent lib devs at the top. At the bottom you have the bottom.

Well js has a horrible ratio. I wouldn't be shocked to find out that most js devs still consider using import or await the future.

You could say that js improved a lot, that it was way worse beforr. But I hate chaining now, and i hated back then!

On top of this, you have these blog web companies, sucking the "js tutorial" business tit dry, pumping out the most obscenely unprofessional and bar lowering tutorials you can imagine, further capping the average intelligence of most js devs.

And abusing SEO while they're at it, littering the entire web with copy paste content.

"Graphics don't matter."

I ranted a while back about gamedev being hard to get into for me, and, today, user @DOSnotCompute posted a similar experience.

I had a couple more thoughts, so thought should post them here (FUCK! It ended up being too fucking long! sorry!)

So I was watching the making of mortal kombat 3 on yt, which was pretty amazing btw because I got to see the actors of the sprites in game which were engraved in my and thousands of others kids minds.

Anyhow, the creators of the series, John Tobias and Ed Boon, were interviewed and what not. And it hit me that while both were the designers, John was the main artist and Ed was the programmer (at least for MK1). Another game that comes to mind Super Meat Boy, and I bet hundreds of others did the same.

And it got me thinking, maybe that's my problem, I just need an artist.

And I think the reason why I never thought of that is because of this idea that graphics don't matter.

"you don't need an artist. You don't need graphics. The most important thing is the gameplay."

What a load of shit.
A lot of people believe that because they got tired of polished AAA games with automatic and predictible gameplay.

People started parrotting this knee jerk of a conclusion since then.

It's dumb. Imagine if Infiminer, one of the games Minecraft was based on, which btw looks terrible, had all the same features Minecraft had.
I would still not touch that shit with a pole.

Graphics ARE important. Games are on the VISUAL medium.
That doesn't mean you're sucking Sony's dick on every AAA release or that every game should be made with UnreUnityCocksReloadedEngine.

Some level of visual craft is required for a game ro be considered such.

(btw, I think most of you guys here get this, not trying to pander, just that I want to make it clear that I'm not accusing this community of being guilty of this)

If a game looks bad (given, bad can be subjective), if it gives the impression that it wasn't seriously made, then you kinda lower your expectations.

People get hyped on games that look good, because it means that the game could be good. Games that look unoriginal or terrible won't get played, wether they're good or not. And I think it's a reasonable reaction.

How many times did I hear things like "Look at x video game from the 90s, the graphics are terrible but it's fun as hell".

That is an absurd statement. The level of production some NES games went through is insane. We're talking millions of dollars for games that today might look primitive.

The graphics weren't shit back then, and even today you could say that they are simpler but also of excellent craftsmanship.

I'm not into creating art, I hate it in fact because you can't quantify the success of produced art.

So, duh, find an artist. Ok, how? This is the part where I have no fucking idea how.

You start spamming shit like "I need an artist" online? I dunno, something for another post I guess.

I guess the most healthy thing I could do is making demos that might look like shit just to get experience so that when I get to find an artist, I have practice already.

Honestly, mentoring is in my opinion the best part of the job. My firts mentee was a student in my last job, smart af but lazy and unable to trust in herself. I wasn't really too sure in myself at the time either but since I had to teach hery craft there was no place for me to doubt myself.

So I taught her everything I knew and in turn I learned to trust myself and once I had mastered the art of self confidence I could make her believe in herself. Since then I trained five more test automation engineers, some of them might be close to surpassing their 'master' (though won't make it easy for them 😏) and with every Single one I've developed a deeper understanding of my craft by explaining. I needed to research stuff I never questioned to answer their questions and therefor became better at what I do.

Three weeks ago I got an email from the girl I first mentored, she's in another company now and she thanked me for what I taught her. In my opinion I did a rwally Bad job at it (it was my first time teaching) but reading someone actually believing that one made an impact in their life is something special.

I always loved talking about my craft and I love sharing the knowledge I aquired. Test automation is not a thankfull craft but I'm always happy whenever I can interest someone in it and I fully enjoy seeing them grow and improve into fully fledged TAEs.

So I'm not one to show off something buuuuuuut, I'm a programmer and can barely draw a straight line let alone do pixel art, but I decided fuck it; let's try again and considering the left figure was the first compared to the right being the 10th, I'd say that's not to fucking bad :-D

An intern made a very bad impression on the first day.

This was before I become a developer. I was working in commercial art sales. One day, I had an appointment to onboard two new interns together.

Intern 1 shows up and I ask her for her signed confidentiality agreement. The boss had sent it out a week before and told me the interns were bringing the signed paperwork on their first day. I see the surprised look on her face and she says she forgot. She’s lucky I had access to another copy. If I didn’t, things could have gotten pretty awkward if I had to contact my boss, who was out of office. If there’s no signed agreement, I can’t onboard her and I’d have to send her home. The appointment was made with intern 1’s availability in mind, so intern 1 could have spent her time coming to the office for nothing and being turned away because of a stupid mistake she made.

While we wait for intern 2 to arrive, I try to engage in small talk with intern 1. I try to get to know her a little better and I ask “are you still in college/university?” She word vomits that she thought she had graduated, but six months later she hadn’t received her diploma and she called the school and they told her her pre-college credits had not transferred, so she’s finishing those credits now.

Oh, intern, you should have just simplified all this to “I’m finishing up my degree” or “yes, I’m still in college.” This is TMI. You don’t want to give out information about yourself that could put you in a bad light. You need to know to be discreet about yourself. You’re 22 years old. It’s really bad judgement to say this to your supervisor (me) and we’ve only known each other for ten minutes. I’m not your friend, I’m your supervisor. Honestly, I thought the explanation didn’t make sense because she would have found out about the credits when she tried to transfer them and when she applied for graduation. I didn’t prod for more details.

I did have to tell my boss about intern 1 forgetting the paperwork. It’s not something the intern would be reprimanded for, but it is something that’s not a good sign. The paperwork had been sent by the boss a week prior. It’s troublesome that an intern would forget to complete an important task that was sent by the boss. This was never a problem with prior interns.

Boss did freak out because boss thought I onboarded intern 1 without intern agreeing to the confidentiality agreement. Boss hadn’t considered an intern would forget the paperwork and didn’t tell me what to do if this did happen. I reassured boss that I had printed a new copy and had intern 1 sign the agreement.

I didn’t say anything about the word vomit. The content was troubling, but I was concerned this would be gossip and I wasn’t out to sabotage the intern.

Forgetting the paperwork and the word vomit were signs the intern wasn’t reliable. Intern had trouble taking direction even when it was written down. She’d do stupid things like invite her boyfriend to the office for hours and let BF sit at the boss’s desk—boss caught her and boss’s office is visible from our public viewing floor, so visitor did see this too. I suspected she might have an diagnosed learning disability.

In the end, intern didn’t ask for a reference letter. Boss said that if intern asked for one in the future, the answer would be no.

Intern 1 is the reason why I don’t want to be in change of interns ever again even though I’m not in art sales anymore.

So my company wanted a view in view look on their website. So it would look like a black background with a while box in the middle, right?

Well, the devs apparently thought that screens were capped height! On my monitor, the box is less than half the height, but since it stretches the width, the image got larger. So my screen has a scrollbar, and the actually useful part also has a scrollbar, with a shitton of space below!

If that didn't make sense, see crappy drawing of what I see...(painted on Phone). The dashes are the hidden parts that I can't see because of the window!

Good news: I've finally started learning Golang! I've wanted to do it for a while, and now I am!

Bad news: I'm getting screwed by a GTK messagedialog that when open for the second time, simply panics! The dialog is in Glade because I've got no patience to master the art of giving 5 different flags (maybe that's just 'cause it's 3 AM). Plus, I'm have a similar issue with my about dialog! COME ON!!!!

P.s. just wanna say hi again, haven't been around in a long while, so: Hi!

There is like a dozen shows streaming on how actual impostors imposted the shit out of people.

I never claimed to be the heir of a machine that can make art out of deposits of a single drop of blood to dozens of people on dating apps.
I never said that I can double their bitcoins by harvesting carbon monoxide and recycling plastic into endangered fauna, expanding the mind of humanity.
I never got private-jet levels of money to do something I knew to be completely impossible from the beginning.

If I ever feel like an impostor, I could honestly say that make for a very lousy one.
I guess I've got impostor syndrome squared - I feel like I'm really bad at impostor-ing, but people could be thinking that I am better at pretending to pretend to be something I actually am.

Gonna rant about graphic design 'cos it's where I started this journey.
The hardest people to design for are creative people, photographers, musicians, artists etc.. because they think graphic design is just a small extension to their existing skills. Please Fuck Off! Also same goes for developers, graphic design is a discipline you have to study and takes years to perfect the art. I find it examples of non designed 'design' every day and it sickens me. Just look around at all the shite van livery, bad logos, shit menus, fucking junk mail etc... sometimes it can be torture....

But I don't think coding is easy, I respect the art and learn constantly, it amazes me how typing some shit can make awesome things happen. Devs rock!

Has this ever happened to you? Some code you're trying to execute does not work at home. Then the next day when you're showing it to the team it works perfectly (yes, I know I'm a bad coder). 😁 programming: the art of creating things without knowing how you did it

This, thankfully, I didn't create myself. A shop I recently ordered something from had the worst username / password default combo.
After registration they gave you a default Password, your zip code. And your unchangeable username is your customer id, a five digit number which just increments for each new user. And because it is a shop which is only used by people of the same region there are maybe 10 different zip codes.

Being able to work from where ever i want, at best from home. To be there when my kids wake up after doing an all nighter.

"It takes the same amount of effort to make bad art as to make good art, and you won’t know which you’ve made until you release it into the wild. You can continue to refine a work until it doesn’t set off your own quality alarms, but that’s no guarantee that what you’ve made will touch anybody." - Nate Simpson

Okay so being a developer is mostly like playing a never ending game of whack-a-mole with BUGS, you think you have fixed one until few more pops up like a bad case of acne.
But you know what's even worse? When you finally get something working, and you're feeling all proud of yourself, and then someone comes along and tells you that it's not "visually appealing" enough. "Can't you just add some more glitter and unicorns to the homepage? Oh, and can you make it look like it was designed by a unicorn who majored in art?"

Mayakovsky, Malevich, Kandinsky and all that art movement.

Too bad was neither bauhaus nor Aalto. My code would’ve been much cleaner but waaaay less expressive, and expression is what I strive for.

Is an art director/manager that makes designs for an existing website expected to brief the developer on how he wants his new designs to work? Or is the developer expected to innately understand what his functional desire is from the design itself?

My art director/manager claims that he shouldn't have to log into the backend to see how things relate to one another, and that his designs alone should imply what is intended.

When some design element overlaps an existing image gallery, am I expected to magically know whether this element is singular or partaining to the current image shown?

I want to know whether or not me getting mad at him for not telling me how he wants stuff to work is valid, and whether or not I should demand that he briefs me how his design relate to existing taxonomy.

Am I the bad guy?

There are two kinds of art and leisure: Apollonian and Dionysian. Apollo was the god of light, knowledge and other such things. Dionysus was the god of wine and ritual madness. In a nutshell, the beauty of the stars in the sky is Apollonian, and the beauty of nice juicy ass is Dionysian.

My info landscape was too damn Dionysian lately. I don’t even use TikTok or Instagram. I mean music I listened to, like aggressive dumb rap, bad slang, swearing… Wherever you look, there are Cardi B’s and Kim K’s, with their ugly eyelashes, ugly makeup, ugly inflated lips, ugly voice, ugly things they say. Watching the dumbest shit ever on YouTube. The louder you scream, the funnier the joke. Also, the number one content is some people tearing down some other people: penguinz0 destroying someone again, debunk channels, drama…

Dionysian things can be attractive and comfortable, because they speak to our animal part. In a way, Dionysian is natural. But not everything that is natural is good.

I gave my info landscape an Apollonian cleansing. Unsubscribed from a lot of debunking channels. Changed the way I speak, adjusted my vocabulary. Deleted a lot of music from my library. Went from 6ix9ine to Pink Floyd, Sting and Dire Straits.

It all started two weeks ago. I feel… different, but not necessarily better. Time will tell.