Do all the things like ++ or -- rants, post your own rants, comment on others' rants and build your customized dev avatarSign Up
From the creators of devRant, Pipeless lets you power real-time personalized recommendations and activity feeds using a simple APILearn More
Search - "codereview"
I don't fucking see how others get their stuff through code review, if when I make an enhancement it gets stopped for stuff other people did before me. Like, at this point it seems like I'm spending more and more time refactoring than simply doing the requested enhancements.
I don't blame the team, they're going off of the documentation. But this is getting ridiculous.2
I'd say it was when I did a Codereview and the dev said that he doesn't really know how the code works and he doesn't quite know what it's purpose is supposed to be.
We are talking about less then 200 lines, all written by himself, this is not copied code.1
I'm angry today. The customer's code reviewer blocked my delivery because variables of type "Context" are abbreviated as "ctx".7
Me reviewing PRs lately:
"Should I fight it now, or should I let the abscess grow?"
But in my distress/demotivation it’s usually: peace now, pain later2