My "Coding Standards" for my dev team

1.) Every developer thinks or have thought their shit don't stink. If you think you have the best code, submit it to your peers for review. The results may surprise you.

2.) It doesn't matter if you've been working here for a day or ten years. Everyone's input is valuable. I don't care if you're the best damn programmer. If you ever pull rank or seniority on someone who is trying to help, even if it isn't necessarily valid or helpful, please have your resume ready to work elsewhere.

3.) Every language is great and every language sucks in their own ways. We don't have time for a measuring contest. The only time a language debate should arise is for the goal of finding the right one for the project at hand.

4.) Comment your code. We don't have time to investigate what the structure and purpose of your code is when we need to extend upon it.

5.) If you use someone else's work, give them the credit in your comments. Plagiarism will not be tolerated.

6.) If you use flash, you will be taken out back and shot. If you survive, you will be shot again.

7.) If you load jQuery for the sole purpose of writing a simple function, #6 applies.

8.) Unless it is an actual picture, there is little to no reason for not utilizing CSS. That's what it's there for.

9.) We don't support any version of Internet Explorer and Edge other than the latest versions, and only layout/alignment fixes will be bothered with.

10.) If you are struggling with a task, reach out. While you should be able to work independently, it doesn't make sense to waste your time and everyone else's to not seek assistance when needed.

11.) I'm serious about #6 and #7. Don't do it.

Laravel is the worst framework ever.

Everything has to be made convenient and easy. That sounds amazing, because developers want to save time, worry less about boilerplate code, right? No more constructors, no more dependency injection, fuck all the tedious OOP shit... RIGHT?

It does one thing well: Make PHP syntax uniform and concise through easily integrated libraries such as Collection and Carbon. But those are actually not really part of the framework... just commonly integrated and associated with Laravel.

The framework itself is completely derailed: You can define code in a callback in the routes file. You can define a controller in the routes file. You can define middleware as a parameter to the route, as a fluent method to the route, you can stack them up in a service provider. Validators can be made in controllers, Request objects, service providers, etc. You can send mail inline, through Mailable objects, through Notification objects, etc.

Everything is macroable, injectable, and definable in a million different places. Ultimate freedom!

Guess what happens when you give 50 developers of various seniority a swiss army knife?

One hammers in a screw with a nail file, the other clips the head from the screw using scissors, and you end up with an unworkable mess and blunt tools.

And don't get me started about Eloquent, the Active Record ORM. It's cute for the simple blog/article/author/comment queries, but starts choking when you want more selective and performant queries or more complex aggregates, and provides such an opaque apple-esque interface which lets people think everything is OK, when in reality it's forcing the SQL server to slowly commit suicide.

I'm convinced code addiction is a real problem and can lead to mental illness.

Dev: "Thanks for helping me with the splunk API. Already spent two weeks and was spinning my wheels."
Me: "I sent you the example over a month ago, I guess you could have used it to save time."
Dev: "I didn't understand it. I tried getting help from NetworkAdmin-Dan, SystemAdmin-Jake, they didn't understand what you sent me either."
Me: "I thought it was pretty simple. Pass it a query, get results back. That's it"
Dev: "The results were not in a standard JSON format. I was so confused."
Me: "Yea, it's sort-of JSON. Splunk streams the result as individual JSON records. You only have to deserialize each record into your object. I sent you the code sample."
Dev: "Your code didn't work. Dan and Jake were confused too. The data I have to process uses a very different result set. I guess I could have used it if you wrote the class more generically and had unit tests."
<oh frack...he's been going behind my back and telling people smack about my code again>
Me: "My code wouldn't have worked for you, because I'm serializing the objects I need and I do have unit tests, but they are only for the internal logic."
Dev:"I don't know, it confused me. Once I figured out the JSON problem and wrote unit tests, I really started to make progress. I used a tuple for this ... functional parameters for that...added a custom event for ... Took me a few weeks, but it's all covered by unit tests."
Me: "Wow. The way you explained the project was; get data from splunk and populate data in SQLServer. With the code I sent you, sounded like a 15 minute project."
Dev: "Oooh nooo...its waaay more complicated than that. I have this very complex splunk query, which I don't understand, and then I have to perform all this parsing, update a database...which I have no idea how it works. Its really...really complicated."
Me: "The splunk query returns what..4 fields...and DBA-Joe provided the upsert stored procedure..sounds like a 15 minute project."
Dev: "Maybe for you...we're all not super geniuses that crank out code. I hope to be at your level some day."
<frack you ... condescending a-hole ...you've got the same seniority here as I do>
Me: "No seriously, the code I sent would have got you 90% done. Write your deserializer for those 4 fields, execute the stored procedure, and call it a day. I don't think the effort justifies the outcome. Isn't the data for a report they'll only run every few months?"
Dev: "Yea, but Mgr-Nick wanted unit tests and I have to follow orders. I tried to explain the situation, but you know how he is."
<fracking liar..Nick doesn't know the difference between a unit test and breathalyzer test. I know exactly what you told Nick>
Dev: "Thanks again for your help. Gotta get back to it. I put a due date of April for this project and time's running out."

APRIL?!! Good Lord he's going to drag this intern-level project for another month!

After he left, I dug around and found the splunk query, the upsert stored proc, and yep, in about 15 minutes I was done.

Interview:
Candidate claims being seasoned "senior".

Him: i don't know how the solve this
Me: you have to use binary search
Him: ahhaaa
Me: do you know binary search?
Him: yes
Me: can you please explain binary search?
Him: eghm, hmm, sorry I can't

Two places: At a major NYC firm, I was in charge of social media. I was also involved with an intranet community. Something went bad with the intranet community project politics and I got blamed for it even though I had emails to prove I hadn't said/done what I was accused of. But to assert their dominance, my bosses called me to their office, sat me in literally a corner of the room, and interrogated me for 2 hours. The only thing missing was the bright light in my eyes and the "good cop" part of the routine. I'm ashamed to say they "broke" me and I just gave up and did what they told me to do to "fix" it even though I hadn't done anything wrong. The bosses were old enough to be my parents, so I wonder how much of that worked its way into the psychology of it all.

The second toxic workplace was where each month the boss would come from his home by the beach to tell us plebes what new ideas he wanted us to work on. We would just get done reporting on the results of his delusions of grandeur from the month prior and he'd pull the rug out and start us on some new thing. Never got any consistent traction on anything. He was the ultimate seagull manager: fly in, make a lot of noise, poop all over everything, and leave us cleaning up the mess. Oh, and we had to change the locks because we had to fire a customer service guy who was a little bit on the ragey side of things. Because of high turnover, I had seniority within 4 months of starting there.

"As a leader, you should lead by example and work every day, every hour, give 150% for the dream of the company! We are detecting that people aren't giving everything to us, so you should be harder on everyone else to ensure we can deliver!
Also, your 1:1 meetings with the team should be on the Sundays to avoid spending company time on feedbacks. There is no time to feedback if you need to deliver things!"

Fuck right off with that. Will beatings continue until morale improves? Maybe seniority will arise from the gashes of the lashes on the interns.

For the first time I have enough seniority to say no to a request from another team...and it felt so good.

Ok, so I already asked when junior is no longer a junior..got mixed answers. Now I'd like to know what defines seniority level in your country?! Years of experience, having wide range of knowledge, great leadership skills, having boobs (joke).. ?!? But seriously, I have no clue what the standards in my country are, and internet is full of different opinions & examples that are making me wanna go cry in a corner.. o.O

Figured some answers from real people might help me get my head around this, so if it's not too much to ask fellow devs here, please answer this questions to help me grasp this better with examples..& non dev folks, you are welcome to comment too!!

A) What country are you guys from?
B) How is seniority defined there?
C) How are you placed by others?
D) If different, where would you place yourselves? Why?

seniority.

i know hes the most knowledgable.. but i have more experience.. so i dont need to ask any questions cause all of the answer is in my experience..

It really sucks being the senior guy sometimes because it means there's nobody above you that you can bounce questions off of. No mentor. Just random people on the internet (and stack overflow, eww.)

The rubber ducky on my monitor can only go so far.

It's a constant worry of "am I writing garbage?" and "is there a better way to do this?"

I'd kill for a QA group that I could actually send some of my stuff to and get feedback.

I really need to vent. Devrant to the rescue! This is about being undervalued and mind-numbingly stupid tasks.

The story starts about a year ago. We inherited a project from another company. For some months it was "my" project. As our company was small, most projects had a "team" of one person. And while I missed having teammates - I love bouncing ideas around and doing and receiving code reviews! - all was good. Good project, good work, good customer. I'm not a junior anymore, I was managing just fine.
After those months the company hired a new senior software engineer, I guess in his forties. Nice and knowledgeable guy. Boss put him on "my" project and declared him the lead dev. Because seniority and because I was moved to a different project soon afterwards. Stupid office politics, I was actually a bad fit there, but details don't matter. What matters is I finally returned after about 3/4 of a year.

Only to find senior guy calling all the shots. Sure, I was gone, but still... Call with the customer? He does it. Discussion with our boss? Only him. Architecture, design, requirements engineering, any sort of intellectually challenging tasks? He doesn't even ask if we might share the work. We discuss *nothing* and while he agreed to code reviews, we're doing zero. I'm completely out of the loop and he doesn't even seem to consider getting me in.

But what really upsets me are the tasks he prepared for me. As he first described them they sounded somewhat interesting from a technical perspective. However, I found he had described them in such detail that a beginner student would be bored.
A description of the desired behaviour, so far so good. But also how to implement it, down to which classes to create. He even added a list of existing classes to get inspiration or copy code from. Basically no thinking required, only typing.

Well not quite, I did find something I needed to ask. Predictably he was busy. I was able to answer my question myself. He was, as it turns out, designing and implementing something actually interesting. Which he never had talked about with me. Out of the loop. Fuck.

Man, I'm fuming. I realize he's probably just ignorant. But I feel treated like his typing slave. Like he's not interested in my brain, only in my hands. I am *so* fucking close to assigning him the tasks back, and telling him since I wasn't involved in the thinking part, he can have his shitty typing part for himself, too. Fuck, what am I gonna do? I'd prefer some "malicious compliance" move but not coming up with ideas right now.

So this post by @Cyanide had me wondering, what does it take to be a senior developer, and what makes one more senior than the other?

You see, I started at my current company about three or four years ago. It was my first job, and I got it before even having started any real programming education. I'd say that at this point I was beyond doubt a junior. The thing is that the team I joined consisted of me and my colleague, who was only working 50%. Together we built a brand new system which today is the basis on which the company stands on.

Today I'm responsible for a bunch of consultants, handle contact during partnerships with other companies, and lead a lot of development work. I'm basically doing the exact same things as my colleague, and also security and server management. So except for the fact that he's significantly older than me the only things that I can think of that differentiates the seniority in the team are experience and code quality.

In terms of experience a longer life obviously means more opportunities to gather experiences. The thing is that my colleague seems to be very experienced in 10 year old technologies, but the current stuff is not his strong side. That leaves code quality, and if you've ever read my previous rants I think you know what I'm thinking...

So what in the world makes a person senior? If we hired a new colleague now I'm not sure it'd be instantly clear who should guide and teach them.

I hate people who think they are always right.

A coworker who seemed to be a friend turns out to be an emotionally needy narcissist who seems to think that he is a perfect human being and is the best example of how to live.

Long story short is that we did some bonding via alcohol and smoking cigarettes. Especially when I was in a bad period in my life where I had little self confidence, was in a bad financial situation and overshared many details abound my personal life.

And yeah we also work as software devs in the same team but I started avoiding working with him directly, because due to his seniority he overcomplicates things a lot to the point where stuff gets postponed for months. Meanwhile I am a simple guy, I do my tasks and if they are not up to the standard I just work on the feedback until Im up to the standard, thats it. Its just a job for me, for him its a way of life and he considers himself to be basically an artist.

Hes always trying to prove me something, showing that the "long way" is the best way and so on. In reality I dont give a fuck about him. I live my own life and I have my own priorities. I work fulltime in one job, also I work part time as a freelancer and in total I make about 20 percent more than he does. Previously before this job I owned my own company where for 2 years I ran my own projects which generated a decent revenue. I know what is hard work and how to sacrifice myself in order to achieve results. I am more pragmatic and I have some limitations of what I can be good at (since I have a shitty working memory due to my ADHD). So I have systems in place and bottom line is that I earn a decent living and my skillset is different. Yeah I agree that in some ways he is better than me, but dude has such a massive inflated ego that now he thinks that he unlocked some sort of universal wisdom and now hes suddenly experienced in every field of life and his opinion is the right one.

This guy takes a massive pride in how good software engineer he is and in every topic or interaction he tries to one up me. Which most of the time is just his preference or in order to gain a 0.0001 percent performance increase. Dude is basically a big walking ego and since "we are close now" his ego started bleeding into personal relationship.

In my personal life, Im in a stable relationship, thinking of proposing soon and getting married. I already co-own an apartment with my current girlfriend. Everything is serious and planned, Im soon to be 30 years old. He is the same age but he still thinks hes young hot shit and all he cares about is getting shitfaced a couple times a week after work and he doesnt really have any other hobbies. He has a girlfriend but I dont see any future in there TBH.

So what I did now is I started putting some distance between us. No more drinking every week with him, maybe maximum once in 2 or 3 weeks. I started working from home more. Also I stopped sharing my personal life with him. Each time when he thinks he is right I just go along with it and dont even pay attention to his emotional manipulations. I just hope one day he fucks off completely and I wont give in to his gaslighting. Maybe in a few months I will be leaving this job, so I will never have to deal with him again.

Lesson learned: dont be vulnerable to coworkers who you bond together only via alcohol.

I came into work with a skip in my step and was actually feeling positive for once.

That all came crashing down when a guy I despise who has half the experience I do and even less seniority than I do got promoted above me before I did.

This guy is a talentless, boring, irritating hack who rides the success of others and does everything to glorify his ego. He shits on everything he doesn’t like and no one likes him. I guess that’s why he’s on the fast track to management.

I asked why I haven’t been promoted yet, despite being the technical guru on the team and having professional accomplishments that make his look silly in comparison. Their reason “well he comes in earlier than you”. Well guess what fuckers. I still get my work done and I stay later. Seriously, fuck this place.

This guy also worked with me on a past project. I use “worked” loosely because he did nothing but sit there and criticize everything while doing minimal code. When the company we were doing the work for folded he demanded to be paid his full portion, and I got jack shit despite having done all of the fucking work.

This guy...seriously...why do people who do fucking nothing get the glory? Why do I even fucking try?

Fuck me I'm pissed. This sprint, my tech lead has been away and a senior dev has been covering for him. We plan a load of work and distribute stories and we churn threw it quite well. However, my senior dev says let's not deploy until all the works done. I was like, how is it going to be tested? He was like well it will be fine because it's all one test. Bs. We now have 2 days left, tester is getting stressed because they don't know what to test or what's been finished. Scrum master is asking why all of it should be tested at the same time and I'm here like this is fucking dumb. Also the tester decided to start testing with the most complex piece of work, rather than prioritising.

Starting to wonder if I'm just the outsider or whether no one understands that granularity is better.

How do you define a seniority in a corporate is beyond me.
This guy is supposed to be Tier3, literally "advanced technical support". Taking care of network boxes, which are more or less linux servers. The most knowledgable person on the topic, when Tier1 screws something and it's not BAU/Tier2 can't fix it.
In the past hour he:
- attempted to 'cd' to a file and wondered why he got an error
- has no idea how to spell 'md5sum'
- syntax for 'cp' command had to be spelled out to him letter by letter
- has only vague idea how SSH key setup works (can do it only if sombody prepares him the commands)
- was confused how to 'grep' a string from a logfile

This is not something new and fancy he had no time to learn yet. These things are the same past 20-30 years. I used to feel sorry for US guys getting fired due to their work being outsourced to us but that is no longer the case. Our average IT college drop-out could handle maintenance better than some of these people.

Seniority sucks sometimes.

Today I took the time to figure out the API for a shipping website.

I was super proud of this and figured that this could be useful for our application but the guy who has been there for 5+ years was like "no we have used an API for a previous client and caused the application to slow down by 1.2 seconds."

Of course in my mind I'm like, "but what was the API that you used? When I use it, it's running and returning in milliseconds. Surely you're not doing it right."

Of course because of his seniority I'm not going to say that.

It just sucks a lot because I spent a lot of time reverse engineering the API. It would have been nice to have been noticed for that work.

[Blue pill]
stay in my current workplace [approaching the 10yrs mark], with an agreed salary and seniority raise, with a high probability of losing my current project [which is really fun!] in Feb next year and having to switch to another one, but keep all the benefits

[Red pill]
switch full-time to contracting with a potential to reap big bucks [x2-x4] and be free to juggle as many clients as I like, dictate my terms, become a shareholder, but lose all that warm and cozy certainty guaranteed by my current employer

Most unprofessional experience at work?

Check out my previous rants. With so many, it would be difficult to pick just one.

Not sure if I've told this one before. 'Caleb' was part of a team responsible for migrating financial data from a legacy (DOS-based) system to our new system.
Because of our elevated security (and the data being plain text) Caleb had access to the entire company's payroll (including VP salary, bonuses, etc).
Solidifying my belief that that salaries should be private between the employee and the employer, Caleb discovered he was making considerably less than his peers (even a few devs that he had seniority over), and the green monster 'Jealosly' took over his professionalism. Caleb decided to tell everyone making the same and less than him, the salaries of the other (higher paid) devs, managers and VPs.
Nobody understood at the time, but these folks started to behave erratically , like showing up late, making comments like "Why should I document that? Make 'money bags' over there do it", etc and so on.

Soon at review time, Caleb decided to use his newly discovered ammunition to 'barter' for a higher salary by telling the manager if he didn't make $$$, he would send an email to the entire company containing everyone's salary.

The manager fired Caleb on the spot and escorted him out the building (Caleb never had chance to follow thru with that threat)

When word got out about Caleb's firing (and everybody knew why), those other employees started showing up on time and stopped complaining about doing their job.

Yesterday at my career progression chat my manager told me that to showcase more seniority I would need to "stop moving the needle by myself and become a multiplier".

So in order to progress I need to change from being a sewing machine to a mathematical operator??!!?!?
Thanks, that's very fucking helpful.

Pretty much when i stopped listening to the same old "my printer is jammed" requests in helpdesk and saw a friend dev earn twice as much as i dis at that time without dealing with (that many) idiotic situations.

A few years later - i'm a happy little coder. And i have my own minions to deal with support. Seniority rules :D

So in my org, as far as I can see, senior engineers and normal engineers do about the same amount of work, and the senior engineer is useful at PBRs for bringing up tech points that other engineers might not know about due to lack of experience. Is this a common thing across the whole software business? In terms of responsibilities, I’m seeing pretty much the same amount, don’t wanna sound arrogant here but we never task work etc based on seniority which I like but just want to know if it’s common

The most senior person on the devops team just turned in his two week notice. I started a month after him and am now the most senior. Our old manager was fired back in the spring.

I really need a new job.

Was offered a Mid QA position in my home country and just for shit and giggles applied to a QA Lead for another one (remote) and they offered me the QA Lead one as well. And now I don’t really know how the fuck you are supposed to measure seniority for this kind of jobs.

Sooo I've just learned that one of the new guys I'm helping train (And is a level below my role in seniority) is being paid approx. 12.9% higher than what I'm being paid; I got promoted a few months back (Been with the 'biz for over 4 years) and he was hired around the same time (A few months back). I learned this as we've both become good friends, and were on the topic personally and informally. Our salaries are not publically known outside of personal disclosure. My manager / HR is not aware that I know this. How do I bridge this with my employer?

You can actually measure the seniority of a developer by the number of monitors they use.

I feel like a good rule of thumb of how good a developer is (or how senior are they) is whether they know when a question should go in stackover and when it should go in softwareengineerin.stackexchange.

Do anybody agree?

I hate it when an opinion is valued by someone seniority.
Sure, you might not like react, fine, but if your only argument for that is it being built by Facebook, you're just an ass.
Sure, you might not like node, fine, but if your only argument for that is your prejudice towards javascript , you're just an ass.

Normally this guy is pretty nice, but fuck you for talking about shit you don't understand

QA Tester: titles in table items look like links and are clickable, they should be plain text.

Senior Dev: style={{ color: '#000' }}

seniority perks: explain something technical, make it sound like its very easy to do and actually make devs think their dumb in the process.

moron.

I hate the company (agency) I moved to...I've negotiated good pay and the project for cutting edge medical product which will change the world (cancer diagnose and it actually works).

Now the dark side I've got shit tier laptop which I don't want, overtime is payed 30% less, all the people in the agency from development team don't know shit and are mostly I would call them juniors (of course who would with enough seniority work with shit hardware and almost not payed overtime), only tap water and since this is the old part of town you instantly get sick, they treat people like shit.

The product dark side. We are actually working on crm for doctors to input patient data, we cannot have any real data because we are the agency people, product is being led by the guy who has 0 production experience (they choose the database basically with coin toss and emulated the mongodb in postgress with jsnob, they don't know how to build their own auth system hence my previous rant about b2c, they are using cognito and now moving to auth0 which probably won't fit their need because a lot of stuff needs to be custom), they are choosing every hipe tech out there without any prior experience. It's chaos...

I'm trying to guide them but i think this will be a huge expensive failure and that i need to leave asap.

There I feel better now, moral of the story, choose startups wisely.

Horror story and rant time I guess...

I haven't seen the main developer of this MVC project that I've been working on but I can totally assure that his seniority isn't in frontend development 😠 and I doubt the backend too... Fucking DataTables converted to IDictionaries<string,object>

Guess who need to build on top of the pile of shit!

Anyway, I wasn't really careful about what kind of template I was given to work on a new SPA page, so I'm doing the job given the time, but it's fucking gory:
- matrioska style layers (n.3) without documentation
- partials everywhere
- too much inline styling
- too many <style> sections (n per layer or partial)
- too many <script> sections (n per layer or partial)
- poor CSS styling or no styling at all! (classes without any style nor js association)😠

He's just been lucky that the browser is capable of handling his shit

Now that at the end of this year I'll leave this project (solo fullstack) and need to provide documentation for the next poor souls I was thinking to leave behind something at par of my skills and capabilities but analysing the current mess ticks my brain in a bad way, fuck you Marco!
Fuck you
and your seniority
and the Italian way of perceiving seniority that gives you a higher living in the wrong side of the field 🤬🤬🤬

So i want to know how finances work for tech companies. There are a lot of big numbers that come up when we talk about a company's finances, but i don't understand why the tech people are so down in the ladder, or why those no.s are not associated with the tech teams
Like here's a statement :

"company x is valuable at $42billion , their annual turnover is $5billion. With a profit of $2billion. The ceo has a worth of $1.4billion and company's share are selling at $1500 per share. Person a,b,c of the company hold's 2,3,4% in stocks and the investor sequoia capital is thinking of providing an investment of $25million"

This is a hypothetical company, but if this company is also providing its members of tech team @$20-200k per annum (depending upon seniority), then is it relatively too less? I mean the company is playing with numbers in millions, people are being attributed with billions and yet a developer has to satisfy in those numbers.

Is it because we are being paid by the no. Of hours/time? Because i want to know what other ways are there in which those managers and ceos and investors are being paid? I have heard far too many stories about devs leaving their jobs and starting businesses, and I don't think its only because their boss was a dick

I’ve been interviewing at a few companies lately. I’m a dev with ~6 years of experience with a specific language. Most of the experience comes from working in companies that developed their own software, not talking about cms stuff. Analytical, data tracking systems. Now working at a fintech. I’ve got an offer to work as a senior developer in a smaller tech team, with more salary. I’ve approached the current company about the offer and they told me that they don’t think I’m a senior dev and rather a strong mid level dev. The Hr also told me to think about if I’m really a senior and if the other companies expectations would be met. They would increase my salary, but not quite match it. It’s not too far off though. Their reasoning for this was that you need a lot of experience with their product (which does not correlate with seniorness of a developer, only the worth of specific employees for a company IMHO) and system architecture design. The problem is that we don’t see any tasks that could implement any system design for as log as I’ve worked here, so I don’t see how I could work into a senior role at this company. Of course imposter syndrome kicked in and I’m triple guessing myself if I should join the other company as a senior now. How should I aproach this? The current company is stressful to work at because of big workload, a lot of my coworkers think the same thing about the workload.

How do you know when you are senior level dev? What’s the threshold?

Hi devRant. Wanna rant with some shit about my company. First some good parts. I work in company with 600+ employees. It's one of the best companies in my region. They provide you with any kind of sweets(cookies, coffee, tea, etc), any hardware you need for your work (additional monitor, more ram, SSDs, processor, graphics card, whatever), just about everything you need to make your work faster/comfortable. Then, we have regular reviews (every 6 months), which rise salary from $0.75 to $1.5 per hour. (I live in poor country, where $15 per hour makes your more solvent then 70% of people, so having 100-200 bucks increase every half year is quite good rise).
The resulting increase of review depends on how team leader and project manager are satisfied with my work. And here starts the interesting (e.g. the shit comes in).
1) Seniority level in our company applies depending on the salary you have. That't right. It does not depend on your skill. Except the case when you're applying to vacancy. So if you tell that you're senior dev and prove it during interview, you'll have senior's salary. This is fine if you're just want money. But not if you love programming (as me) because of reasons bellow.
2) You don't need to have lots of programming experience to be a team leader. You can even be a junior team leader (but thanks god, on research projects only). You start from leading research projects and than move to billable if the director of research department is satisfied with your leading skills.
As a consequence our seniors are dumb AF. This pieces me off the most. Not all of them. A would say half of them are real pro guys, but the rest suck at programming (as for a senior). They are around junior/middle level.
I can understand if guy has $15 rate but still remains junior dev. That's fine. But hell no, he is treated as a middle, because his rate is $10+ now! And his mind has priority over middles and juniors. Not that junior have lof of good tougths but sometimes they do.
I'm lucky to work yet on small project so I'm the only dev, and so to speak TL for myself. But my colleague has this kind of senior team leader who is dumb AF. They work on ASP.NET Core project, the senior does not even know how to properly write generic constraints in C#. Seriously.
Just look at this shit. Instead of

MyClass<T> where T: class {}

he does this:

abstract class EnsureClass {}
MyClass<T> where T: EnsureClass {}

He writes empty abstract class, forces other classes to inherit it (thus, wasting the ability to inherit some useful class) just to ensure that generic T is a class. What thA FUCK is wrong with you dude?! You're a senior dev and you don't even know the language you're codding in.
And this shit is all over the company. Every monkey that had enough skill just to not be fired and enough patience to work 4-5 years becomes a senior! No-fucking-body cares and reviews your skill increase. The whole review is about department director asking TL and PM question like "how is this guy doing? is he OK or we should fire him?" That's the whole review. If TL does not like you, he can leave bad review and the company will set you on trial. If you confront TL during this period, pack your suitcase. Two cases of such shit I know personally. A good skilled guy could not just find common language with his TL and got fired. And the cherry on top of the case is that thay don't care about the fired dev's mind. They will only listen to reviewer. This is just absurd and just boils me down.
That's all i wanted to say. Thanks for your attention.

If you've ever had to do hiring (technical side) of new software developer\s, the seniority in terms of working years is the most valuable criteria for you or the hiring department, or there's else?

On my side I'm a software developer from around 1 year and here (in Italy) your price is, from what I've seen, based on the seniority in terms of time, rarely actual skills\adaptability.

I'm good as a full stack developer and I'm proficient in adapting\learning to-new\new skills about new languages and Frameworks.

Soon I'm leaving my underpaying job with good output from my work\projects, but I'm faced with this seniority nonsense that makes most of the recruiters silent because the new price is similar of someone with high seniority, and I'm kinda tired of this, so I'm here to hear your thoughts about this.

you know one should tread very carefully when getting a business dealing out of friendship.

if their is a boss-employee dynamics in the business, as in you are the boss and they are being paid to work for you or vice versa, then during work , be prepared to take criticism constructively. as a friend, the relation is different, we say each other anything and it is laughed off, but during work, there is a matter of respect, seniority and professionalism.

another kind of dynamics are the freelance/favour relation where friend is giving you free/paid service/advice or vice versa. this is even more shittier situation and is almost always bound to fuck up.
- the guy receiving service will try to negotiate a better deal because friend factor ('you will take so much money from your homie?')
- the guy providing service will try to offer a bad deal because friend factor ('i know he trust me. let me offer him a bad quote as he don't know anything of this domain')
- the guy providing service may not consider the service/advice as priority because friends factor ('he is a homie. he can wait')
- the guy receiving service may not be satisfied with the product/offerring/guidance because friends factor ('you could have added this x feature too bro, i paid you')

overall friend factor sucks. somehow the boss-employee factor worked for me as i was careful after 1 bad attempt

!rant
Hey guys, can you help me with this?

How determine developer seniority ??