Join devRant
Do all the things like
++ or -- rants, post your own rants, comment on others' rants and build your customized dev avatar
Sign Up
Pipeless API
From the creators of devRant, Pipeless lets you power real-time personalized recommendations and activity feeds using a simple API
Learn More
Search - "constructive criticism"
-
My mentor/guider at my last internship.
He was great at guiding, only 1-2 years older than me, brought criticism in a constructive way (only had a very tiny thing once in half a year though) and although they were forced to use windows in a few production environments, when it came to handling very sensitive data and they asked me for an opinion before him and I answered that closed source software wasn't a good idea and they'd all go against me, this guy quit his nice-guy mode and went straight to dead-serious backing me up.
I remember a specific occurrence:
Programmers in room (under him technically): so linuxxx, why not just use windows servers for this data storage?
Me: because it's closed source, you know why I'd say that that's bad for handling sensitive data
Programmers: oh come on not that again...
Me: no but really look at it from my si.....
Programmers: no stop it. You're only an intern, don't act like you know a lot about thi....
Mentor: no you shut the fuck up. We. Are. Not. Using. Proprietary. Bullshit. For. Storing. Sensitive. Data.
Linuxxx seems to know a lot more about security and privacy than you guys so you fucking listen to what he has to say.
Windows is out of the fucking question here, am I clear?
Yeah that felt awesome.
Also that time when a mysql db in prod went bad and they didn't really know what to do. Didn't have much experience but knew how to run a repair.
He called me in and asked me to have a look.
Me: *fixed it in a few minutes* so how many visitors does this thing get, few hundred a day?
Him: few million.
Me: 😵 I'm only an intern! Why did you let me access this?!
Him: because you're the one with the most Linux knowledge here and I trust you to fix it or give a shout when you simply can't.
Lastly he asked me to help out with iptables rules. I wasn't of much help but it was fun to sit there debugging iptables shit with two seniors 😊
He always gave good feedback, knew my qualities and put them to good use and kept my motivation high.
Awesome guy!4 -
Senior: Why did you refactor those ten files?
Junior: There was a method copy-pasted in every one of them, so I moved it to a utils class.
Senior: Don't you know we will have to test all of those changed classes again? Please, rollback!
Junior: ok.
... two days later ...
Senior: Why did you just copy-paste that method? Don't you know it's bad practice?10 -
!rant
I must be dreaming .... Honestly! I am with a client that knows what he wants and has no problem to express it in clear words. They understand my tech talk and talk back in tech as well. We are on the same page regarding best practises. They envy my work and have really good ideas and express constructive criticism. What is going on here? I must be in a parallel universe or something?
Okay, one downside... Coffee is not free but a cup is 20ct, which is quite alright imho anyway. Oh, the even bigger downside... Things have been so constructive that my time there is almost over since shit got actually done in the most efficient way ever!8 -
dear anyone looking to teach kids programming (especially organizations):
- please be realistic. teach things your students can use. how to debug, how to solve realistic, real-world problems. not how to make a turtle draw a circle, that's not programming.
- please don't have blocks. just don't. they hurt.
- focus on your content instead of putting up posters on the wall with celebrities talking about the importance of programming
- don't call it 'code,' call it 'program.' do you know how different muggles think they are?
- please teach in a logical order. too many times have I seen commands --> functions --> variables/variable types --> then back to functions and return types.
- don't set an appropriate "age" to do it. please. its enough for people to learn to program, but to be told they're too "old" for a course? I can't tell you how many forgetful seniors and special needs students have been insulted. and don't even get me started on being too young. knowledge is knowledge, skill is skill, ability is ability.
- teach concepts with programming. don't separate them. they work better when they're taught together.
- understanding is more important than style. for beginners, fuck style. all of your program could be all on one line for fucks sake. I've had teachers chose style > functionality, because, fuck working programs, right?
- let your content speak for itself. this is not the place for celebrity endorsements.
- give resources for after a lesson is complete. when a beginner is finished, recommend more resources. you're never done learning.
most of these were things code.org did wrong. fuck them. I was in a constructive criticism mood today…5 -
Fuck brand builders, or, how I learned to start giving a shit and love devrant.
Brand builders are people who generally have very little experience and are attempting to obfuscate their dearth of ability behind a wall of non-academic content generation. Subscribe, like, build a following and everyone will happily overlook the fact that your primary contribution to society is spreading facile content that further obfuscates the need for fundamentals. Their carefully crafted presence is designed promote themselves and their success while chipping away at the apparent value of professional ability. At one point, I thought medium would be the bottom of the barrel; a glorified blog that provides people with scant knowledge, little experience and routinely low integrity a platform to build an echo chamber of replayed or copied content, techno-mysticism and best-practice-superstition they mistake for a brand in an environment where there's little chance of peer review. I thought it couldn't get any worse.
Then I found dev.to
Dev.to is what happens when all the absence of ability and skills insecurity on the internet gets together to form a censorship mob to ensure that no criticism, reality or peer review will ever filter into the ramblings of people intent on forever remaining at the peak of the dunning-kreuger curve. It's the long tail of YMCA trophy culture.
Take for example this article:
https://dev.to/davidepacilio/...
It's a shit post listicle by someone claiming to be "senior," who confidently states that "you are only as good as the tools you use." Meanwhile all the great minds of history are giving him the side-eye because they understand tools are just a magnifier of ability. If you're an amazing carpenter, power tools will help you produce at an exponential rate. If you're a shitty carpenter, your work will still be shit, there will just be more of it. The actual phrase that's being butchered here is "you're only as good as the tools you create." There's no moral superiority to be had in being dependent on a tool, that's just a crutch. A true expert or professional is someone who can create tools to aid in their craft. Being a professional is having a thorough enough understanding of the thing you are doing so as to be able to craft force multipliers that make your work easier, not just someone who uses them.
Ok, so what?
I'm sure he's a plenty fine human to grab drinks with, no ill will to him as a human. That said, were you to comment something to that effect on dev.to, you'd be reported by all the hangers-on pretty much immediately, regardless of how much complimentary padding and passive, welcoming language you wrap your message in. The problem with a bunch of weak people ganging up on the voice of reason and deciding they don't want things like constructive criticism, peer review, academic process or the scientific method is, after you remove all of that, you're just left with a formless sea of ideas and thoughts with no categorization, no order. You find a lot of opinions and nothing to challenge them and thereby are left with no mechanism for strong ideas to rise to the top. In that system, the "correct" ideas are by default those posited by the strongest personality.
We all need some degree of positive reinforcement. We also need to be smacked upside the head when we're totally off in the weeds. It's all about balance. The forums of ancient Greece weren't filled with people fervently agreeing with one another and shouting down new ideas en masse. We need discourse, not demagoguery.
Dev.to, medium, etc are all the fast fashion of the tech industry. Personally, I'd prefer something designed to last a little longer.30 -
I have a junior who really drives me up a wall. He's been a junior for a couple of years now (since he started as an intern here).
He always looks for the quickest, cheapest, easiest solution he can possibly think of to all his tickets. Most of it pretty much just involves copy/pasting code that has similar functionality from elsewhere in the application, tweaking some variable names and calling it a day. And I mean, I'm not knocking copy/paste solutions at all, because that's a perfectly valid way of learning certain things, provided that one actually analyzes the code they are cloning, and actually modifies it in a way that solves the problem, and can potentially extend the ability to reuse the original code. This is rarely the case with this guy.
I've tried to gently encourage this person to take their time with things, and really put some thought into design with his solutions instead of rushing to finish; because ultimately all the time he spends on reworks could have been spent on doing it right the first time. Problem is, this guy is very stubborn, and gets very defensive when any sort of insinuation is made that he needs to improve on something. My advice to actually spend time analyzing how an interface was used, or how an extension method can be further extended before trying to brute-force your way through the problem seems to fall on deaf ears.
I always like to include my juniors on my pull requests; even though I pretty much have all final say in what gets merged, I like to encourage not only all devs be given thoughtful, constructive criticism, regardless of "rank" but also give them the opportunity to see how others write code and learn by asking questions, and analyzing why I approached the problem the way I did. It seems like this dev consistently uses this opportunity to get in as many public digs as he can on my work by going for the low-hanging fruit: "whitespace", "add comments, this code isn't self-documenting", and "an if/else here is more readable and consistent with this file than a ternary statement". Like dude, c'mon. Can you at least analyze the logic and see if it's sound? or perhaps offer a better way of doing something, or ask if the way I did something really makes sense?
Mid-Year reviews are due this week; I'm really struggling to find any way to document any sort of progress he's made. Once in a great while, he does surprise me and prove that he's capable of figuring out how something works and manage to use the mechanisms properly to solve a problem. At the very least he's productive (in terms of always working on assigned work). And because of this, he's likely safe from losing his job because the company considers him cheap labor. He is very underpaid, but also very under-qualified.
He's my most problematic junior; worst part is, he only has a job because of me: I wanted to give the benefit of the doubt when my boss asked me if we should extend an offer, as I thought it was only fair to give the opportunity to grow and prove himself like I was given. But I'm also starting to toe the line of being a good mentor by giving opportunities to learn, and falling behind on work because I could have just done it myself in a fraction of the time.
I hate managing people. I miss the days of code + spotify for 10 hours a day then going home.11 -
Kind of disappointing that devrant rewards and attracts bot'esque accounts for exclusively re-posting facebook memes - with stickers.
Those accounts are even as bold to constantly spam everywhere "HOW LONG DID IT TAKE FOR YOU TO GET THEM?" as if they are entitled to next day delivery, feels wasted and especially insulting to people that actually use and flourish the platform.
Not really great input nor constructive criticism, more a vent, because I know that it's the "maybe some of the shit will stick" idea - maybe some of those shit posters will turn to actual content creators on here or them being free advertisement to maybe less useless beings.20 -
Woo, rant time.
I've recently changed jobs to a new company due to a number of factors at my old job. I didn't tell my old boss (let's call him X) my expected salary, nor did I tell him which company I was going to.
However, I've been informed by someone that still works there that X has been discussing my new wage in front of everyone; he was telling everyone that I'm going to lose money by moving job and that I made a stupid decision.
I didn't leave due to money, it was due to X's inability to take constructive criticism, the constant subtle sexism of the office and just a generally bad overall feeling about the job/office going forward. Yes, I will admit that money did have a minor part in my decision to leave but I didn't verbalise that to anyone in the office, and I made X aware that my departure wasn't to do with money. I left on good terms.
I feel as though it was wrong of X to talk about his opinions on my new job in front of my ex-colleagues and friends. I don't know, maybe this is the norm and I've just been living in a cave before this, or maybe my last boss was just a bit of a douchenugget. Has anyone else had this experience?
I've got to meet up with everyone from my last place tomorrow to properly say goodbye and things.. but I'm not sure how to approach my old boss when leaving drinks are held now. Should I say anything? Should I just act as though I know nothing about it?
What would you guys do in this situation???19 -
Constructive criticism at its finest coming all the way from:
Fuck You
Fuck You - Fuck You
Fuck You, AL 10101
Note: Joe is my coworker, not the customer that wrote in. The form sends from his address.6 -
Our current programming teacher actually being able to teach us good practices and give us constructive criticism on our code.1
-
The worst thing I've seen another developer do is not give constructive criticism where needed, as well was fail to accept constructive criticism when offered.1
-
When the poet in me fuses with the geek in me:
Will you be the css to my html?
When I encountered you,
My system threw a fatal error
My RAM was overloaded,
And my CPU went haywire
Will you be the css to my html?
I would show you my source code,
And let you merge your branch into mine
I will help you fix your memory leaks
And I will try filling all your nullpointers
Will you be the css to my html?
Your frontend would perfectly plug into my backend
I can compile all your heavy code,
Just in time
Baby just promise me,
You'll provide the JSON
To my API calls
Will you be the css to my html?
This is my first draft... Constructive criticism is welcome!4 -
"I don't like it. Fix it."
No more explanation available. Plenty of constructive criticism to work on there then... -
This will definetly be an unpopular rant but god damn it I hate to work with untreated depressed people. It's fucking nearly impossible to convince them to try out something new. They are always pessimistic or think that they know everything. They don't care about new things happening around them. Every time in work when we encounter some obstacle it looks like the world has ended for them and every god damn time I need to give pep talks to them like we are in some war and I feel like I need to inspire soldiers to fight even though they are 100% convinced that they will die.
Im done with being a therapist for them. I don't have unlimited amounts of tolerance and energy, I am a human also. I can't keep sugarcoating what I see and I can't continue walking like on eggshels just because somebody is too weak to even take a constructive criticism without becoming passive agressive for days or weeks. I realized that their negative pessimism has started to rub off on me and I think it's time to put an end to this.
Please if you have depression get some help, don't expect that new workplace or employer will motivate you enough to turn your life around. Don't expect that putting on a mask will actually hide who you are and that your condition will not impact others around you in work. Just stop pretending and get some actual help. Start from yourself.8 -
Generally devs who are too arrogant to accept help or constructive criticism. There’s this data visualisation library that missed a specific feature that psychologists use quite frequently, so I added it myself and opened a PR. The maintainer closed it because people should use whatever he’d already implemented. It’s like not giving someone the option to listen to disco because rock music is better. Yeah, cool story bro. Now all my visualisation projects depend on my fork instead. Same with the now abandoned Material Design Library devs. They didn’t have a drop down with free input, so I opened a PR with my solution. Closed as it was out of scope, simply because Google didn’t specifically include that in the Material specs, only an input and a drop down separately which my solution matched. I also opened a PR for an obviously missing feature (being able to validate forms via JS), closed as this behaviour wasn’t in the Material specs either. No wonder MDL died before it was ever finished.4
-
fucking flutter.
i'm trying to make a simple app. it would be an easier to do both natively.
for fucks sake flutter, add some functionality. flutter recently got out of beta but it's not fucking done. no native webviews, no native push notifications. fuck that.
however, i do have to give credit where credit is due. coming into flutter i expected a different feel of the app on iphone and android. it was exactly the same, and it was smooth too. in that respect, i love flutter.
also guys, i have an app (not finished yet) i built with flutter and i would like some constructive criticism for changing the ui. only android right now though, i can't afford ios.
dictive.app/download6 -
Can we all please try to keep emotion out of coding? It never ever helps to get upset at a code review.
Please please please accept constructive criticism, and dish it back to me! You can hate my code just don't hate me. :/2 -
So there is this social institute I invested three years in.
Left them a record budget to play with. After being chair person for two years before and even administrating the whole 1900 of em.
Turns out they're FRICKIN' MORONS!
Instead of welcoming constructive criticism
/* which is because they can not read one single line of simple text without a fidget spinner at hand. And the second line of text, they ask their meds being upgraded! */.
They start fucking people up by spreading lies publicly!
On the fakken Web!
In so called protocols
/* which they don't manage to spellcheck before publishing. As freaking "devs" they major in */.
Just because I told them, that another institution which is conjoined to them within the universities senate, DOES NOT STAND IN COMPETITION!
They don't get it.
Is it that difficult?
Downvote if it is.
And please help me with those worm infested no brainers marrying in circles.
Its incredible how much you can achieve in some years and still so many people stay ignorant enough to start spewing their verbal vomit all over the campus thus fist fucked professors reign in, because "muh truth! no development. just money, I like money. muh moving student, not like it! not like work!".
What the hell is going on in this society?!4 -
Dear reviewers, feedback givers, coworkers, clients and critics...
There is a subtle difference between constructive criticism and just spewing hate!
One offers advice & points in the direction of a better solution, while the other one makes me value you less, as a human being...
If your comment/review/feedback is:
“I don’t like it, I don’t know why, I just don’t” - please keep it to yourself because it makes us less likely to listen to you when you actually have something worthwhile to say...
Yours,
Any and all creative professionals,
including developers.1 -
Today Phoronix posted a short article about a (in my opinion cool) new feature I implemented in my file manager (Dolphin). Most of the feedback was positive/constructive criticism but some people attacked me personally because they don't like the feature/think "true" Linux users wouldn't use it.
I gave you something cool for free. Would you please stop bitching about it?
If you don't like it don't use it. You can even disable it if it threatens your ego as a Linux master user5 -
Hello everyone!! This is my first rant so I'm not sure what the protocol is.
I just wrote my first ever Medium Post on Dynamic Theming in Android.
Just wanted to share it with you all.
https://medium.com/@nihitb06.dev/...
Any constructive criticism is welcome. -
Just had my performance review conversation with my manager today and basically it's another "great work"
Which is what I get every year. So wondering does anyone actually get constructive criticism or things they should improve upon?4 -
I've never rejected a pull request, I just out in loads of comments with constructive criticism.
When shoukd you reject and when should you just sdd in comments?7 -
Mr developer are you giving me constructive criticism? or forcing your programming faith down my throat again? i really cant tell.
-
Good people of devRant, hear me! Today is a proud day, a day of happiness, peace, and prosperity!
Theatrical opening lines aside, I need your help. I have finally completed the setup for one of my long ongoing projects and need some input from experienced developers of any kind. I've recently started a blog focused around building a community for people who want to learn more about all engineering disciplines or want to see if they would like being an engineer. The majority of the content will be posts about various topics that relate to either specific disciplines or engineering as a whole, and cool projects you can do to work out what is fun to you.
HackTheWorld.io is the URL and I'd welcome any feedback you can give, from design to development. I used the hexo framework, which is a static html blog generator that I then upload to a web host via FTP. Let me know what you think and if you have any ideas form posts on the site, feel free to leave those as well. I've got a few I'm writing now that will hopefully help some people out there.1 -
Just finished my neural network library.
The library is written in C# and easy to use. This is my first publicly available library, so constructive criticism is need :)
https://github.com/BitPhinix/...2 -
When your coworker is a "yes...but". If your solution is either non-existent, or vague, and mine is actual code, PLZ STFU. Nobody wants your "constructive criticism".1
-
so what do think ? - i built an entire app with html pages.
With client side - angularjs and
server side - .net webapis working with sql db. The app has over 100 forms and works crazy fast in html form compared to the same form in an aspx. Should I leave it this way or do you guys see any problems with it. All forms are post and https enabled site. Open to constructive criticism and don't be a dick4 -
Can I pls receive some constructive criticism on my side project an app that shows APIs demos and their resp. source codes
https://play.google.com/store/apps/...3 -
I have no problem reading constructive criticism of systemd. It has its problems. However, sometimes those critics try to claim that init run levels, or rc scripts, with their arbitrary meaning and the Bourne shell's ad hoc syntax, are a perfectly acceptable solution to the problem that don't need replacing.
I've never seen an OS startup mechanism that tells me, while the system is up, "the change you just made will make it impossible to bring the OS up if you restart it". And that's a real problem.1 -
Best dev experience...a colleague who was my team lead when I joined a company as a "from-scratch" PHP developer, and gave me a ton of tips, assistance, encouragement and praise along the way. And for the bits that were not so good (on my part), he gave me constructive criticism delivered in a friendly and helpful way rather than chew me out.
And when the boss(es) of the company talked shit behind my back in meetings I was not invited to, about things they had no clue about (my performance as a developer)) he defended me and set the record straight.
Later he was demoted from team lead for office politics reasons. But was doing the same job as before, for less pay. Never complained.
His job consisted of, all at once, being the company IT/server/printer guy, first line customer support over phone and remote desktop, .NET and PHP developer, course holder to teach our customers how to use our product, and mentor to me.
Good guy. I'd give him a ++ if I could. -
I'll have to make some tough choices over the next 6 months. With my tech career beginning and my college education ramping up, time is of the essence, and the skills I develop now will be at the forefront of my future. So what does this have to do with Microsoft?
Well, the story begins in the Spring of 2016. Social Forums was about to turn a year old, Trump's campaign was ramping up, and I had just found my love for technology. With all my friends having phones, I had to get a phone and get working on development. The year before, Windows 10 was launched, and I was psyched. I found Microsoft's products to be underrated with potential. That day, I purchased a Lumia 640, upgraded it to Windows 10, and immediately began working. After another year-and-a-half gone by, I went from loving Microsoft, to defending Microsoft, to tolerating Microsoft. I could go on and on about the lousy structure, the privacy issues, the forced upgrades, the redundant developer platform, and other such issues that is leading me away from them. But if there is one thing they have proven over the years, is that the they are completely out of touch with its developers and its customers. They spent years ramping up their phones. They failed. They spend years ramping up their phones. They failed. They spend years ramping up their semi-annual OS updates. They failed. So why did they fail? It's not that they made the wrong prediction out of chance. They legitimately don't care about feedback. It's their way or the highway. This sounds vaguely familiar. They have been spending a decade ignoring feedback from the community because they want to become just like Apple. Right now, Apple LIVES off of brand loyalty and its stable, useful ecosystem. This cannot work for Microsoft as they don't have a lot of brand loyalty. But most of all, they don't have a working ecosystem. They have Windows Insiders, which provides them with hundreds of feedback messages per day. These include suggestions, bug reports, and constructive criticism. The feedback is public. You can have several pages of the same complaint, and they still won't do anything about it. They say they have a good relationship with their community, and that this Beta program helps Windows become better for all. But in the end, we are nothing more than a glorified unpaid labor force. They fired hundreds of professional debuggers just before the Insider Program took off. We are only here to provide bug reports for free. Now that their phones, AR headsets, browser, online services, and VR headsets are failing for all these reasons, I see little reason to develop for Windows anymore. I don't just mean their UWP and App Store platforms, I mean Windows as a whole. I'm definitely not a Mac guy either. I never see myself going to Mac either, as they are really no different in terms of how they treat their Developers and PC users. If things continue down this route, I will leave the platform all together. I've always wanted to be a Systems Programmer, so I don't really need an established paid platform to be successful. Even now, I'm not certain about leaving Windows altogether but as a developer, I need to find my place. Time is of the essence in my life, and I need to find out my place in the software world. Now I think it isn't on the Windows platform like I had dreamed it would be. But where do I go?10 -
People who generalize any technology as 'bad' or "worthless" (or worse, proclaim it is not secure, doesn't work correctly, or has specific problems it doesn't have) when the technology is widely and obviously appropriately used in practice just make themselves look bad. It's like getting mad at a hammer. It's just a tool. If you don't like it, don't use it. If you think it needs improvement, contribute to improving it. Non-constructive criticism is a waste of your time as a software developer.6
-
if I say that I just started uploading vids on yt ,
would ya'll be interested to give constructive criticism and maybe give video suggestions ?
P.S : I am thinking to keep track of my journey ( i am not sure how to draw my journey in a video )2