Join devRant
Do all the things like
++ or -- rants, post your own rants, comment on others' rants and build your customized dev avatar
Sign Up
Pipeless API
From the creators of devRant, Pipeless lets you power real-time personalized recommendations and activity feeds using a simple API
Learn More
Search - "peer review"
-
Peer review is a life saver!!! My colleague just saved me my job as i almost published this fucking block to production.18
-
I might have posted this before. But I am going to post it again. Because emojis.
Me: 😁 Software lead I have finished coding the thing.
SL: 😀 Cool, good job. That is going to really help out the analysts.
Software Manager: 😐 hey I noticed you have coded a new thing and pushed it to integration.
Me: 😁 Yes.
SM: 😐 Well how do you know when it's done?
Me: 😑 . . . When you run it and it does the thing?
SM: 😐 Did you write test steps?
Me: 😕 Yeah . . . they're in the issue ticket.
SM: 😐 Yeah but how do you know those are right?
Me: 😕 Because I wrote the thing and the test steps?
SM: 😐 did you put any steps in our acceptance test procedure?
Me: 😕 No.
SM: 😐 why not?
Me: 😧 Because the acceptance test procedure tests requirements. There is no requirement for this functionality.
SM: 😑 Then why did you do it?
Me: 🤔 Because it was an internal request from the analysis team. There is no customer impact here.
SM: 😑 I really think we should write a requirement.
SL: 🤔 But what requirement is he going to attach this to?
SM: 😑 We don't have to attach it to a requirement. We can just test it once and remove it.
Me: 😒 SM, you know we never remove anything from the acceptance test procedure.
SM: 🙂 We do sometimes.
SL: 🤔 When was that I have worked here for twenty years and we have never removed a test from that document.
SM: 😑
SL: 😒
SM: 😑
SL: 😒
Me: 🤐
SM: 😧 I really think there should be an acceptance test written.
SL: 😧 Looks like you're writing an acceptance test.
Me: 😒 Alright as long as y'all're payin'. Shit I was just tryin' to save y'all money.
*acceptance test written and sent to peer review*
Peer: 😐 The requirement tested section doesn't have any requirements spelled out.
Me: 😅 No.
Peer: 🤔 Why?
Me: 😓 Because there is no requirement associated with this test.
Peer: 🤔 Then why are we adding an acceptance test?
Me: 😡 WELL AIN'T THAT A GOOD GOD DAMN QUESTION!?6 -
Well, after lurking in the dark for years, I finally created an account just so I could downvote a certain security related post.
However, I am lacking the necessary ++.
So a "hello, world!" with a sprinkle of rant it is:
Be me:
Show WIP Feature, state that it will be probably done by tomorrow, excluding time for peer review
Be my PM:
"Can we release this today?"
This happend so often that "Can we release this yesterday?" became a common phrase among my coworkers and me if someone is ranting about something broken in their feature. Probably gonna try using it here as well :D17 -
*Doing a Peer Code Review of someone senior to me*
Me: This fix doesn't look like it will work, but maybe I don't understand. How does this fix the defect?
Senior Dev: *Blinks* It works on my machine
Me: But how does it work?
Senior Dev: It works when I run it on my machine...
Me: Do you know if this will fix the issue?
*Silence*
Never seen QA punt an issue back to development so fast.7 -
Annual performance peer review
Person who did review me wrote in the section “skills needed to improve”:
“He is introverted...”
Bloody hell!! What a big problem :) and how in earth you can “fix” it? And why everyone expected to be extraverted??10 -
*Programers can't spell*
In a previous job, I once spelled inquiries as enquiries. It was a service and it was used in many places throughout the app. Somehow, it made it through peer review and even my teammates started using the misspelled word.
I didn't realize my mistake till months later and by that time I thought it was too much work to fix it (or I was too lazy).
I'm pretty sure we even misspelled it for the on-screen texts.
Moral of the Story: know how to spell shit9 -
A repressed memory just popped into my head:
At my former job I tried to explain a problem I was having to the tech lead. Then, without fully understanding the problem, he decided to rewrite my code that I had been working on for weeks. His code, that took him 2 days to write, went straight to master without peer review.
He introduced about 10 regressions…
Queue the client meeting where the client says “These bugs came back, and we thought they were fixed already…” (They demo the bugs)
So obviously I say “I’ll let Techlead address that one.”
He just mumbles some stuff, and goes quiet for the rest of the meeting. Finally, when the meeting was wrapping up we hear “It’s Fixed!”
Everyone was like ???
“That bug from earlier, it’s fixed, it should work now….”
Would you believe this guy decided to code during the entire meeting, clearly missing important feedback and information that would help him understand the problem. Again, pushing to master without review….
Not to mention that we were talking about 10 regressions…5 -
Got really pissed off writing a stored procedure the other day because the reason behind it is absolute bullshit.
Gave sproc to QA for peer review before release.
QA: why are the variables called @FuckThisShit and @ThisIsBollocks?
Whoops, guess I was more angry than I thought 😂3 -
I suddenly realized all the technical debt shit I told my boss would happen years ago given the way things were done/heading then... Just occurred pretty much all at once last week in the form of critical production issues...
The teams like:
-we need real time server process monitoring
-structured logging for apps
-containerization so one app didn't affect others
Me thinking: yes.... I told you so like 3/4 years ago when I first joined the team and kept repeating so much I got tired of saying at every annual review...
This is exactly what happens when you let technical debt grow and have no free time for developers to look into and fix then while they were small and not critical production processes... Or properly document and peer review them... (Got a shit pile of projects that no one knows how to use or even exists because the devs left the team) and they'll have a lot more when I finally leave... Hopefully this year.... If I can find another role and not need another medical procedure... (Doubtful)3 -
Fuck brand builders, or, how I learned to start giving a shit and love devrant.
Brand builders are people who generally have very little experience and are attempting to obfuscate their dearth of ability behind a wall of non-academic content generation. Subscribe, like, build a following and everyone will happily overlook the fact that your primary contribution to society is spreading facile content that further obfuscates the need for fundamentals. Their carefully crafted presence is designed promote themselves and their success while chipping away at the apparent value of professional ability. At one point, I thought medium would be the bottom of the barrel; a glorified blog that provides people with scant knowledge, little experience and routinely low integrity a platform to build an echo chamber of replayed or copied content, techno-mysticism and best-practice-superstition they mistake for a brand in an environment where there's little chance of peer review. I thought it couldn't get any worse.
Then I found dev.to
Dev.to is what happens when all the absence of ability and skills insecurity on the internet gets together to form a censorship mob to ensure that no criticism, reality or peer review will ever filter into the ramblings of people intent on forever remaining at the peak of the dunning-kreuger curve. It's the long tail of YMCA trophy culture.
Take for example this article:
https://dev.to/davidepacilio/...
It's a shit post listicle by someone claiming to be "senior," who confidently states that "you are only as good as the tools you use." Meanwhile all the great minds of history are giving him the side-eye because they understand tools are just a magnifier of ability. If you're an amazing carpenter, power tools will help you produce at an exponential rate. If you're a shitty carpenter, your work will still be shit, there will just be more of it. The actual phrase that's being butchered here is "you're only as good as the tools you create." There's no moral superiority to be had in being dependent on a tool, that's just a crutch. A true expert or professional is someone who can create tools to aid in their craft. Being a professional is having a thorough enough understanding of the thing you are doing so as to be able to craft force multipliers that make your work easier, not just someone who uses them.
Ok, so what?
I'm sure he's a plenty fine human to grab drinks with, no ill will to him as a human. That said, were you to comment something to that effect on dev.to, you'd be reported by all the hangers-on pretty much immediately, regardless of how much complimentary padding and passive, welcoming language you wrap your message in. The problem with a bunch of weak people ganging up on the voice of reason and deciding they don't want things like constructive criticism, peer review, academic process or the scientific method is, after you remove all of that, you're just left with a formless sea of ideas and thoughts with no categorization, no order. You find a lot of opinions and nothing to challenge them and thereby are left with no mechanism for strong ideas to rise to the top. In that system, the "correct" ideas are by default those posited by the strongest personality.
We all need some degree of positive reinforcement. We also need to be smacked upside the head when we're totally off in the weeds. It's all about balance. The forums of ancient Greece weren't filled with people fervently agreeing with one another and shouting down new ideas en masse. We need discourse, not demagoguery.
Dev.to, medium, etc are all the fast fashion of the tech industry. Personally, I'd prefer something designed to last a little longer.30 -
Today’s achievement: my phone didn’t autocorrect ‘fucking’ to ‘ducking’.
Clearly it’s as pissed off as I am about receiving shitty emails from the other team manager in my dept giving me and my team work to do and throwing us under the bus when he does jack shit all day except read BBC news and go on Facebook. On the odd occasion he does actually do work, it’s not good work, it’s riddled with bugs because he’s ‘too senior to need a code peer review’. Such a fucktard...
Oh, and the work he’s asked us to do technically sits in his team so I’ll be firing that straight back at him 😁
I’m all for being a team player and helping each other but I’m going to protect my team over helping someone. The gloves are about to come off....3 -
So here is my week 72 as a reviewer. But first, let me ask y'all. Am I weird to think that you should finish coding the thing and testing the thing before kicking it out to review? Cuz that's how I do it. And that is the process at my work place.
So anyway, I was doing this review. And it was very wrong. Like really, really wrong. We give a thorough intro to our product (perhaps too thorough) so this guy should have known every test case he had to cover. Or at least, if he was unsure, asked. It was all documented.
Anyway, he kicks out this peer review. First thing I notice, it is not following the standard. Fair enough, we didn't give him the coding standard. BUT HE DIDN'T EVEN MAINTAIN THE FORMAT OF THE ORIGINAL FILE. HE JUST DID HIS OWN THING!!! So I email him the coding standard and make a comment in the review. He denies the finding. No reason. Just turns it down. Strike 1.
Then, I'm going through and he didn't even cover all of the core cases. I found several core cases that he missed. And every edge case. Make a not of it. He fixes only the couple of examples I gave him. Strike 2.
Guy decided to redesign a major chunk of our interfaces. Our interfaces are not just used by us (hence interfaces). We designed them the way they were for a reason. It was not a fun design process. Myself, the architect, one of our customers, and the guy that did the implementation all told him to roll back his change. Especially since it wasn't in the scope of what he was doing. He wouldn't. Strike 3.
I go to the lead and bring him in. He has a talk with him. All of the sudden he is putting out multiple builds per finding. Like most times I will put out like 2 to 4 for the whole peer review. No he kicks out minimum one per finding and chokes the review queue. Strike 4.
Strike 5: he tells me, a former DBA, that I didn't know what I was talking about when I told him to move something into a new table, even after I told him that "while in database terms it doesn't make sense, this is for product robustness".
Strike 6: he was just a condescending asshole. Bragging about how he did this job and that job over his career. His longest position held was about 18 months. Bragged about working at my company and being some hotshot at the company: only worked here for 8 months and that was 5 years ago.
You know. I have never really wanted to fight someone after about undergrad. But he came close.7 -
Ever heard of event-based programming? Nope? Well, here we are.
This is a software design pattern that revolves around controlling and defining state and behaviour. It has a temporal component (the code can rewind to a previous point in time), and is perfectly suited for writing state machines.
I think I could use some peer-review on this idea.
Here's the original spec for a full language: https://gist.github.com/voodooattac...
(which I found to be completely unnecessary, since I just implemented this pattern in plain TypeScript with no extra dependencies. See attached image for how TS code looks like).
The fact that it transcends language barriers if implemented as a library instead of a full language means less complexity in the face of adaptation.
Moving on, I was reviewing the idea again today when I discovered an amazing fact: because this is based on gene expression, and since DNA is recombinant, any state machine code built using this pattern is also recombinant[1]. Meaning you can mix and match condition bodies (as you would mix complete genes) in any program and it would exhibit the functionality you picked or added.
You can literally add behaviour from a program (for example, an NPC) to another by copying and pasting new code from a file to another. Assuming there aren't any conflicts in variable names between the two, and that the variables (for example `state.health` and `state.mood`) mean the same thing to both programs.
If you combine two unrelated programs (a server and a desktop application, for example) then assuming there are no variables clashing, your new program will work as a desktop application and as a server at the same time.
I plan to publish the TypeScript reference implementation/library to npm and GitHub once it has all basic functionality, along with an article describing this and how it all works.
I wish I had a good academic background now, because I think this is worthy of a spec/research paper. Unfortunately, I don't have any connections in academia. (If you're interested in writing a paper about this, please let me know)
Edit: here's the current preliminary code: https://gist.github.com/voodooattac...
***
[1] https://en.wikipedia.org/wiki/...29 -
during code review...
peer: "you should pass this variable, and extract the logger from it"
me: "why? it is a 3 line logging function. why not pass the logger instance?"
peer: "because that is our best practice. It is the way we do things"
me: "why is it a best practice?"
peer: "because it is. We use it everywhere!"
me: "No we don't. And I still don't understand why is this a best practice. can you explain?"
peer: gives ups, did not look at the mr, and was not going to.
mr stays open. probably forever.11 -
Got moved to testing last week, (due to lack of testers) being a developer it requires a whole different mind set to test !!!
But running selenium scripts and again verifying manually sucks.
But what hurts the most is rejecting something that you approved during peer review 😱🤭3 -
Me: Are you sure you want this in the acceptance test procedure?
Lead: Yes.
Me: I'm just saying, we don't have any requirements for this feature so it doesn't really belong there.
Lead: Just put it in.
Me: Are you sure? It's a lot of work for something that isn't even required to be there.
Lead: Go do it.
Me: Okay.
*I do the work and it goes to peer review*
High ranking person from another team: I don't see any requirements traceability. Why is this in here if there are no requirements?
Me: WELL AIN'T THAT A GOOD GODDAMN QUESTION!?3 -
I know, I know, "OMG ppl are wrong the internet."
Even so, I don't think I'll ever fully get past the continuously lowering barrier to entry on sites like medium and free code camp, and at times even alligator.io. The information routinely ranges from wildly inaccurate to dangerously wrong with few checks and no peer review can't be good for the industry in the long run.
Starting to yearn for the old days when the biggest risk was skilled plagiarism.3 -
The worst thing I've seen another developer do is not give constructive criticism where needed, as well was fail to accept constructive criticism when offered.1
-
Really loving the instant legacy code being added to our new project by devs who think they are too good to follow our peer review process, yum... today I found out that there are two different implementations of an API endpoint that does the same thing running in prod, in two different places, because the guy who wrote the second one wasn't aware that the first one existed and didn't let a second developer look at it before he pushed it to master.7
-
Expectations VS. Reality : A new Software Project (After all designs and requirements are clear and fixed.)
EXPECTATIONS:
Day 1: Create workspace, Configure tools
Day 2: Implement high priority Feature
Day 3: Write UT and peer review
Day 4: Push first feature to Prod.
REALITY:
Day 1: Create workspace, Setup configurations
Day 2: Still setting up configurations
Week 1: Almost done setting up configurations
Week 2: New migrations issue, again reconfigure before coding starts
Week 3: Take a vacation
Month 2: Finally things are working but God knows what was the issue...1 -
Hey guys, I have a serious question for you: How do you define science?
And yes this is going to be a long Rant. This topic really pisses me off.
A bit of context first. I come from a "humanities" background. I study history and dude, I love it. The problem is that even though we fucking pull our brains out studying historical phenomena with a fucking ton of conceptual tools, our work is mostly seen as literature to entertain the elderly during their lonely evenings. But that's not really the point of this rant.
My fucking problem is that while we try to do some serious work; actual work that could help society for real, it all goes into that magical fucking kingdom called "humanities". HOW THE FUCK DO THEY DARE TO CALL SOMETHING "HUMANITIES". IT'S A FUCKING HISTORICAL TERM THAT MEANS "TO FULFILL MEN IN ALL IT'S ASPECTS", AND NOW THEY'VE REPURPOSED IT, MAKING IT CONTAIN ANY STUDY THAT ISN'T "EMPIRICAL", "OBJECTIVE", ADD ANY FUCKING SCIENTIFIC DELUSIONARY TERM YOU CAN THINK OF.
And don't get me started on "objectivity". Oh boy, your fucking objectivity is hollow as a kid's balloon. There is no such thing as a objective study, even when it applies your "rational" "godly" scientific method. Some guys follow that shit as if it was a fucking religion. I do understand it's useful and all that, but in the end it's just a tool, you can't fucking define "science" by it's tools.
"""Q: What is carpintery?
A: Well, it's hammers, nails and wood. Yep. Hammers, nails and wood."""
THE SCIENTIFIC METHOD WAS FUCKING INVENTED DURING THE XVIII CENTURY, WHAT THE FUCK DO YOU THINK WAS GALLILEI BEFORE THAT? "HUMANITIES"?
Why do I say objectivity isn't posible? Well, guess what? YOU ARE FUCKING HUMAN. Every thing you know is full of preconceptions and fucking cultural subjectivities invented to understand the world. And it's ok, becouse if you understand your own subjectivity, at least you can see yourself in a critical sense, and at least "tend" to objectivity, in the same way functions tend to infinity.
And here comes the best part: people studying "cs" in my university pass most of the time studying a ton of shit that isn't really science, but is taken as scientific becouse it is related to "science". These guys spend entire semesters just learning programming fundational stuff that in my opinion isn't really science, it's just subjective conceptual constructs built to make the coding process better. They only have TWO fucking classes on discrete mathematics and another 3 or 4 in actual scientific fields related to computing. THESE GUYS AREN'T FUCKING BEING TAUGHT TO BE COMPUTER SCIENTISTS; THEY ARE TEACHING THEM TO BE PROGRAMMERS. THERE'S A HUGE DIFFERENCE BETWEEN CS AND PROGRAMMING AND THAT IS THE WORD SCIENCE. And yes, I'm being drastic on the definition of science on purpose becouse guess fucking what? I'M PISSED OFF.
"Hey, what are you doing?"
"Just doing science with scrum and agile development."
I understand most of you guys would think of science as "the application of the scientific method", "Knowledge by experimentation and peer-review", "anything techy". Guys, science is a lot broather than that. I define it as "the search for truth", mainly becouse that's what we are all doing, and what humans have been doing to gain knowledge through the ages. It doesn't matter what field of truth you are seeking as long as you do it seriously and with fundaments. I don't fucking care if you can't be objective: that's impossible. Just acknowledge it and continue investigating accordingly.
I believe during the last centuries the concept of science has been deformed by the popular rise of both natural and applied sciences. And I love the fact that these science fields have been growing so much all this time, but for fucks sake don't leave every other science (science as I define it) behind. Governments and corporations make huge mistakes becouse they don't treat history, politics and other sciences seriously. Yes, I called history a "science", fuck you.
And yes, by my definition programming is not a science. I don't know what most of you think programming is, but for me it's a discipline that builds stuff, similar to carpintery or blacksmithing. Now if you are pushing the limits, seeking ways to make computing go further, then that's science. The guys that are figuring out AI are scientists, the guys that are using it to detect hotdogs aren't - unless they are the same person- deal with it. I guess a lot of you guys are with me on this point.
In the end, we are all artisans building abstract tools by giving orders to a machine.
I still have some characters left, so I want to thank the community as a whole for letting me vent my inner rage. I don't have much ways to express myself on these matters, so for me DevRant is a bless.8 -
My company's process basically boils down to this:
-Hour long meeting to open an issue.
-5 lines of comments.
-Update three documents.
-5 days for a peer review.
-40 bitchy comments about how everything you do and love is terrible.
For a one line code change to prevent a show stopping exception.2 -
You all talk about your peer review ducks, I present my peer review puppy with my new stickers! I can't help but think he isn't doing his job...1
-
Saw a counting variable in code. It was a necessary counting variable, so that is not what this is about.
However, this is a US based company that has a somewhat PC (no cursing) and professional cultural facade.
This variable was called "cnt". How the hell did that one not get caught in peer review? I have gotten dinged for having "possibly offensive" variable names (think Point5Hit though I have never written that as a variable name). It was funny. But I have changed it because that's just lazy.9 -
Repeat/repost:
Unfortunately I do not own a drop of what is conventionally known as confidence or ego. It applies to everything; work, skills, relationships, friendships, you name it. I can estimate my chances of succeeding, and sometimes be pretend-delulu for a purpose (you gotta admit, sometimes showmanship is the biggest asset) but I don't understand confidence. In my opinion, it's just a gross overestimation of one's chances.
So this project/paper thing, I feel like I'm blind and running in the forest. I am not counting on my boss, nor am I counting on anyone in the dept to give me clarity or decent feedback. ("Cutting edge" research issues. Not anybody's fault.)
And I guess, in the worst case scenario the paper will be rejected, which would be a setback but not a full failure.
... Actually, that's not the worst case. The worst case would be someone running a peer review and finding that I made a tiny mistake and all my results are bullshit. 🤦
... Anxiety is eating me alive rn. 🤢4 -
I cant keep this inside anymore I have to rant!
I have a colleague that is an horrendous loose bug-cannon. Every peer-review is like a fight for the products life.
Now I understand - everyone makes bugs me included and it is a huge relief when someone finds them during peer-review. But these aren't the simple kind of bugs. The ones easily made when writing large pieces of code quickly. Typing = instead of == or a misshandling of a terminating character causing weird behaviour. These kinds of bugs rarely pass by a peer-review or are quickly found when a bug report is recieved from testers.
No the bugs my colleague makes are the bugs that completly destroy the logic flow of a whole module. The things that worst case cause crashes. Or are complete disasters trying to figure out what causes them if they are discovered first when the product reaches production!
Ironically he is amazing a peer reviewing other peoples code.
But do you know what the worst thing of all is! Most of the bugs he causes are because he has to "tidy up" and "refactor" every piece of code he touches. The actual bugfix might be a one liner but in the same commit he can still manage to conjure up 3 new bugs. He's like a bug wizard!
*frustrated Aruughhhh noises*9 -
How do I convince a dev department to take source control, peer code review and unit tests seriously?
I'm a recent software grad with internships that recently started at a smallish company (less than 20 employees but has been around for 10 years, with most senior non-mgmt employee around 6 years). I've been working here for less than a year (approx 5 months) and I love the company - lots of talented and passionate people.
We are a creative industry with a handful of devs and one of the issues I'm seeing is that often devs are working in silos. I'm trying to make suggestions to upper management like encourage more usage of source control, documentation, etc and most of the senior devs are pushing back - saying that they don't feel that it is necessary and due to the fast moving nature of our projects that all this would be a total waste (they were so fast on the idea of not having PR's because it would be "too much of a blocker").
I understand that a large part of this has more to do with shifting the culture in the department and that can be very hard to do, especially since i'm fresh out of school, but I see these devs have so much potential but it seems that they think having these implementations in place would mean more rigid rules and bureaucracy.
I've been speaking to some of my engineering friends and they're pretty much all just telling me that I am shooting myself in the foot if I continue to stay at this company because I'll be behind skill wise, but part of me isn't ready to just give up yet.
looking for some advice10 -
How shit are my colleagues? This shit...
Export class TypescriptClass {
DataHasFinishedLoading: Promise;
doAThing() {
GetData()
. Subscribe(all The Data => {
//do some shit with the data
This. DataHasFinishedLoading = Promise. Resolve(true) ;
} )
}
}
This guy has about 10 years experience doing literally javascript. And this code made it through peer review.1 -
How do you deal with a manager like this?
My manager is close with 2 colleagues who constantly suck up to them and who they're pretty much friends with.
I don't particularly like to do stuff like that and don't really like the manager either (in my opinion they're incompetent) but now, often when I write code, the manager will have those colleagues "check" it. Not peer review, as I never get feedback. Just occasionally I'll find out they "checked" my code to see if I work/do my job right.
This is despite me being more senior than the both of them, having contributed far more actual code to the project than both combined and one of them can not even write proper code!!!
I'm honestly tired of sitting here and working on boring long tasks, and then being treated (behind my back) as if I am not working.
It's building up this paranoia in my head that this problem is also making other colleages/my boss think that I am slacking.
I used to be so close with everyone at the company, but now I feel completely alone and alienated...28 -
Tl;dr I am incredibly ashamed of my code at work.
I recently started working as a junior dev. I know many aspects of the stack I use, and I feel pretty comfortable when solving simple and specific problems.
But this is the first complete project I make, and I received no peer review until now. And my code sucks.
I tried my best to deliver a good and working code, but it became messy in too many places. Now it's too late to refactor.
Probably I just cannot see the right way of modeling specific situations, I don't feel I should blame the frameworks I'm using, but the point is that my code sucks. Or at least this is how I feel.
I'm going to leave this workplace soon (personal reasons, not related to this topic and/or the company), and I am kinda scared of the shit I'm about to leave to them. It's a very nice environment and they don't deserve this crap. Also I have some other good reasons to worry about this, but I cannot tell them.
My plan is to finish a couple or personal stuff I have to do and then spend as many hours I can on the project trying to finish it asap and make the code better (for now I've been working only 6hr/day).
I'm really thinking that I just suck at this.12 -
First rant here
Well thing is that my CS school did have teachers and half the grade was from a product presentation and half on teammates reviews.
My teammates mostly didn't have any idea what SOAP was. That was the theme of the project and we had to make a Webservice which they didn't even understood what it meant.
I spent one day from 8am to 1am trying to explain, in despair I ended up not sleeping, not eating, working 24/7 all the week and collapsing of exhaustion.
I was taken to the hospital, got back home but have lost time and had only implemented 3/4 of the functionalities.
The others (6) only did managed to make a basic GUI I would have to link myself. One of them, the project manager had done testing and lots of good stuff, made a 80pages report but the other 5 were shitty.
They all gave me the worst peer review grade but the manager, they got A I got C (ABCD scale).4 -
How the fuck am I supposed to fucking keep working if these fucking clowns add mandatory peer code review and passing build gating on main repositories (which I completely agree with to be fair) but they don't fucking review pull requests at all? For fuck's sake, am I the only one that reviews them seriously and promptly in this shit ass fuck company? I follow all the recommended guidelines so don't bullshit me with "iT iS nOt FuN tO rEvIeW pUlL rEqUeStS", do your job or just remove yourself from the fucking gating process, you worthless admin ass crust.
And don't get me started on fucking builds that fail randomly because some worthless shit bucket added unstable networking tests as unittests somehow, making your pull request get auto-disapproved by peers upon failure.
I got so many pending pull requests and management won't do fuck all about it because they won't force people to do their job by fear of pushing them around and get HR complaints that I am tempted to simply give up and just start playing videogames.5 -
Yay my first day back and I'm 1 hour and 15 minutes late because the main road I take into work was a parking lot. And then I have to go directly into the world's longest meeting. And I have a peer review to do so I guess no dev soon for me today.
-
Ok story number 2, this one takes place back when I was at Uni.
We had a group project where we had to make a basic website. Nothing fancy, just basic HTML/CSS/JS.
We were a group of 3, one of the guys did a fairly good job with the CSS, he made a really good looking banner/footer and a kind of ‘featured’ page which looked awesome.
But the other guy... his contribution was the ‘contact us’ page, which consisted of a totally static table with dummy info and an embedded Google map showing the location of our fake car dealership.
Meanwhile I wrote all the Javascript, complete with a fake in-memory database containing our car data for displaying on the home page. Even had basic filtering. I made sure to mention in the peer review that I felt like he could have done more. -
3 weeks back took a bug..
**long rant**
Looked into it and found that it is exist in older version(say V1) as well.
Sent mail to client stating i can fix this in current version (say V2). Since V1 is already released and our current code stream is V2 and so if we fix in V2 , the code will not reach V1 code base.
**explained to client**
Client : I mean if you fix why it won't work in older release.
Me: Explains how code streams will work.
Client : Okay.. but it will support the functionality in V1 , right ?
Me: (*internally* are fucking kidding me? It won't work dumb ass.) No. It won't work in older versions. I am fixing it in V2.
client: okay.. Let's proceed.
Me: Done code changes. Send code to review. (we have to send review to upper level manager).
Manager1 : I didn't liked this part. can you change this ?
Me : sure. Done.
Manager1 : Now i liked it. Sent review to Manager2.
Me: why the fuck ? Are you not sure about my changes are good?
Manager 2: I liked it, but need some log changes.
Me: Fuckkkk...... Let me change this.. Done. Now can I promote those changes?
Manager2: No we need to send review to client manager as well.
Me: Goddammit.. Okay.. sent review.
*After a fucking week..*
Client Manager : Looks good. Push the code.
Me: Finally..
(This process took 18 days which would have been completed in 3 days if there is only one peer review)
Now the other guy from client whose tracking the bugs reported why it took so long to fix it.
I think my client manager is over paid and can't even know how his company code stream works. Fuck you . why client has these lazy ass old fucking "I don't look into my email" type people. God I hate these "I am in rich country" people.2 -
What is wrong with these people!!!
Last minute changes are pain in the ass... the design team review gives a go ahead but then pm team doesnt agree and and you have to get the changes suggested done in a day??!!!
In half a day you have to get ux review, peer review, module owner review, architect review, pm review and then merge publish bump and test in ci?!!end of sprint is today...
Ugh!!!every sprint!!every fuckin sprint!!! -
Running unit tests on a peer review. Why have unit tests if people don't run them? That said: our system guy wants us to start doing agile TDD. This would not be a problem if we weren't a maintenance shop and the code base doesn't really allow for TDD.3
-
Thanks to Google Chrome for the "HOLD Cmd + Q to quit" option. Saved the day while I was writing peer feedback :D4
-
I hate it when I fuck up an update and don't realize it until the next morning.
Did an update last night. Had a large amount of bugs that I had to fix. Some caused by me not testing all the way, some caused by some other guys doing maintenance last night and me not knowing about it.
Woke up to a text from my boss asking if I even tested the program last night. Yeah, I just made sure it loaded after the nightmare amount of bugs I had. I just missed a portion of the program. So I fixed the portion of the program and then he asked me to roll the program back and try again tonight.
What makes this even better is I was really hoping for this to go smoothly. I'm also doing another program release and its going really fucking badly too, security is fucking the shit out of me. My peer review is Monday. I haven't gotten a raise in a year and a half since I started at this company and I was going to ask for one. But this kind of dashes my confidence on the rocks.4 -
Was asked to do a peer review on a coworker who I barely worked with. When I say barely, it’s like maybe 1 hour out of 8760 hours in a year.
Can I just ask them what to write?2 -
StackOverflow, if the community's peer review process is as good as you claim, why would you have to fear any AI / chatGPT generated content after all?
Notice today: "We do not currently allow content pasted from ChatGPT on Stack Overflow; read our policy here."6 -
Advice to New Devs: Peer review code with co-workers and constantly learn and improve. Ask a lot of questions and during your down time learn something new. :)