Coworker in my team recently said to boss:

"Thanks, this conversation with you has taught me so much about single-threaded blocking I/O"

Some random PR comments from our company's repository:

"Are you insured? I hope you are insured"

"Learning git is not that difficult. You only need one command: git reset --hard"

*Link to amazon for dog poop bags*
"Please clean up your shit, before I step in it"

"Have you thought about a career in sales? At least there you might sell your bullshit"

Had a PR blocked yesterday. Oh god, have I introduced a memory leak? Have I not added unit tests? Is there a bug? What horrible thing have I unknowingly done?

... added comments to some code.

Yep apparently “our code needs to be readable without comments, please remove them”.

Time to move on, no signs of intelligent life here.

Manager: Hey how come you left so many comments on my PR?

Dev: Well you’ve just recently learned how to code so there’s going to be a lot of things to learn beyond what you’ve picked up in your online coding tutorials. Don’t worry it’s only minor things like you put everything all in one function, left outdated comments in the code, have if statements 4 levels deep, have a console.log after every line of code some of which log .env variables, skipped error handling, cast to “any” a bunch instead of using more specific types, didn’t write any tests and some unrelated tests are now failing due to a circular dependancy.

Manager: THAT IS SO DISRESPECTFUL!!APPROVE MY PR IMMEDIATELY. IT WASN’T EVEN EASY FOR ME TO CREATE THE PR, NOW I HAVE TO MAKE AN UPDATE!? YOU’RE THE DEV, YOU SHOULD FIX IT NOT ME!! NEVER COMMENT ON ANY OF MY PRS AGAIN.

Root: Fleshes out missing data in some factories. Tests affected code and finds the change breaks some specs (but shouldn’t).

Root: Reaches out to spec author.

Root: Messages thundercunt (the ticket’s code reviewer) on slack about the specs and the reaching out. No response.

Root: Works on another ticket while blocked.

Root: Logs off.

Root: Talks with spec author chick in the morning. Decide to pair on specs later.

TC: Still no slack response.

Root: Gives update in standup. Mentions factories and broken specs. Mentions pairing with spec chick.

TC: Still no slack response.

Root: Pulled off tickets in favor of prod issue. Gets ignored by everyone else diagnosing prod issue. Investigates prod issue by herself. Discovers prod issue isn’t from bad code, but bad requirements — code works as requested. Communicates this with details. Gets ignored by people still diagnosing prod issue. Tries again. Gets ignored. Gives up. Works on non-blocked tickets instead.

TC: Still no slack response.

Hours later:

TC: Comments on PR telling me I broke specs (how did I not notice?), that I need to reach out to spec chick and work with her, and that I can’t resolve the ticket until it’s fixed and passes code review.

TC: Still no slack response. (21 hours later at this point)

TC: Logs off. Still no response (25 hours at this point)

———

Ignoring the prod issue for the moment…

I broke specs. No shit.
I need to talk with spec chick. No shit.
I can’t resolve the ticket. No shit!

Bitch, I told you all of this 21 fucking hours prior, and again 3 hours prior during standup. But no, I clearly “don’t communicate” and obviously have no bloody clue what I’m doing, either, so I need everything spelled out for me.

And no, I didn’t resolve the fucking ticket. Why the fuck would I if it still has pending changes? Do you even check? Ugh!

And what the fuck with that prod issue? I’m literally giving you the answer. fucking listen! Stupid cunts.

Why is it all of the women I work with are useless or freaking awful people? Don’t get me wrong, many of the men are, too, but I swear it’s every single one of the women. (Am I awful, too?)

Just. Ugh.
I can’t wait to leave this sewer of a company.

Oddly still a good day, though. Probably because I talked to recruiters and sent out my resume again.

I found a cool project on GitHub. I forked it and added a simple dev server with the intent of making it more accessible which could lead to more activity = improved project. I created a PR with small concise commits with very informative messages.

The guy who owns the project comments and says "I don't want your dev server, I have an apache instance locally on my computer". I tell him "Ok sure, but wouldn't it be nice if everyone else also had a nice dev server which can be started with a single command?", and other people join the PR and agree with me that we should make it available for everyone.

But the fucking idiot doesn't care, "No, I prefer to use my apache server". YOU FUCKING ASS WIPE, why do you even put it up on GitHub if you don't want contributions to make your project better and more available? I saw other open PRs where he basically did the same thing, left a snarky comment without merging it. What a fucking tool. Worst spent time ever.

FUCK YOU

I'm reviewing a PR and it's easy to detect which functions were created with an AI: the ones that have comments.

Felt so awkward today. Bare in mind I am still a junior. I was on a pull request reviewing session on a repo I use. I was being super super pedantic with variable names, data types etc as the people who wrote it are brand new to the company. I then realise I had just reviewed the companies lead developers PR to a different repo. Every time someone comments on a PR on this repo all developers in the company get an email notification. I sat there litrually sweating, bright red with the words 'oh ****' on an infinite loop in my head, staring at the screen waiting to see what was to happen.

Thankfully he was ok with the comments. But now people keep calling me the lead developer (teasing) fml I hate anxiaty

I have not remotely had the energy to post here. Nor reply. And it is a shame because most of you I consider friends. And if not friends, at least excellent aquitances.

People make comments, I dont reply. People make threads, and I dont respond. People make ++s, and I'm a ghost.

I enjoyed shitposting, and asking questions, and hopefully entertaining some of you. I really do.

I'm just in a funk where nothing seems to matter right now and I dont know why, pr how to get out of it.

I have threads, and responses from scor, nanos, nachoscode, and a dozen others I usually enjoy interacting with and it's like all the life has just been sucked right out of me.

I feel isolated and alienated from everything and everyone and I dont know why or when it started. Its just..there. nor how to talk about it.

I think I'm becoming a misanthrope or something. The more I go on with this sensation, the less I want to be around people, and I dont understand why.

So, I just realised that a contribution I made to an open source project 12 days ago had gotten accepted 3 days ago. I'm so ecstatic over this!
I was basically just in need of type definitions for a javascript library, and seeing as it didn't have any, decided to make them myself. Done that, I made a pull request, but seeing as there was no changes after a few days, I forgot about it.
Now I just remembered about that, and wondered if it got any comments or anything, and it turned out that they had accepted my PR and it had already been put into a release 3 days ago
I can't contain myself right now, it was my first open-source contribution, and it just feels good to know that I somehow helped some people by giving them type definitions :D

Cheers

Just checked a pr I need to take care of tomorrow…

“Please review [other pr] first, this solves a bug the other one introduces”

…Ah yes. Stupidity.

“Already tested by QA, accept without comments or job will be wasted.”

… I need a vacation or a megaphone to make someone deaf by screaming in their ears again and again: “follow the fucking processes instead of making QA preapprove your shitty code.”

No comments on PR after thorough review

So recently my open source project took off and got trending on GitHub (680 starts and 225 forks). This was the first time a project of mine really gained some traction and invested more of my time and weekends to maintain this project - I wrote comprehensive docs, contributing guidelines and reviewed PRs and made sure I commented on every single one of them. Sure, it isn't easy to review 50 PRs a day after coming home from work but the excitement of seeing this project becoming trending fueled me.

First 2 weeks it was good. I would come home from work and have dinner and sit down to maintain the project. Whenever contributors would be stuck, I would help them and write comments on each PR.

But the problem started since last week. People just really want to see their contribution activity graph get populated and hence they would make stupid PRs and literally no one followed contributing guidelines - I mentioned in that that the code should adhere to Pep8 styling but no one gave a shit. Each day I would spend reviewing PR with crappy formatted code and no sign of Pep8, and even some will just file PR and add a fucking docstring to every function or add paragraph of comments. Also, the PR quality was bad with unsquashed commits amounting to 10 or 20 or even sometimes 50.

I wrote the contributing guidelines doc and in that I mentioned every source that contributors could find helpful like how to squash commits, how to file a PR and Pep8 and not to write useless comments. Seriously people, grow up!

I was asked to fix a critical issue which had high visibility among the higher ups and were blocking QA from testing.

My dev lead (who was more like a dev manager) was having one of his insecure moments of “I need to get credit for helping fix this”, probably because he steals the oxygen from those who actually deserve to be alive and he knows he should be fired, slowly...over a BBQ.

For the next few days, I was bombarded with requests for status updates. Idea after idea of what I could do to fix the issue was hurled at me when all I needed was time to make the fix.

Dev Lead: “Dev X says he knows what the problem is and it’s a simple code fix and should be quick.” (Dev X is in the room as well)

Me: “Tell me, have you actually looked into the issue? Then you know that there are several race conditions causing this issue and the error only manifests itself during a Jenkins build and not locally. In order to know if you’ve fixed it, you have to run the Jenkins job each time which is a lengthy process.”

Dev X: “I don’t know how to access Jenkins.”

And so it continued. Just so you know, I’ve worked at controlling my anger over the years, usually triggered by asinine comments and decisions. I trained for many years with Buddhist monks atop remote mountain ranges, meditated for days under waterfalls, contemplated life in solitude as I crossed the desert, and spent many phone calls talking to Microsoft enterprise support while smiling.

But the next day, I lost my shit.

I had been working out quite a bit too so I could have probably flipped around ten large tables before I got tired. And I’m talking long tables you’d need two people to move.

For context, unresolved comments in our pull request process block the ability to merge. My code was ready and I had two other devs review and approve my code already, but my dev lead, who has never seen the code base, gave up trying to learn how to build the app, and hasn’t coded in years, decided to comment on my pull request that upper management has been waiting on and that he himself has been hounding me about.

Two stood out to me. I read them slowly.

“I think you should name this unit test better” (That unit test existed before my PR)

“This function was deleted and moved to this other file, just so people know”

A devil greeted me when I entered hell. He was quite understanding. It turns out he was also a dev.

Had a five hour long debate with one of our Senior Developers today about pull request etiquette.

His view was reviewers should always email or call him before adding comments to any of his requests and they should never block them as he should be allowed to code in "his own style" and should be able to approve his own pull requests.

I explained that we have code standards and an agreed PR workflow be needs to comply with.

He then started talking about meteors and plane crashes. Literally no helping some people.

With over 10 years as a dev under my belt I never wanted to change company before my probation is even over. I never felt so drained, and pissed off for the entire duration of my working hours, every day for about 4 months straight. I was thinking it should get better, I listened to all the rubbish webinars about the company culture, how inclusive and diverse we are and how they value phycological safety and how everyone should feel safe to speak their mind. The people are fucking reviewing my approved and merged PRs and expecting me to address their comments. Like someone goes on holiday and when they’re back they want to spray wisdom around, and that seems to happen to everyone not just me. When we have technical discussions and I express my opinion I get given out to for speaking too much. Like what the actual fuck, your code is shit, everyone knows it and complains about it, but we should look at what we already have as an example. How the fuck you think you can improve your code if your not going to change your shit. Writing class diagrams for about two weeks at start of each project and nitpicking every fucking thing, only to abandon it after our first sprint as the fucking requirements have changed and what we agreed at the beginning as no longer relevant. No shit as if they don’t know requirements change ALL THE FUCKING TIME AND THIS IS EXPECTED. I was also asked to send a slack message every morning when I start working, when I get my lunch, when I am back from lunch and when I finish work. Have to fill in some stupid weekly update system with what tickets I’ve worked on during the week, like have you heard of Jira filetrs ? Stop asking me how I am getting on if I’m fucking closing all my tickets every sprint. I don’t ask you questions, if I finish all the work you asked me to on time, you can safely assume I am doing fine. Also your fucking back to back meetings are not helping me close my tickets any faster. Already got an offer from another company I am out of fucking here.

YOU CAN ALL STICK YOUR PR COMMENTS, ENDLESS MEETINGS AND WHAT NOT UP YOUR FUCKING ARSES. 🖕🏻🖕🏻🖕🏻🖕🏻🖕🏻🖕🏻

Seriously, a new guy joined out team and suddenly I'm out of my comfort zone and started following the pattern I used to follow. The thing he did, commented on my PR, a lot of comments.
I had this thing that hey now I can control anything right, new guy? less experienced? yes, so I don't need to be intimidated. But I realised today that I'm easily intimidated my intelligent people because I think now I am the inferior one.

I will push myself to think about it in a better way, by looking at it positively, to learn something from it.

Start-up I'm working for as a front-end dev is pretty nice. I have good hardware, free coffee and my coworkers are all decent people. My boss is chill, and I have flexible work hours.

There is this one policy for writing code, however. And I simply cannot understand it, nor can I ignore it because of code reviews: no comments in production code.

I mean, what? Why? Comments are nice, and they make life easier for the future maintainers. At least let me put a small two-liner explaining why I did stuff this or that way. But no, I only get to explain it verbally (once) to the person reviewing my PR. Why, man?

Fuck, I keep missing PRs and comments, because github doesn't notify if you're not directly tagged, is there some better way to get notified about things like new PR on your repos or generally notifications?

Senior Tech lead keeps yapping about "we need more comments in the code"... Yeah right...

I reviewed his PR today:

# Get the feature list
builder.get_feature_list()

# Assign the features to the columns
target.columns = features

...
FFS

tldr: maintainers can be assholes

So there's this python package+cli tool that I found interesting while browsing github and thought of contributing to it. Now this repo has around 2000 issues and multiple open PRs so seemed like a good start.

So i submit 2 PRs implementing similar features on different sites (it is a scraping repo). This douche of a maintainer marks comments various errors in the code convention not being followed without specifying what they actually were. Now I had specified that i was new to this repo so and would need his help (I guess this is one of the jobs of the reviewer). This piece of shit comments changes in the pr with one or two word sentences like "again", "wtf" and occasionally psycopathic replies. That son of a bitch can't tell what's wrong like wtf dude, instead of having a long discussion over the comments section of the fucking pr why can't you just point out what exactly is wrong and I'll happily fix that shit, but no, you have to be a douche about out it and employ sarcasm. Well FUCK YOU TOO.

What is it with people just blindly fucking copy pasting from a different project, seeing it work and then submitting it for review.

You copy 2 lines, one of which fixes the thing, WHY KEEP THE OTHER USELESS IRRELEVANT PIECE OF FUCKING SHIT IN THE FUCKING CODE WHY BOTHER WITH KEEPING IT IN IT'S MORE TECH DEBT BECAUSE NOBODY WILL KNOW WHY IT'S THERE

WHY DO I CONTINOUSLY HAVE TO POINT THIS OUT IT'S SO FICKONG TIRING TO CONSTANTLY HAVE TO BE THE ANNOYING REVIEWER WITH +20 COMMENTS ON SMALL PRS IM SO FUCKING TIRED OF BEING 'THAT GUY'

In my language it's called being 'slordig'. Whenever I submit sometning for review I always go over the diff to see is I missed anything that is no longer required and remove it WHY DONT THEY DO THAT TOO

And then their PR stays open for 2 weeks like they forgot about it and during standup they say 'its in review' like I havent already looked at your piece of shit code

FUCK

PR reviews, people leave great comment, some suggestions and there could be a discussion.

But please don't be the person who goes there and add those weird and useless comments such: "CI failed, your PR is behind dev branch..."
That's the role of the provider(Github, Bitbucket.....) and adding that comment is just a waste of time.

This start to happen more often and I had to rant about it :D

*Assigns coworker as reviewer for a PR*
*Reviewer comments on something he thinks should be changed*
*Reviewer realizes I went home as it is Friday afternoon*
*Reviewer is super impatient, and chooses to push the change himself. He then accepts the PR (his own code) , merges, and makes a release*
*Team lead starts yelling since an obvious bug made it to prod - Literally white frontpage*
*Reviewer blames me, since the bug comes from my PR*

... Thanks, former employee. F*cking thanks. I know you got fired for being a d*ck, but I hope karma kicks you in the butt for the rest of your life..
And ps. to you: Don't blame coworkers when you can check the history.

F*ck some people..

Hello DevRant community! It’s been a while, almost 5 years to be exact. The last time I posted here, I was a newbie, grappling with the challenges of a new job in a completely new country. Oh, how time flies!

Fast forward to today, and it’s been quite the journey. The codebase that once seemed like an indecipherable maze is now my playground. The bugs that used to keep me up at night are now my morning coffee puzzles. And the team, oh the team! We’ve moved from awkward nods to inside jokes and shared victories.

But let’s talk about the real hero here - the coffee machine. The unsung hero that has fueled late-night coding sessions and early morning stand-ups. It’s seen more heated debates than the PR comments section. If only it could talk, it would probably write its own rant about the indecisiveness of developers choosing between cappuccino and latte.

And then there are the unforgettable ‘learning opportunities’ - moments like accidentally shutting down the production server or dropping the customer database. Yes, they were panic-inducing crises of apocalyptic proportions at that time, but in hindsight, they were valuable lessons. Lessons about the importance of thorough testing, proper version control, reliable backup systems, and most importantly, owning up to our mistakes.

So here’s to the victories and failures, the bugs and fixes, the refactorings and 'wontfix’s. Here’s to the incredible journey of growth and learning. And most importantly, here’s to this amazing community that’s always been there with advice, sympathy, humor, and support.

Can’t wait to see what the next 5 years bring! 🥂

A bug is born
... and it's sneaky and slimy. Mr. Senior-been-doing-it-for-ears commits some half-assed shitty code, blames failed tests on availability of CI licenses. I decided to check what's causing this shit nevertheless, turns out he forgot to flag parts of the code consistently using his new compiler defines, and some parts would get compiled while others needed wouldn't .. Not a big deal, we all make mistakes, but he rushes to Teams chat directing a message to me (after some earlier non-sensible argument about merits of cherry picking vs re-base):
Now all tests pass, except ones that need CI license. The PR is done, you can use your preferred way to take my changes.

So after I spot those missing checks causing the tests to fail, as well as another bug in yet another test case, and yet another disastrous memory related bug, which weren't detected by the tests of course .. I ponder my options .. especially based on our history .. if I say anything he will get offended, or at best the PR will get delayed while he is in denial arguing back even longer and dependent tasks will get delayed and the rest of the team will be forced to watch this show in agony, he also just created a bottleneck putting so many things at stake in one PR ..

I am in a pickle here .. should I just put review comments and risk opening a can of worms, or should I just mention the very obvious bugs, or even should I do nothing .. I end up reaching for the PM and explained the situation. In complete denial, he still believes it's a license problem and goes on ranting about how another project suffering the same fate .. bla bla bla chipset ... bla bla bla project .. bla bla bla back in whatever team .. then only when I started telling him:
These issues are even spotted by "Bob" earlier, since for some reason you just dismissed whatever I just said ..
("Bob" is another more sane senior developer in the team, and speaks the same language as the PM)
Only now I get his attention! He then starts going through the issues with me (for some reason he thinks he is technical enough to get them) .. He now to some extent believes the first few obvious bugs .. now the more disastrous bug he is having really hard time wrapping his head around it .. Then the desperate I became, I suggest let's just get this PR merged for the sake of the other tasks after may be fixing the obvious issues and meanwhile we create another task to fix the bug later .. here he chips in:
You know what, that memory bug seems like a corner case, if it won't cause issues down the road after merging let's see if we need even to open an internal fix or defect for it later. Only customers can report bugs.

I am in awe how low the bar can get, I try again and suggest let's at least leave a comment for the next poor soul running into that bug so they won't be banging their heads in the wall 2hrs straight trying to figure out why store X isn't there unless you call something last or never call it or shit like that (the sneaky slimy nature of that memory bug) .. He even dismissed that and rather went on saying (almost literally again): It is just that Mr. Senior had to rush things and communication can be problematic sometimes .. (bla bla bla) back in "Sunken Ship Co." days, we had a team from open source community .. then he makes a very weird statement:
Stuff like what Richard Stallman writes in Linux kernel code reviews can offend people ..

Feeling too grossed and having weird taste in my mouth I only get in a bad hangover day, all sorts of swear words and profanity running in my head like a wild hungry squirrel on hot asphalt chasing a leaky chestnut transport ... I tell him whatever floats your boat but I just feel really sorry for whoever might have to deal with this bug in the future ..

I just witnessed the team giving birth to a sneaky slimy bug .. heard it screaming and saw it kicking .. and I might live enough to see it a grown up having a feast with other bug buddies in this stinky swamp of Uruk-hai piss and Orcs feces.

So, I had to listen very badly in a scrum about my poor code quality. Just because I haven't used the latest version of the library in my gradle build file, I haven't used DTO in the response of few endpoints in the controller class instead I used entity,... Etc was the mistake.

I admit that I have a long way to improve myself and there is a lot to learn, but there should be a proper way to escalate the situation rather than publicly pointing out mistakes rudely.

He is a senior with 10+ years of experience who badly told me in the scrum and not only that whenever there is a change needed in my PR he takes the screenshot and puts it in our dev team group and shows the mistakes and gives the suggestions instead of writing comments on the github PR.

Not only that, if I inform in the daily updates that I took 2 hours for this and that task, he says it should be done in 20 to 30 minutes.

Upper management has given him a lot of respect because he is knowledgeable and knows the stuff but it doesn't mean he is entitled to behave like this and demoralise other juniors.

The matter is cool now but this incident happened to me a few months back and those days were really toxic for me at work.

So.. I have raised a PR 2 weeks ago.. it needs approval from 2 of the senior Devs on my team. The first one reviewed it within 3 days, without having to follow up. Then comes the second one, who is senior than the first one. I have been following up with him on a daily basis for the past 1.5 weeks, each time I request him to review my PR he sends me a "sorry" followed by a stupid smiley. I have tried tagging him on Jira, setting up a meeting with him to get it done, nothing's working out. He has already looked at the code and I have explained him the code and the context, but he is just not adding comments/approving/rejecting the PR. I have missed the release date for the feature because of his lack of concern and petty excuses. So done with him.

The best code review experience I had is when I started with my first job I used to write 10 lines of code and used to get 20 comments on that, well i learnt a lot from him and now whenever i get review comments on my PR i actually feel good.

I recently have been delegated the responsibility of managing a 4 people team by planning the sprints, scheduling tasks, and in general "take charge" (as said by the boss).

What bothers me is there is this "developer" with a heavily toxic attitude, who feels he is above all laws and knows everything just because he joined some months ago all of us.

He is basically a human linter. When he code reviews, you can get away with any major mistake if your linting and indentation (and all that shit) is according to "his standards".

A new guy recently joined the team and was given an overwhelming task by the boss just to test whether he belongs here. (Again, wrong, in my opinion). He didn't know any of the technologies he needs to work on to complete that task but he still learnt them and got a working product. Albeit not according to our God's "standards".

Cut to the chase, the asshole dev is now mocking him in PR comments and demeaning him in every discussion. As a "team lead", what should I do? If I let it go, it'll make the environment toxic and I don't want him to get away with it. If I do take any action, I don't want to be seen as as pussy who can't take such minor insults. Please advise.

PS. The asshole developer once wrote a "friend request accept" API endpoint in such a way that when any single person accepts a request, that'll cause all pending requests (from any person to any person) get accepted. Fucked up the DB queries basically. This is just to give a perspective on what I'm dealing with here.

Nobody reviews my PR into test branch

The only guy who reviews it is the new senior dev who isn't yet used to how the company works, leaves comments about useless stuff and doesn't fucking approve

Jesus fucking Christ

PM tells me to merge (large feature) work that's heavily under WIP.

In that is a performance optimisation he instructed (with an aggressive DM) me to stop looking at even though it's a concern for larger clients that I had to fix before as it's "unnecessary" - thought whatever I'll leave the code as is then

I tell him him the PR is not ready yet, there is still a lot of clean up to and tests to write

Just do it

A ~week later "wow you write really selfish code like look at this"

Shows a wrapper class from the optimisation with 2 properties and getters and setters (and override some of super's properties). I explain to him why it's there, "that should have been a comment". I tell him I write detailed comments as part of my refinment process which he wanted me to stop.

This is after he tried to merge a release branch into main while sneaking in some "corrections" and I pointed out it breaks Dev.

That feeling when you're finally done with a pretty big PR and ready to go live. You excitedly send it out to a few of your peers, and then... 20 comments! The real work has just begun 😭

So i’m making my first Angular app here. I commited the first code setup and shot in the PR. I got 40+ comments so i’ve been fixing them all day yesterday.

A part of the comments i don’t understand yet so i ask if the colleage can watch with me and explain ehat how and why.

What does this nitpicker motherfucker do? Add more fucking comments to the PR and totally ignores my requests for explanation. Fucking anti social dick.

So I fix a bug and I create a PR, someone reviews it and leaves a couple of comments, I address those comments and push up my updated code thinking “great I should be ok to move onto this big story waiting for me”
Then some Expletive.random(); from a totally different team who has no context of my change comes in and starts leaving petty comments. He literally pointed out 3 different things that could be made private/package-private.
Bugger off and focus on your own team’s work instead of leaving comments about relatively trivial things on my PRs.
Apparently he is well known for this. I can tell we are gonna have some fun encounters...

when a senior and tech lead write conflicting PR comments ~1 week apart

i dont give a fuck, ill do it either way you want but you 2 need to sort out how the fuck you want it

I love when devs bitch about the size of PRs on a very standard sized one. They're all related changes that can't be broken up. Do you want the app to be broken between PRs? He spent more time bitching about the size of the diff and telling me how he does it better instead of just reviewing the code. A tip or an ask is one thing, this was a wall of text.

Oh and he still didn't approve the PR, which I know he looked at, and didn't leave any blocking comments.

A personal sad short story:

Pull request opened on 20 November 2020.
+1 -1

Descriptions: Fix xyz issue

Comments (12):
- User 1: When it will be merged? (December 2020)
- User 2: When it will be merged? (January 2021)
- User 3: When it will be merged? (February 2021)
- ...
- User 11: When it will be merged? (July 2021)

- Official team: Sorry for the time it took, watch the PR for any update on this. (July 2021)

Today, after 7 months, it's still not merged.
I love the open-source community.

Why comment on the same thing during code review??

I submitted a PR and had to make a design choice that propagated throughout the module i was working on.

During code review, my coworker commented on every...single...line that this change effected asking "why are we doing x here?" instead of just creating ONE SINGLE THREAD with this question for discussion. There were at least 10 review comments on github from their one review that said "why X?"

Is this normal? Ive only had a few programming jobs and this is the first time this has happened to me.

personally, when someone makes a choice like that, i just make a comment and save the rest of the review until that is addressed.

23 comments on a single PR.

Am I a nazi or a good tutor? I think so.

My colleagues: "We should fail for scalastyle issues! Warnings will get ignored! Nobody fixes them! We should enforce a clean code style!"

Also my colleagues: Create PR with loads of `// scalastyle:off` flags comments.

¯\_(ツ)_/¯

Hey, you, my new colleague, you are annoying. I have reviewed your PR and left about 50 comments on your mess. I even explained to you why half of your code is shit in a very polite way. I have explained why you have to rewrite that and even how to do that in the best way possible. Result? Half of the code is gone, it works as before but without the overhead.

Now you're annoying cuz I have to go again on conventions and best practices. I totally understand that you've been doing it differently and throwing buzz words at me won't help. Just stop and do it as it's needed in this project, don't reinvent the wheel only because you can.

You know what? Fuck it! I'll approve all your PRs, anyway I am leaving soon. There is no benefit for me to teach you stuff. You're one of those guys that I voted against in interviewing process. But guess what? My manager decided to hire you anyway! Ha! I rarely vote NO and you were a one of those...

Your confidence doesn't impress me. That works on people that have no clue on what you are doing. Your just average at best, not a superstar.

Fuck it, you're on your own now!

I don't get why this retard keeps ignoring my comments on a PR he asked me to review. He is a level above me so I can't push it. I just approve his PR and let him know I do so but with a comment. He then ignores the comments and merges his rubbish changes into the codebase thereby creating a tech debt.

Currently having a stupid fight in my PR comments to remove dead code because I refuse to write a whole book to justify a cleanup commit.

/me doing the 23rd revision of a PR because my colleague reviewing it comments on every imaginable way his opinion of code standards differ from mine:

git commit -m "."

> [PM from a totally different project / team comments on already-closed 10-line PR] How about we [add a totally new feature involving several engineer-weeks to patch over a fixable bug in another part of the system] instead?

> [me] we can talk about that, but it's nontrivial and we should scope any work relating to it to be sure we're doing the right thing

> [him] [starts private email chain] this should be simple. Why isn't this as simple as that other change?

> [me] [explains why]

> [him] I think it should be simple. We'll talk about it offline tomorrow and maybe you can do it next week.

My TL has his custom rules to format code, we use python and black as formatter, still, We have to remember his rules. He forced us to mention type rather than compiler do it for us. Our pr will not be approved until we do this.
My point is if you want to follow this then forced it programmatic way, event better use a language which gives this all by default. why we should remember all of these rules. Other team members are also doing the same and I hate those pr comments like there should be two empty lines or the type is missing. He never listens to any of us and takes it on his ego.

Apologies if this has been asked here before, but I wanted an open feedback on a query: Is there such a thing as overdocumenting?

I take pride in being a very articulate developer, being as descriptive as possible in my emails, internal communications, PR review comments, JIRA etc.

A product guy from the company today mentioned: "Though I understand your good intent behind being as descriptive as possible, it is possible that some of the junior engineers might get overwhelmed/ intimidated looking at those comments/ emails and it might stop them reaching out to you with your doubts."

I was not able to wrap my head around this, because I don't understand how a descriptive explanation might overwhelm anyone. It's a skill I picked up going through my career and I personally have always respected peers who documented things properly.

Open to feedback. Thank you in advance.

My best review was when i changed the code that someone suggested in another PR, which was highly critiqued by the OG devs. One pull to the latest commit and PR to his fork later, the OG dev comments "that looks good" and merges it.

Celebrated for sure that night. I've been hooked on contributions to open source ever since.

How to deal with "Code Nazis" ?

Don't know how you call this guys that see each and every PR as a possibility to annoy everyone else

Team of 4 Devs, all with lots of experience

But there is a special one, that spams each PR with an incredible amount of comments

Most of them are non-sense like "formatting of comments" or "inlining things makes everything unreadable" or "call this variable this and that" although a reasonable name was their

Rest of team including myself is pretty pissed of by him

How to get over that?

Purpose of Slack: communications (I suppose)

What management uses way too many channels for: updates of ANYTHING anyone does on Jira or any pull requests created on GitHub

What would be useful to get notifications of, such as PR comments, isn't there

I'd like to get notifications of when *people* talk to me, as I like to answer them promptly, but these stupid automated updates on Slack just makes me mute whatever channels they're setup in

How do you guys deal with PRs where things just don't go in and you're always making the same comments and suggestions?

We have a fairly experienced guy in the team who doesn't seem that familiar with the language (Kotlin), despite having now used it for almost a year. We're constantly making the same comments on code not using the correct syntax (basic things like val vs var) or following the style guide and after a lot of grumbling the changes are made, but the same issues are present in the next PR.

He also keeps doing things their own way, even if as a team we've reached consensus on a particular design pattern to follow, or way to solve a problem. When you mention this, you just get a "Hmm okay" but nothing changes. It's like things just go in one ear and out the other.

Even as the reviewer this is really frustrating and demoralising. PRs have loads of comments which makes you feel like you're being picky, and they take forever to get approved and merged.

I even often find myself effectively feeling bullied into approving once most of the main comments are addressed, because you're talking the brick wall that isn't yielding - and none of us are happy with the quality of the code going in. A couple of us are even starting to think "I'm just going to have to accept this and then fix it myself later", which is just not a healthy approach.

Now I'm blessed with an amazing manager who is well aware of the problem and knows from his own experience that this guy is genuinely problematic to work with. We're working towards a solution but I was wondering if anyone here has had a similar experience and how you worked towards solving it?

I'm a little at my wit's end :/

*click 'create pull request'*
*satisfied*
*pat on shoulder*

Will get comments surely, but I'm happy that I could make a PR

Very annoyed by PR comments for temporary fixes.

I made a one line change that basically removes a link from showing. Test it via UI and it worked 100%. Then a more senior engineer comes in and says to do it a different way that takes more time to get the hotfix out and 3 times the amount of files changed.

Why? What's the fucking point? It's a temporary fix that will be removed in a week. Why waste my time and your time? Now I'm wasting time on here.

Why do PMs always think that comments/commit messages > the actual code?

If I need to know why it's coded that way, I need to check the code.

I get you want to know what's going on, but seriously, don't make me rewrite the code in English. You already know the ticket it's for and have the summary as the PR message (especially for code that the character changes can be counted on 1 hand)

Full code base with 0 comments. Either it's utter genius or terribly poor.
And I'm sitting here reviewing a PR.

How does your organisation and team balance PR comments demanding changes and dev time?

Here, while fixing PR comments we sometimes end up wasting as much time as we took in actually developing the feature... As a result, almost every major user story overshoots the estimation and almost every sprint gets delayed.

Yes, to each his own; but talking in general, why do you think this time wasting happens?
Do you think that happens because some of us are not as experienced as the others, the existing code not being up to the mark giving a bad example, or just a skewed review process?

Anyone else get a lot of PR comments asking just to refactor variable names?

It's the worst! :/

Hell, I always thought I was a team player, but is it a great week being the sole developer (all the other on vacation). So I didn't get interrupted all the time, read overblown PR. Still, even in their absence I spent about three days fixing their build issues and PR's, but I could sit down and read the code, some documentation to get a better understanding why it all sucks and what we should do with our pain in the ass build system.
It's really a blast, deleting some stupid code, removing superfluous dependencies and above all leaving snarky remarks in the commit messages and code comments. Just letting some steam off. Code is where my devrant is.

When averaging 3 or more comments per PR