My "Coding Standards" for my dev team

1.) Every developer thinks or have thought their shit don't stink. If you think you have the best code, submit it to your peers for review. The results may surprise you.

2.) It doesn't matter if you've been working here for a day or ten years. Everyone's input is valuable. I don't care if you're the best damn programmer. If you ever pull rank or seniority on someone who is trying to help, even if it isn't necessarily valid or helpful, please have your resume ready to work elsewhere.

3.) Every language is great and every language sucks in their own ways. We don't have time for a measuring contest. The only time a language debate should arise is for the goal of finding the right one for the project at hand.

4.) Comment your code. We don't have time to investigate what the structure and purpose of your code is when we need to extend upon it.

5.) If you use someone else's work, give them the credit in your comments. Plagiarism will not be tolerated.

6.) If you use flash, you will be taken out back and shot. If you survive, you will be shot again.

7.) If you load jQuery for the sole purpose of writing a simple function, #6 applies.

8.) Unless it is an actual picture, there is little to no reason for not utilizing CSS. That's what it's there for.

9.) We don't support any version of Internet Explorer and Edge other than the latest versions, and only layout/alignment fixes will be bothered with.

10.) If you are struggling with a task, reach out. While you should be able to work independently, it doesn't make sense to waste your time and everyone else's to not seek assistance when needed.

11.) I'm serious about #6 and #7. Don't do it.

Received "emergency update" code from internal enterprise security team. Wasn't given time to do code review; was assured code was reviewed and solid.

Pushed code to over 6k lower-level servers before finding this gem buried deep within:
...
cd /foo; rm -rf *; cd /
...

(This ran as root, and yes, the cwd was / from earlier in the code).

/foo, of course, did not exist on some servers.

Now, it is those servers which do not exist.

FML

Dev: what do I call this file ?
Me: just name it something meaningful so other dev's know what it is

Two days pass

Me: time to do code review .. oh look a new file ..

Git comment : new file for sax parsing , architecture gave the ok.

File name : SomethingMeaningful.java

Wholesome anti-rant.

There’s this Indian chick at work that I really, really do not get along with. Fortunately she’s on a different team so we have practically zero interactions. Her code was always decent, maybe upper junior level? but I went away fuming almost every time we talked.

However, I did a release security review today (I’m down from five/six per month to one) and read through quite a bit of her code. It was clean and easy to read with good separation, clear naming and intentions, nothing was confusing, etc. It was almost beautiful. Had I any emotions I might have shed a tear. I sent her a message and let her know :) I actually learned a better way of doing a couple of things from it.

She has grown so much as a dev.

So i've been a dev manager for a little while now. Thought i'd take some time to disambiguate some job titles to let everyone know what they might be in for when joining / moving around a big org.

Title: Senior Software Engineer

Background:
- Technical
- Clever
- Typically has years experience building what management are trying to build

Responsibilities:
- Building new features
- Writing code
- Code review
- Offering advice to product manag......OH NO YOU DON'T CODE MONKEY, BACK TO WORK!

Title: Dev Manager

Background:
- Technical
- Former/current programmer
- knows his/her way around a codebase.

Responsibilities:
- Recruiting / interviewing new staff
- Keeping the team focused and delivering tasks
- Architecture decisions
- Lying about complexity of architecture decisions to ensure team gets the actual time they need
- Lying about feature estimations to ensure team gets to work on critical technical improvements that were cancelled / de-prioritised
- Explaining to hire-ups why we can't "Just do it quicker"
- Explaining to senior engineers why the product manager declined their meeting request

Title: Product / Product Manager

Background:
- Nothing relevant to the industry or product line what so ever
- Found the correct building on the day of the interview
- Has once opened an Excel spreadsheet and successfully saved it to a desktop

Responsibilities:
- Making every key decision about every feature available in the app
- Learning to ignore that inner voice we like to call "Common sense"
- Making sure to not accidentally take some advice from technical staff
- Raising the blood pressure of everyone below them / working with them

Title: Program Lead / Product Owner

Background:
- Capable of speech
- Aware of what a computer is (optional)

Responsibilities:
- Sitting down
- Talking
- Clicking random buttons on Jira
- Making bullet point lists

Title: Director of Software Engineering

Background:
- Allegedly attended college/university to study computer science
- Similar to a technical product manager (technical optional)

Responsibilities:
- Reports directly to VP
- Fixes problems by creating a different problem somewhere else as a distraction
- Claiming to understand and green light technical decisions, while having already agreed with product that it will never happen

Is this the code life
Another scrum meeting
Caught in the the Node life
No escape from reality
Open your eyes
Look up to the screens and see..
I'm just a dev boy
Doing some debugging
Because there's warnings here
Errors there
Segment faults
Everywhere
Anytime you distract
Takes another hour from me
From me

*piano starts

Mama. Just committed a bug
Merge the branch to production
Did it fast for milestones
Mama. The repo has just begun
But now they going to throw the stack away.
Mama. U u u uu
Didn't mean to code in LAMP
But it's the only stack i know how to setup
In Ubuntu. Without docker
I really don't get vagrant

*piano

It's too late
My team is done
Some dev is working in Nepal
A UX dev. Now what is that?
Goodbye everybody
I've got to go
Gotta leave this lame meeting
And face the truth
Oh nooooo. I i interns
(they have questions)
I want to debug
I don't want to stay till 3 in the morning

*epic guitar

I see a litlle dev over there
Let's code review, let's code review
Did he do the last commit?
Coding in the white board
Very very frightening me
That's bug(that's a bug)
That's a bug (that's a bug)
What the f*ck did you do that?
Magnificcooooooo

I was just coding and nobody liked it
He was coding and nobody liked it, spare his some time to do his debugging

Easy man. Here go. Will you let me code?
A meeting. No,we will not let you code. ( let me code)
A meeting. we will not let you code. ( let me code)
A meeting. we will not let you code. ( let me code)
We will not let you code
Never never let you go
Never let you code, oh
No no no no no no no
Oh mama mia, mama mia ( dude, you've gotta let me code)
Screw you guys, I'm gonna code and commit. Commit. Comiiiiitt!

*epic guitar

So you think you can review me and spit in my eye?
So you think you can dump me and erase my branch?
Oh baby, cant do this to me baby
I've just have to log out.
I've just have to log outta here

*epic guitar solo

Nothing really matters
The users will not care
Nothing really matters
To them

Any way this code blows

My linkedin profile = ~7 years as an iOS developer. All of my job titles are "iOS Developer", "iOS Engineer" or "Mobile lead".

Recruiter: Hi, your profile looks great, I have a number of open roles matching your skills. Would you be free for a call to discuss your salary expectations, skills, what you are looking for etc.

Me: Hi, sorry I don't have time for a call right now, here are answers to your questions. Can you send me on any iOS job specs you have and i'll review. <answers>

Recruiter: Sorry I have no open iOS roles at this time.

Bitch ... ima find you and make you understand

GUESS WHAT? HE WANTS ANOTHER FUCKING FEATURE!

AND WHEN I SAID I DIDN’T HAVE TIME BECAUSE CODE-COMPLETE IS TOMORROW, HE SAID HE’LL PUNT IT TO NEXT YEAR INSTEAD OF RELEASING IT THIS WEEK SO I CAN “BUILD IT RIGHT.” MAN, FUCK YOU AND YOUR ENDLESS CHANGES!

THIS WAS GOING TO BE A TWO WEEK TICKET UNTIL HE STARTED ADDING ENDLESS FEATURES AND CHANGES AND SURPRISES. IT’S BEEN FUCKING MONTHS! I AM SICK OF THIS SHIT!

ANSDFKAWHOALIKWEGJFADIO;UGJT;

There goes my Q4 performance review.
> “Accomplishments? Oh, there’s lots of room here. Accomplished: Basically nothing. How embarrassing.”

Hate hate hate hate hate hate hate

One week, and it turned out to be worse than that.

I was put on a project for a COVID-19 program in America (The CARES Act). The financial team came to us on Monday morning and said they need to give away a couple thousand dollars.

No big deal. All they wanted was a single form that people could submit with some critical info. Didn't need a login/ registration flow or anything. You could have basically used Google Forms for this project.

The project landed in my lap just before lunch on Monday morning. I was a junior in a team with a senior and another junior on standby. It was going to go live the next Monday.

The scope of the project made it seem like the one week deadline wasn't too awful. We just had to send some high priority emails to get some prod servers and app keys and we were fine.

Now is the time where I pause the rant to express to you just how fine we were decidedly **not**: we were not fine.

Tuesday rolls around and what a bad Tuesday it was. It was the first of many requirement changes. There was going to need to be a review process. Instead of the team just reading submissions from the site, they needed accept and reject buttons. They needed a way to deny people for specific reasons. Meaning the employee dashboard just got a little more complicated.

Wednesday came around and yeah, we need a registration and login flow. Yikes.

Thursday came and the couple-thousand dollars turned into a tens of millions. The amount of users we expected just blew up.

Friday, and they needed a way for users to edit their submissions and re-submit if they were rejected. And we needed to send out emails for the status of their applications.

Every day, a new meeting. Every meeting, new requirements that were devastating given our timeframe.

We put in overtime. Came in on the weekend. And by Monday, we had a form that users could submit and a registration/ login flow. No reviewer dashboard. We figured we could take in user input on time and then finish the dashboard later.

Well, financial team has some qualms. They wanted a more complicated review process. They wanted roles; managers assign to assistants. Assistants review assigned items.

The deadline that we worked so hard on whizzed by without so much as a thought, much less the funeral it deserved.

Then, they wanted multiple people to review an application before it was final. Then, they needed different landing pages for a few more departments to be able to review different steps of the applications.

Ended up going live on Friday, close to a month after that faithful Monday which disrupted everything else I was working on, effective immediately.

I don't know why, but we always go live on a Friday for some reason. It must be some sort of conspiracy to force overtime out of our managers. I'm baffled.

But I worked support after the launch.

And there's a funny story about support too: we were asked to create a "submit an issue" form. Me and the other junior worked on it on a wednesday three weeks into the project. Finished it. And the next day it was scrapped and moved to another service we already had running. Poor management like that plagued the project and worked in tandem with the dynamic and ridiculous requirements to make this project hell.

Back to support.

Phone calls give me bad anxiety. But Friday, just before lunch, I was put on the support team. Sure, we have a department that makes calls and deal with users. But they can't be trained on this program: it didn't exist just a month ago, and three days ago it worked differently (the slippery requirements never stopped).

So all of Friday and then all of Saturday and all of Monday (...) I had extended panic attacks calling hundreds of people. And the team that was calling people was only two people. We had over 400 tickets in the first two days.

And fuck me, stupid me, for doing a good job. Because I was put on the call team for **another** COVID project afterwards. I knew nothing about this project. I have hated my job recently. But I'm a junior. What am I gonna say, no?

Second semester

Java - OOP Course

We had to write a game, an arkanoid clone

Neat shit

And a fun course, mad respect to the Prof.

BUT

Most students, including me had this ONE bug where the ball would randomly go out of the wall boundaries for no clear reason.

A month passed, sleepless nights, no traces.

Two months later. Same shit. Grades going down (HW grades) because it became more and more common, yet impossible to track down.

3 months later, we had to submit the HW for the last time which included features like custom level sets, custom blocks and custom layouts.

So before we submit the game for review, they had pre-defined level sets that we had to include for testing sake.

I loaded that.

The bug is back.

But

REPRODUCIBLE.

OMG.

So I started setting up breakpoints.

And guess what the issue was.

FLOATING FUCKING POINT NUMBERS

(Basically the calculations were not as expected)

Changing to Ints did it's job and the bug was officially terminated.

Most satisfying night yet.

Always check your float number calculations as it's never always what you expect.

Lesson learned, use Ints whenever possible.

Every time you squash a bug before someone else even sees it...

Lead: "There's a bug, you fix"
Me: "The PR for that has been waiting for your review since yesterday..."

That's it. I fucking quit.

Over a month of unpaid work, developing your stupid course, only to get a high-quality outline rejected because "it's not what we wanted" again.

First outline, fuckers ask to do something with a Raspberry Pi and Yocto. Fine, but no Yocto as I don't know anything about it and the coworker doesn't even have a Raspberry Pi to flash the images on. Micromanagement guy (god I hate that word) agrees, fine no Yocto then. So no Yocto it is.
2 weeks later... Course outline is finished. Review stage.. rejected. Needs moar Yocto.
Fine... I'll include Yocto. Coworker was put off the course, I'm exclusively on it now. Time to do it well and get my feet wet with Yocto.
2 weeks later... Course outline is finished and looks pretty good. Review stage.. rejected. Needs less Raspberry Pi. Do it without the Raspberry Pi.

An embedded systems course whose core component is that fucking Raspberry Pi. Omit it they said. WHAT?!!
"Oh yeah but there's this other course that's selling like hot pockets, we can just redo that in videos. Make it more like that course."
You.. you can't be for real, can you? If students want to take that course... What makes you think that they wouldn't just pick.. *that damn course* then?

"But hey" micromanager said, "don't loose hope and confidence, I'm here🤪"
🤪. That describes your level of competence pretty well, you stinking piece of apeshit.
Go back to your micromanaging, at least you don't completely fucking suck at that.

2 times rejected because YOU fucking company's board can't describe your desires in a course properly. You know what, I think I'm starting to understand why web devs keep on complaining about indecisive clients now. Because you know company's board, you seem a lot like those clients from hell. Eat shit.

🖕

Well, after lurking in the dark for years, I finally created an account just so I could downvote a certain security related post.
However, I am lacking the necessary ++.
So a "hello, world!" with a sprinkle of rant it is:

Be me:
Show WIP Feature, state that it will be probably done by tomorrow, excluding time for peer review
Be my PM:
"Can we release this today?"

This happend so often that "Can we release this yesterday?" became a common phrase among my coworkers and me if someone is ranting about something broken in their feature. Probably gonna try using it here as well :D

Senior architect-type person at work wants me to review some code he's written. Is it on GitHub/Gitlab/Bitbucket etc? Nope. "Here, I've printed it out for you. " 😂

When was the last time you printed code out? Also it's in black and white, times new roman😱💀

Reviewing coworker's code:

Me: I see you're doing a convoluted sort for every element twice to get your two lists in sync... 😐
CoWorker: Yeah. *straight face, no regrets* That's the only way to do this.
Me:... Uh... No? You can just manage one list with a simple struct and then use the the standard sort.
Coworker: Yeah sure I know. But it'll take time. We don't have time.
Me: *aghast* This is embarrassingly bad code!
Coworker: Don't worry, later on I'll use a hashmap for it. But this needs to be pushed now.
Me: *to myself, no you don't need a hashmap*
Okay, you do you but I can't back you on this. It isn't going to take a lot of time to correct it.

Next day.
Coworker: Hey can you review my code again?
Me: You've made the changes already? *in a bored tone, knowing that they wouldn't have changed shit*
Coworker: No this is a different file. Our manager agrees that we can worry about performance later.
Me: Sure. *😀🔨🔨*

Few weeks pass by:
QA: The operation takes absurdly long time to complete even with the smallest data. Ten minutes for X is unacceptable.
Me: Who would've known? ☺️

Them: Root, you take too long to get tickets out. You only have a few simple ones. You really need to rebuild your reputation.

Also them: Hey, could you revisit this ticket? Could you help ____ with this other ticket? Hey Root, how do you do this? Root, someone had a suggestion on one of your tickets; could you implement that by EoD? Hey Root, i didn't read your ticket notes; how do you test it? Hey, could you revisit this ticket for the fourth time and remove some whitespace? Hey Root, someone has non-blocking code review comments you need to address before we can release the ticket. Hey Root, we want to expand that ticket scope by 5-6 times; still labeled a trivial feature though.

Also them: Super easy ticket for you. Make sure you talk with teams A, B, C, D, E and get their input on the ticket, talk with ____ and ____ and ____ about it, find a solution that makes them all happy and solves the problem too, then be sure to demo it with everyone afterward. Super easy; shouldn't take you more than a couple days. Oh, and half of them are on vacation.

Also them: Hey, that high-priority ticket you finished months ago that we ignored? Yeah, you need to rewrite it by tomorrow. Also, you need to demo it with our guy in India, who's also on vacation. Yes, tomorrow is the last day. (The next day:) You rewrote it, but weren't able to schedule the demo? Now you've missed the release! It's even later! This reflects very poorly on you.

Also them: Perfect is the enemy of good; be more like the seniors who release partially-broken code quickly.

Also them: Here's an non-trivial extreme edgecase you might not have covered. Oh, it would have taken too much time and that's why you didn't do it? Jeez, how can you release such incomplete code?

Also them: Yeah, that ticket sat in code review for five months because we didn't know it was high-priority, despite you telling us. It's still kinda your fault, though.

Also them: You need to analyze traffic data to find patterns and figure out why this problem is happening. I know you pushed the fix for it 8 months ago, and I said it was really solid, but the code is too complex so I won't release it. Yeah I know it's just a debounce with status polling and retrying. Too complex for me to understand. Figure out what the problem is, see if another company has this same problem, and how they fixed it.

-------------

Yep. I'm so terrible for not getting these tickets out, like wow. Worst dev ever. Much shame.

LF work, PST.

Going to do this the next time I review a frontend PR 😂

Best "error" I've ever seen today.

We have a very large database with millions of people, some of those records are duplicates. So I had a long project to write something that would automatically merge duplicate records while allowing employees to review them. Today we had a duplicate show up in the list which should not have.

Same name (apart from one letter), address, employee ID (off by 1 number), same manager, title, phone number, birthdate. But we figured out it wasn't the same person and therefore wasn't a good match.

Turns out they are twin sisters who live together and we're hired by the same manager for the same position at the same time. What are the odds...

So this chick has been super nice to me for the past few months, and has been trying to push me towards a role in security. She said nothing but wonderful things about it. It’s easy, it’s not much work, it’s relaxing, etc.

I eventually decided I’m burned out enough that something, anything different would be good, and went for it. I’m now officially doing both dev and security. The day I started, she announced that she was leaving the security team and wouldn’t join any other calls. Just flat-out left.

She trained me on doing a security review of this release, which basically amounted to a zoom call where I did all of the work and she directed me on what to do next, ignored everything I said, and treated me like an idiot. It’s apparently an easy release. The work itself? Not difficult, but it’s very involved, very time consuming, and requires a lot of paper trail — copying the same crap to three different places, tagging lots of people, copying their responses and pasting them elsewhere, filing tickets, linking tickets, copying info back and forth to slack, signing off on things, tagging tickets in a specific way, writing up security notes in a very specific format etc. etc. etc. It’s apparently usually very hectic with lots of last-minute changes, devs who simply ignore security requests, etc.

I asked her at the end for a quick writeup because I’m not going to remember everything and we didn’t cover everything that might happen.

Her response: Just remember what you did here, and do it again!

I asked again for her to write up some notes. She said “I would recommend.. you watch the new release’s channel starting Thursday, and then review what we did here, and just do all that again. Oh, and if you have any questions, talk to <security boss> so you get in the habit of asking him instead of me. Okay, bye!”

Fucking what.
No handoff doc?
Not willing to answer questions after a day and a half of training?

A recap
• She was friendly.
• She pushed me towards security.
• She said the security role was easy and laid-back.
• I eventually accepted.
• She quit the same day.
• The “easy release” took a day and a half of work with her watching, and it has a two-day deadline.
• She treated (and still treats) me like a burden and ignores everything I said or asked.
• The work is anything but laid-back.
• She refuses to spend any extra time on this or write up any notes.
• She refuses to answer any further questions because (quote) “I should get in the habit of asking <security boss> instead of her”

So she smiled, lied, and stabbed me in the back. Now she’s treating me like an annoyance she just wants to go away.

I get that she’s burned out from this, but still, what a fucking bitch. I almost can’t believe she’s acting this way, but I’ve grown to expect it from everyone.

But hey, at least I’m doing something different now, which is what I wanted. The speed at which she showed her true colors, though, holy shit.

“I’m more of a personal motivator than anything,” she says, “and I’m first and foremost a supporter of women developers!” Exactly wrong, every single word of it.

God I hate people like this.

Bittersweet moment today, the interns last day was today, the improvements they made over the last 4 months, putting up with my “Gordon Ramsey” style attitude... definitely goes down in the books as one of best groups of freshman interns. They all truly thanked me for what they learned I sat them down and did a code review with them... but fooled them and showed them code they wrote 4 months ago.. they totally forgot about.. and couldn’t believe it was their own code.. that’s the level professionalism and improvement they made writing embedded software in 4 months.. they can’t wait to for next summer, neither can I.
Even had some of the electrical interns asking our department manager if they could switch to more software focused during their next rotation. Just so they can be under me.
I may be hard and a dick at time... but they learn! And it says a lot when you have college students impacted enough and see other students benefit so much that the “outsiders” wanna switch majors or focuses.!

Dude, for the hundredth time, stop leaving random chunks of commented out code all over the place in case we "need to find it easily later"...

This is literally the reason we use git.

No, I will not pass it in a code review. The same as last time. And the time before...

Dahhhhh

My code review nightmare part 3

Performed a review on/against a workplace 'nemesis'. I didn't follow the department standards document (cause I could care less about spacing, sorted usings, etc) and identified over 80 bugs, logic errors, n+1 patterns, memory leaks (yes, even in .net devs can cause em'), and general bad behavior (ex.'eating' exceptions that should be handled or at least logged)

Because 'Jeff' was considered a golden child (that's another long TL;DR), his boss and others took a major offense and demanded I justify my review, item by item.

About 2 hours into the meeting, our department mgr realized embarrassing Jeff any further wasn't doing anyone any good and decided to take matters into his own hands. Thinking 'well, its about time he did his job', I go back to my desk. About an hour later..
Mgr: "I need you in the conference room, RIGHT NOW!"
<oh crap>
Mgr: "I spoke to Jeff and I think I know what the problem is. Did you ever train him on any of the problems you identified in the review?"
Me: "Um, no. Why would I?"
Mgr: "Ha!..I was right. So lets agree the problems are partially your fault, OK?"
Me: "Finding the bugs in his code is somehow my fault?"
Mgr: "Yes! For example, the n+1 problem in using the WCF service, you never trained him on how to use the service. You wrote the service, correct?"
Me: "Yes, but it's not my job to teach him how to write C#. I documented the process and have examples in the document to avoid n+1. All he had to do was copy/paste."
Mgr: "But you never sat with Jeff and talked to him like a human being? You sit over there in your silo and are oblivious to the problems you cause. This ends today!"
Me: "What the...I have no idea what you are talking about. What in the world did Jeff tell you?"
Mgr: "He told me enough and I'm putting an end to it. I want a compressive training class developed on how to use your service. I'll give you a month to get your act together and properly train these developers."

3 days later, I submit the power-point presentation and accompanying docs. It was only one WCF with a handful of methods. Mgr approved the training, etc..etc. execute the 'training', and Jeff submits a code review a couple of weeks later. From over 80 issues to around 50. The poop hits the fan again.

Mgr: "What's your problem? When are you going to take your responsibility seriously?"
Me: "Its pretty clear I don't have the problem. All the review items were also verified by other devs. Its not me trying to be an asshole."
Mgr: "Enough with the excuses. If you think you can do a better job *you* make the code changes and submit them for Jeff for review. No More Excuses!"

Couple of days later, I make the changes, submit them for review, and Jeff really couldn't say too much other than "I don't see this as an improvement"

TL;DR, I had been tracking the errors generated by the site due to the bugs prior to my changes. After deployment, # of errors went from thousands per hour to maybe hundreds per day (that's another story) and the site saw significant performance increases, fewer customer complaints, etc..etc.

At a company event, the department VP hands out special recognition awards:

VP: "This award is especially well earned. Not only does this individual exemplify the company's focus on teamwork, he also went above and beyond the call of duty to serve our customers. Jeff, come on up and get this well deserved award."

Are you done yet?
Is it ready for review ?
How far?
Any updates?
When can I check?
We are wasting time..
How long will it take ?
Are you saying this will take 2 days to complete?
😪😪😪
Pls raise a cup with me if you can relate.
Add yours too.

*Programers can't spell*

In a previous job, I once spelled inquiries as enquiries. It was a service and it was used in many places throughout the app. Somehow, it made it through peer review and even my teammates started using the misspelled word.

I didn't realize my mistake till months later and by that time I thought it was too much work to fix it (or I was too lazy).

I'm pretty sure we even misspelled it for the on-screen texts.

Moral of the Story: know how to spell shit

Yesterday I had my performance review discussion with my manager after about 6 months into the job, which is my first dev job. Before this, I had spent about 2 years in a support role after graduation, but always yearned to build something cool and be a full time developer. Hence I had made the lunge in spite of a pay cut into a development role.

For the past 6 months I was asked to develop a bunch of features on top of legacy code which is ~15 years old. I did my best and brought in the best ideas and practices onto the table and delivered on time. The features turned out great. I enjoyed working with the team and the team loved me back!

But at the back of my mind, I was hoping that I would get to work on something new and relevant. To quench this thirst, I used to spend my personal time on side projects.

The managers and the leads who have been observing me all along, told me yesterday that my manager got AMAZINGLY positive feedback from the leads and my teammates (who are like 10 years senior to me). Going forward, I get to work on any CRAZY idea and pick up any technology I like with the goal of revamping our product. Essentially I get to work on my side projects full time as long as it adds value to the company.

Ohhhhhh YEAH!

Wish me luck. 😎

TL;DR, employers are often penny wise and pound foolish.

One morning, my vehicle had a potentially life-threatening condition that I needed fixed before I could drive to work. I was 3 hours late but made a productive day of it. Plus I had stayed late after work, for no pay, a couple of nights because I have the kind of work ethic that compels me to do weird stuff like that occasionally.

When the time clock report came out it showed I was 3 hours short for the pay period. I brought up that I had "paid it forward" a few weeks prior and asked for an exception based on that. I was told that a) all "extra" work had to have been approved prior to doing it and b) that pay period had already passed, so no, I'd need to make up the hours. Being pretty miffed at being so nickled-and-dimed, and for being expected to drive to work in spite of the possibility of losing my life, I just had them take it out of my time off.

Fast forward to my latest monthly review: After another potentially life-threatening vehicle breakdown and fix, I decided to ask whether I could have a couple of telecommute days per week to offset fuel and mileage to recover the repair cost for the wear and tear on my vehicle. The answer was "No, because then everyone will want to work from home and then we'd have no way to know if they're really working."

On that same day I got an offer for doing the same job at another company for 100% telecommute and at nearly twice the salary. I turned in my resignation two days later. Now they're scrambling to try to replace me.

Adventures in security land.

The “legendary” lead dev authored a ticket that logs raw credentials for a third-party tool we’re using, and logs partially-obscured consumer passwords. His reasoning: “for debugging. And customer service!” And then argued with me over why that’s bad! Seriously?

Then in the release channel, he and the release manager are talking like I’m pestering them with my findings. Things like “I have some Root-induced changes coming” and “Fixed those, but she’ll probably have more...” etc.

Like come on.
I’m even being nice here, but you seriously need to stop screwing this up.

They also didn’t bother merging the fixes into the release branch, so I needed to re-review the entire (large) ticket on its own branch. Doubles the effort since I can’t easily see what changed.

The lead dev also only updated a few of the specs (despite me sending him a list), so there’s a bunch of failing ones now. Makes me unsure if he actually fixed everything.

Maybe I’m just being touchy, but ugh. Freaking annoying people.

At least he owned up to being the author this time instead of saying someone else (who wasn’t in the history...) wrote it. -.-

I shall refer to the client as cunt for the purposes of this rant. All design work signed off. Near completion of project, cunt sends an email moving stuff around and changing the design. I send the cunt an email telling him that I will review his requests and send a quote through detailing cost implications and extra time added to his deadline to complete. Cunt says he wasn't aware there would be extra costs. I refer the cunt back to the quote and contract which clearly distinguishes the design phase and build phase explaining change control. Not heard back from said cunt.

This review.... it hurt me and made me laugh at the same time.

I dont even know anymore.

Once, I overheard a conversation between my former PM and a client during a phone call.

Client: I will send the final draft of the project by Thursday.

PM: That's great to hear!

Client: When can I expect the updates to review the changes after the draft is sent? I need to present it at a meeting this weekend.

PM: It should be ready by Friday without fail!

Client: Excellent! Thank you. I will be expecting it.

PM: Sure, goodbye.

(After the call, PM joined the team.)

PM: So, team, the client for Project-A will be sending us a new draft for review and updates. They are putting a lot of pressure on us and need it to be ready by Friday at the latest. We need to treat this with a sense of urgency.

(After hearing this, we felt compelled to respond.)

Me: There's no way they would expect us to deliver an unseen draft within a day. Both the backend and Figma team members were forced to work last weekend, on Saturday, because you mentioned that Project B was behind schedule and the client needed an update by Monday. We simply can't continue working like this.

Backend guy 2: I also worked last Sunday on Project B.

Me: We overheard you telling the client that they should expect an update by Friday. It seems like you're the one directly putting the team under pressure, even though we still have three ongoing projects with tight deadlines.

(The office fell into an uncomfortable silence.)
(PM left the office without saying a word.)

Later on, I heard that he contacted the client to reschedule the expected time of arrival (ETA) after receiving the draft.

{Context: English is not my native language}

The first time my code get a review ( by my boss that time)

Boss: Your code is full of butts 🍑

Me: Eh, What?

Boss: *showing his screen* see that? variables names: validateButt, contactButt, seeMoreButt..

Me: *interrupting him* oh, I mean button.

Boss: I know, just being sarcastic, but it'll be better to get another suffix.

Me: 😐

I've this review with this awesome super senior developer​ in about an hour.

I've been preparing for this for months. Now he's going to review my idea which I have documented for 8 fricking pages. It's my first major presentation after I got promoted a few months ago. So, the expectations are high.

I'm super nervous and it's starting to get really cold in here. I think I'm about to retch and poop at the same time.

*internal screaming*

If I don't come back alive, one of you guys find me a husband and tell him I loved him!

*internal screaming continues*

So I took on a fairly big project and poured my heart and soul into it, was the biggest thing I did yet. I kept on sending beta's to the customer after each change for review! Kept on insisting that they review it, the answer was always "this looks amazing keep doing what you're doing"! After I finished and pushed everything to production.

They didn't use it for nearly 6 months! And then out of the blue they call me saying that half of the app is wrong.. WTF? Where was this information during testing! I informed them that the changes would take some time since I need to do migrations and change the whole database schema.

In which they replied "but you already finished it once won't changing things make it easier? We shouldn't pay for your mistakes"
I don't know how I handled that but they should be thankful they were half way across the country 😠😠😠😠

Adventures in security land, part II:

I’m getting pulled off the security review team and instead relegated to part-time security tickets alongside my usual dev work. (So, someone else finds them, i fix them.)

Guess I found and debated too many problems with the lead dev’s code. 🙄

Me: well guys, after the 4th attempt and a week of waiting, I’ve gotten a response from the remote backend team about the errors affecting this release. Which are the same issues affecting the last release 2 months ago. The findings are: “there is in fact some issue with the API”.

I’d like to thank everyone who put in so much effort to get us to this momentous step forward. We can expect a fix any year now.

*equally sarcastic colleague on another team listening in*:
oh wow, this months long thing has just been “some issue” all this time? Well that’s fantastic. You should mark the ticket as “done” and reply “thank you” for all their hard work.

..... I laughed so hard at how ridiculous all this is and the joke, that I nearly did, hoping someone from product/business would have to review it

Worst code review experience?

Hard to pick just one, but most were in a big meeting room with 4+ other developers not related to the project and with some playing Monday-Morning-Quarterback instead of offering productive feedback.

In one code review, the department mgr reviewed the code from a third party component library.

<brings up the code on the big screen>
Mgr: "I can't read any of this, its a mix of English and something else."
Me: "Its German."
Mgr: "Then why is 'Button' in English? This code is a mess."
Me: "I'm not exactly sure how I should respond, I mean, I didn't write any of this code."
Mgr: "Yes, but you are using it, so it's fair game for a code review."
Me: "Its not really open source, but we can make requests if you found something that needs to be addressed."
Mgr: "Oh yes, all this...whatever this is..<pointing again to the German>"
Me: "I don't think they will change their code to English just so you can read it."
Mgr: "We paid good money, you bet your ass they'll change it!"
Me: "I think the components were like $30 for the unlimited license. They'll tell us to go to hell first. Is there something about my code you want to talk about?"
Mgr: "<Ugggh>...I guess not, I couldn't get past all that German. Why didn't we go with an American company? Hell, why didn't we just write these components ourselves!?"
Me: "Because you gave a directive that if we found components that saved us time, to put in a request, and you approved the request. The company is American, they probably outsourced or hired German developers. I don't know and not sure why we care."
Mgr: "Security! What if they are sending keystrokes back to their servers!"
Me: "Did you see any http or any network access?"
Mgr: "How could I? The code is in German!"
Monday-Morning-Quarterback1: "If it were me, I would have written the components myself and moved on"
Me: "No, I don't think you could for less than $30"
Monday-Morning-Quarterback2: "Meh...we get paid anyway. Just add the time to the estimate."
Mgr: "Exactly! Why do we even have developers who can't read this mess."
Me: "Oh good Lord! Did anyone review or even look at my code for this review!?"
<silence>
Mgr: "Oh...ok...I guess we're done here. Thanks everyone."
<everyone starts to leave>
Me: "Whoa!...wait a sec..am I supposed to do something?"
Mgr: "Get that company to write their code in English so we can read it. You have their number, call em'...no...wait...give me their number. You keep working, I'll take care of this personally"

In they nicest way possible, the company did tell him to go to hell.

It was 1999. I was just starting my first real job as a programmer for a major insurance company. We were working on code that would screen scrape legacy mainframe data output and convert it to a web-based UI. REALLY stupid project approach I had no input on. I happened to find a programmer in Germany who had released his code in the public domain that would help with making a certain conversion task easier. I downloaded his code and put it to work.

During a code review, a programmer who was probably about 60 asked me where I got the code and what it was doing. I didn't even get to the part about what it was doing because he made fun of me so badly, in a fake German accent in front of a room full of non-programmers, for using code that today is no big deal due to the prevalence of open source. I just clammed up in humiliation because he got everyone laughing at me. His philosophy was if we didn't buy it or write it ourselves, we had no business using it.

I guess I was just ahead of my time?

!rant
Observed a full deployment the other day and discovered it's extremely inefficient. I proposed an idea to fix it, and was shot down by a senior dev on the team. I was ranting about how asinine the process was and how my process could reduce the amount of time and training required to do deployments with out any additional cost or overhead. A senior dev from another department over heard me, found my workspace and told me (in a nutshell), "write up a document about why the current process is garbage and how yours is better, and how it works, I'll review it and we'll get it worded and formatted right. When we finish the document, I'll forward it to the CTO of your department with your name on it and my recommendation for review." Fuck yeah. 😈😎

it's time to review your concepts!!! lol

My code review nightmare part 2

Team responsible for code 'quality' dictated in their 18+ page coding standard document that all the references in the 'using' block be sorted alphabetically. Easy enough in Visual Studio with the right-click -> 'Remove and Sort Usings', so I thought.

Called into a conference room with other devs and the area manager (because 'Toby' needed an audience) focusing on my lack of code quality and not adhering to the coding standard.

The numerous files in question were unit tests files

using Microsoft.VisualStudio.TestTools.UnitTesting;
using System.Collections.Generic;
using System.Linq;
<the rest of the usings>

T: "As you can see, none of these files' usings are in alphabetical order"
Me: "Um, I think they are. M comes before S"
T: "The standards clearly dictate system level references are to be sorted first."
Mgr: "Yes, why didn't you sort before checking this code in? T couldn't have made the standards any easier to follow. All you had to do is right-click and sort."
Me: "I did. M comes before S."
T: "No You Didn't! That is not a system reference!"
Me: "I disagree. MSTest references are considered a system level reference, but whatever, I'll move that one line if it upsets you that much."
Mgr: "OK smartass, that's enough disrespect. Just follow the fucking standard."
T: "And learn to sort. It's easy. You should have learned that in college"
<Mgr and T have a laugh>
Me: "Are all your unit tests up to standard? I mean, are the usings sorted correctly?"
T:"Um..well..of course they are!"
Me: "Lets take a look."

I had no idea, a sorted usings seems like a detail no one cares about that much and something people do when bored. I navigate to project I knew T was working on and found nearly all the file's usings weren't sorted. I pick on one..

using NUnit;
using Microsoft.Something.Other;
using System;
<the rest of the usings>

Me: "These aren't sorted..."
T: "Uh..um...hey...this file is sorted. N comes before M!"
Me: "Say that again. A little louder please."
Mgr: "NUnit is a system level nuget package. It's fine. We're not wasting time fixing some bug in how Visual Studio sorts"
Me: "Bug? What?..wait...and having me update 10 or so files isn't a waste of time?"
Mgr: "No! Coding standards are never a waste of time! We're done here. This meeting is to review your code and not T's. Fix your bugs and re-submit the code for review..today!"

Today I decided to quit my job. Yesterday I had my yearly review couldn't be more perfect, I did everything they asked me for and more (help with recruitment, animate conferences, work very late a lot of time, work during my vacation days...) yet to be surprised that I will only have 3% raise (on a low salary). I feel not valued and I was very disappointed :(

Each and every time when my manager review my code..... :-[

What a time to be alive...

To Managers: If your developers are suddenly so unproductive and uncommunicative, it's not likely that they turned into worse developers in all of a sudden. Take a time to review your management strategies, seriously.

Why write any specs anymore? The juniors don't read them, nor do the product managers. I'm just talking to myself at this point.

So, I waste time writing these nice detailed tickets, then when I go to review the pull request, the whole pile of horseshit is half done, and when I ask the product managers for resolutions, they don't have a clue either.

So just give me the whole fucking app, I'll do the whole damn thing myself. See you on Mars in 2025 while you and your pleb asses serve me fries and burgers.

Fun fact you dumbass: YOU 👏🏻 DON'T👏🏻HAVE👏🏻TO👏🏻 REVIEW👏🏻THE 👏🏻PLACE

I get asked to review places I've never been all the fucking time. But like an adult with a BRAIN I swipe away.

"Life is hard. It’s harder when you’re stupid" ~ someone who has a mf point

When managers look at my code, it’s shit, it’s over complicated, it’s overly difficult to read, it took too long, it’s too much for a simple ticket, i handled too many edge cases, we’ll never need most of it, why did I bother making it extensible when it’ll never need to change, how dare I use “unless”, why did I bother writing all these comments, why did I update the documentation that nobody reads because it’s outdated, etc. They say I should be more like the legendary devs and push janky code quickly, and complain that I don’t have any flops (problems in prod) like those are a good thing.

When my coworkers look at my code, they say it’s clean, amazingly easy to read, a monster feature that’s somehow still a joy to review and work on, it makes their lives easier, that it does exactly what it should in all cases, that they learned something from reading it, and thank me for the comments and documentation. And marvel that I finished it so well in so little time.

Am I bragging? Not intentionally; I’ve heard these things repeatedly since I started here, and the contrast between the above is so stark.

In reality, the managers are just idiots who were promoted far above their competence, and make everything worse. (Gee, who woulda thought?) It’s just so frustrating.

Anytime I have to deploy to iOS store. Part of the stack includes human review... Need I say more?

If I had a dollar for every fucking time they ignored our flagging to not put it on iPad, and returned with their review 2-3 days later saying:

"App UI did not run on iPad resolution cleanly."

Then having to submit an appeal and wait 2-3 more days...

"And how are you?" I said.

Eeyore shook his head from side to side.

"Not very how," he said. "I don't seem to have felt at all how for a long time."

"Dear, dear," said Pooh, "I'm sorry about that. Let's have a look at your code..."

And then Eeyore looked at Pooh with terror in his face, before he vanish into the forest.

He never let me review his code again...

I see many people being irritated when it comes to StackOverflow and If I were to be honest I thought the same a while ago. But I noticed that I was misjudging the main point of Stackoverflow. It's not a forum to help people with their programming problems. It's a huge self writing document to gather every programming related questions and answers under a single platform if possible. That's why they won't down vote you even if you ask a question that was obvious in a language's official document as long as it wasn't in Stackoverflow. That's why questions should also be formatted accordingly which is clear and also informative in itself. I understand why stackoverflow is such a harsh place to ask questions and most of the time I prefer looking things for my self instead of asking a question. And I edit and review most questions on stackoverflow because I enjoy it. That also made me realize that stackoverflow needs to be elitist to preserve it's current quality. Who would want to see unclear duplicate questions that veteran stackoverflow users need to answer over and over again right ?

Asking the right question is hard because we humans most of the time don't know what we don't know. And it makes it really tiring to format your question the way that is fitting for a document. In those times I prefer to ask my questions on a more relaxed and chat focused platform before writing my main question on stackoverflow.

So that was my opinion on stackoverflow and it's harsh environment. It's definetly a hard to get into community which I can't even say I'm really a part of it. But looking at stackoverflow as a document that's being written by ut's users, it's easier to understand it's elitist approach. I hope you had some enjoyment from reading it.

Fuck Apple and its review system

So, this started in december. We wanted to publsih an app, after years of development.

Submit to review, and passes on the first try. Well, what do you know. We are on manual release option, so we can release together with the android counterpart. Well yes, but someone notices that the app name is not what was aggreed (App Name instead of AppName). Okay, should be easy, submit the same app, just the name changed. If it passed once, it will pass again, right? HAH

Rejected, because the description, why we use the device’s camera is too general. Well... its the purpose of the app... but whatever, i read the guidelines, okay, its actually documented with exapmles. BUT THEN WHY THE FUCK COULDNT YOU SAY THAT ON THE FIRST UPLOAD?

Whatever, fix it, new version, accepted, ready to release just in time.

It doesindeed roll out,but of course, we notice that the app has a giant issue, but only on specific phones. None of our test phones had this problem, but those who have, essentially cannot use our program. Nasty as it is, the fix is really easy, done in 5 minutes. Upload it asap, literally nothing changed from user point of view, except now it doesnt crash on said devices. Meanwhile 1 star reviews are arriving from these users - of course with all the right. Apple should allow this patch quickly, right? HAH

THE REAL BULLSHIT COMES NOW

With only config files changed, the same binary uploaded we get rejected? What now? Lets read it. “Metadata rejected, no need to upload new binary”.... oh fine only the store page is wrong? Easy. Read the message, what went wrong. “Referencing third party content is nit permitted on the app store” meaning that no android test device should be shown. Fine, your rules. They even send a picutre of the offending element. BUT ITS NOT EVEN ON THE STORE. THATS A SCREENSHOT OF THE APP. HOW IS THAT METADATA? I ask about this, and i get a reply, from either a bot, or a person who cant speak or read english, and only pasted a sample answer, repeating the previous message. WTF. Fine, i guess you are dumb, but since they stop replying to our queries, do the only sensible thing, re-record the offending tutorial video that actually contained an android device. This is about 2 weeks, after the first try to apply a simple patch to a broken app. And still, how did it pass the review 2 times?

Whatever, reupload again, play the waiting game for a week, when the promised average wait time is 2 days, they hit us with a message, that they want to know what patent we use in our apps core functionality. WTF WHY NOW? It didnt bother you for a month, let it release ti production and now you delay a simple patch for this? We send them what they know. Aaaaand they reply: sorry we need more time to review your app. FUUUUUUCKKK YOUUU. You are reviewing a PATCH with close to zero functional change!!! Then, this shit goes on, every week we ask about an ETA, always asking for patience... at the end it took another 3 weeks... so december 15 to jan 21 in total...

FOR. A. SINGLE. FUCKING. PATCH

Bottom line is what is infurating, apple cares that there is an android device in the tutorial video, but they dont care that a significant percentage of our users simply cannot use the app.

Im done

There are three things in my workflow that I don't like:

1. Feature requests appearing out of thin air.

It's common to be handled work at 2pm that needs to be deployed by the end of day. Usually it's bug fixes, and that's ok I guess, but sometimes it's brand new features. How the fuck am I supposed to do a good job in such a short time? I don't even have time to wrap my head around the details and I'm expected to implement it, test it, make sure it doesn't break anything and make it pass through code review? With still time to deploy and make sure it's ok? In a few hours? I'm not fucking superman!

2. Not being asked about estimates.

Everything is handed to me with a fixed deadline, usually pulled off my PM's ass, who has no frontend experience. "You have two weeks to make this website." "You must have this done this by tomorrow morning." The result, of course, is rushed code that was barely tested (by hand, no time for unit or integration tests).

3. Being the last part of the product development process.

Being the last part means that our deadlines are the most strict. If we don't meet the deadline, the client will be pissed. The thing is, the design part is usually the one that exceeds its time (because clients keep asking for changes). So when the project lands on our desks it's already delayed and we have to rush it.

This all sounds too much like bad planning to me. I guess it's the result of not doing scrum. There are no sprints, no planning meetings, only weekly status update meetings. Are your jobs similar? Is it just usual "agency work"?

I'm so tired of the constant pressure and having to rush my work. Oh, and the worst part is we don't have time for anything else. We're still stuck with webpack 2 because we never have time to update it ffs.

!(!rant)

So I wanted a raise and the only way was becoming a software lead.

With that title you get more money but also more responsibility, so you have the last word in technical decisions, you review architecture, do tech interviews, guide the less experienced, etc. I can handle that, even as introverted as I am.

What nobody told me was that I was going to spend my whole time on fucking meetings, one after another, I have not touched my IDE in days, I hate this shit already.

Careful what you wish for they say, so true, I'm stuck here and I hate my job now, probably going to quit as soon as I recover my life, if ever.

After 8 iTunes Testflight Beta approvals for my app ... better still, I got hte app approved for the App Store a week ago to "de-risk" our "final submission" ... That's 9 approvals for my app, and we're ready to submit version 1.0.0 and actually release on the store. We take last week approved app and "developer reject" if to make room for the final tweaked version (minor tweaks, minor bugfixes). Submit version 1.0.0., plenty of time before it needs to be released.

But, what's this? "Meta Data rejected" for v1.0.0 because some piece of shit at Apple wants to watch a video of the app working with our hardware. What about the previous 9 approvals with the demo account connected to the demo hardware?

So we send a video within 1 hour of their unexpected request about the very foundational fucntionality of our app. That was 24 hours ago and these fucking assholes haven't even responded, no sign of when they will trouble themselves to respond. Pure limbo.

All the work up to this point was to "de-risk" their infamously shitty review process and all of it was in vain because it's somehow brand new information that our app works with our hardware.

Holy fuck, what a bunch of power-tripping assholes. All I can do is pace around and review the previous 2 months in my head to figure out what I could have done better. But I could not possibly have expected that after all the Testflight Beta approvals and after the recent App Store approval, that they would suddenly doubt that our software actually works with our hardware!!!!!

FUCK YOU APPLE!!!! FUCK YOU WITH ALL MY HEART!!!!!!

I've just noticed an app review that I've given and would fit right into the wk123 (that's the insult one, right?).

"Biggest pile of junk that I've ever seen. You have one job! To register the fucking phone number (which you could get with Phone permission) and verify it (which you can do with the SMS permission) and you should either have the user do that once upon installation or you automate it entirely so that it can run in the background! You can fully automate this, and it's not that complicated that it needs 10 whole seconds of loading time in between! Heck, this pile of crap can't even continue into the main view after entering the verification code! You haven't published the source code (and maybe that's for the best) but if it was, I'd probably immediately get cancer by viewing your crappy spaghetti code. Dear developer, please take a step back and (re)join the PC tech support guys. You have no place in the development world."

To top it all off, that app currently only needs phone permission to verify my number (at least they've done that much). So I figured, I've already gone through that authentication flow so let's remove that permission to abide by the principle of least privilege.

Except that the fucking crapp just goes through the "requires phone permission" shit again whenever that permission removal happens. Fucking piece of garbage!!! That such spaghetti code fuckers even have a job, it boggles my mind.

Once had a manager who would refuse to review anything on the basis he "didn't have enough time". Not just code reviews, but also customer comms, support messages, documentation etc. - anything that it's good to get more than 1 set of eyes on. This was a small startup so me working pretty much solo - it wasn't like there was anyone else able to review anything like this.

Fair enough, you might say. He trusts me. Just put it out there.

...but then *as soon as* it was published / sent / committed / whatever, he'd then magically find 5 minutes to glance through it and point out how rubbish / unhelpful / ridiculous the work was, and how it should have never gone out in the first place, and why didn't I read through it before sending as I'd clearly realise how stupid this was.

After a few rounds of this I actually flipped out on him in the office, called him out on his BS and told him to think for 2 seconds about how ridiculous this situation was. In fairness to the guy he did back down, take note and it didn't happen again, but damn, those times were some of the most frustrating of my career to date.

Code review time:

Hey Rudy, can you approve my PR? ??? Shouldn't it be can you review my PR?(thought to myself)
Anyway, as a new practice, we(royal we) do not approve PRs with js files. If we touch one, we convert it to typescript as part of a ramp up to a migration that never seems to get here. But I digress.
I look at the laziest conversion in history.

Looked like
Import 'something';
Import 'somethingElse';
Import 'anotherSomething';

export class SomeClass {
public prop1: any;
public prop2: any;
public prop3: any;

public doWork(param: any){
let someValue = param;
// you get the idea
return someValue;
}
}

Anyway, I question if all the properties need to be visible outside of the class since everything was public.
Then if the dev could go and use type safety.
Then asked why not define the return type for the method since it would make it easier for others to consume.
Since parts of the app are still in js, I asked that they check that that the value passed in was valid(no compilation error, obviously).
Also to use = () => {} to make sure "this" is really this.
I also pointed out the import problem, but anyway.

I then see the his team leader approve the PR and then tell me that I'm being too hard on his devs. ????

Do we need to finish every PR comment with "pretty please" now?
These are grown men and women, and yet, it feels oddly like kindergarten.

I've written code in the past that wasn't pretty and I received "WTF?" as a PR comment. I then realized I ate sh*t on that line of code, corrected it and pushed the code. Then we went to Starbucks.
I'm not that old(35), but these young devs need to learn that COMPILERS DO NOT CARE ABOUT YOUR FEELINGS!!!!!
Ahhhhhh
Much better.
Thanks for the platform.

I suddenly realized all the technical debt shit I told my boss would happen years ago given the way things were done/heading then... Just occurred pretty much all at once last week in the form of critical production issues...

The teams like:
-we need real time server process monitoring
-structured logging for apps
-containerization so one app didn't affect others

Me thinking: yes.... I told you so like 3/4 years ago when I first joined the team and kept repeating so much I got tired of saying at every annual review...

This is exactly what happens when you let technical debt grow and have no free time for developers to look into and fix then while they were small and not critical production processes... Or properly document and peer review them... (Got a shit pile of projects that no one knows how to use or even exists because the devs left the team) and they'll have a lot more when I finally leave... Hopefully this year.... If I can find another role and not need another medical procedure... (Doubtful)

I was asked by a client to code review their platform built in PHP. The platform was becoming slow and new features built by their current IT supplier broke existing features.

I gained access to the source code... One PHP file (index.php) containing about 80K lines of code... I am impressed and disgusted at the same time. 😂

As a consultant, you get tasked with a variety of stuff. Last few weeks been struggling to maintain an old C++ application that was written by a complete tool of an a$$hole with zero knowledge on how to write maintainable and production quality code. It would hardly run without a crash. First it was a challenge I had to accept, but as I stabilized the code and just fell over even more traps, I had to admit defeat and review my approach.

Rewrite is something I would choose last, but this one ticked all the marks worthy of a rewrite. So, the customer is a very friendly researcher and gladly spent 15 hours with me explaining all the math and concepts - just a delight for a programmer to have such a customer. Two days in, with a DDD approach - a functional, more precise, faster and stable application.

Sometimes there is no rant to share, it's rare to have that perfect communication with a customer that is so dedicated that he spends so much time teaching you his speciality and actually understand your approach. DDD was really a lifesaver here, by using it's key concepts and ubiquitous language. The program is essentially 8000 lines of math, but wrapping it up with value objects and strong domain models made me understand his domain and him mine. It also allowed me to parallelize the computations, giving me a huge performance boost. Textbook approach, there will not be many like this!

!rant

One day Boss was doing code review of my work
Boss to me: What the fuck dev1!?!? All efforts I spent to quit smoking and your XML routine gave me cancer anyway!

Another day, a colleague needed to make change to a program that hasn't been changed in looong time and sees a commit from our Boss done 15yrs ago!!!

Dev2 to Boss: Boss this signal catching routine sucks dicks! How did you become a our Boss?
Me to dev2: He sucked as many dicks as his routine did
Boss to us: Oh look! Performance appraisal is due this week. Bye-bye 7.5%

Here 7.5% referring to pay raise that is average pay raise

// TODO: Show this to my manager next time my app crashes during review

First proper software dev job, very naive, tasked to write a 'soft switch' for a well known companies set of production lines, depending on what product was being produced at a particular time. Wrote it weeks before the deadline, forgot about it, night before I had a quick review and realised I had missed half the spec aaaand it was going live the following day. Shitting myself I pulled an all nighter, drove to the office at 5am, managed to get it done with minutes to spare for 9am. To my knowledge it's still being used today. I left shortly after that.

Why don't devs read the fucking docs?

Time and time again I find my coworkers inventing new ways of doing stuff that could easily be done with existing features.

Today I saw this on a code review (functions are from lodash):

head(filter(...))

That's what fucking `find` does, you dense motherfucker!

This is just a tiny example. I've seen so much of this shit. Sometimes it's almost art how they find ways to solve problems without actually reading the docs.

After mass layoffs my team went from 10 engineers to 4 with no drop in expectations. This was a ridiculous ask, everyone was burnt out and could not keep up. For some reason the geniuses in management gave me a bad performance review despite me doing 2 to 3 full time workloads.

That day I put in applications and got an offer in less than a month from one of them. Put in my notice and suddenly it was surprised Pikachu face. Now they are down to 3 engineers and admitted it would be months before they had the revenue to even backfill my position.

Good riddance.

Story of WTF happened to my job

During my employment in (name censored) was stressful, They claimed I didn't complete my task on time which they constantly remove me from git and documentation(which have to follow their style of returning data), I kept emailing, slack, WhatsApp calls them, mostly and predictably got ghosted and blocked.

So How the fuck am I supposed to push my code or code without the documentation (I can actually, prevent refactoring every time, following the documentation is the good way to go.)

On the sprint review, they will complain about me not committing and pushing the code. (I did commit locally, but can't push, they removed me from the fucking repo) and not done.

Tried reasoning, telling the obvious reasons with them, doesn't work. They come out the second reason of me "NOT COMMUNICATING". Sometimes I can get to git merge from dev to my branch and get tonnes of fucked up code. I reviewed the code, and I can't tolerate it.

Lately, I overheard them mocking and cheering me about to get fired over a zoom meeting (I was in there, they forgot to remove me). Their conversation is about me being a coloniser, a jerk, betraying Chinese ancestors for being not Chinese enough.

I was like: "Why the fuck does their conversation sound like they are tucked in the Qin dynasty?"

Frequently I got labelled as unprofessional.

How is cussing about my ancestors, personal and life a professional behaviour?

A month or so ago this manufacturer of soldering equipment contacted me with the request to make a video about a review unit (a soldering handle) that they'd send to me for free in exchange. Initially I was really pumped about it - company would send me free stuff!! - but fast-forward to today and I realized how terrible a choice I've made by accepting that offer.

See, that handle is worth only €40 and I've spent so much time on the bloody video material already that it'd make my "pay" expected to be close to €1/h if not less. I feel like I've been exploited, especially since I don't even like the handle's design and am not using it. It's just collecting dust, making my work essentially free labor.

I could return the item but that's gonna cost me a fuckload of money, I could pay for the handle and cut my losses that way.. or I could do the review anyway and end up feeling very bad about that company. Or I could tell them to fuck off and lose a supply chain for my soldering equipment.

I have no idea what to do about this..

Oh and the fact that the correspondent in that company has the worst Chinglish skills imaginable, the communication skills of a toddler and is also super indecisive (they asked me to make a YouTube video first which led me to assume a video format for YouTube, but instead they want to put it on their fucking AliExpress product page, rendering my existing video footage useless!) doesn't help either.. I hate that shit company. Fucking leeches!

Anyway, what would you do when you're in a position like that?

Got a CTO at my Unity job that's younger than me, which by itself is fine, but the only reason this guy was put into that position was because the previous CTO left the company at the time where I was relatively new and he is the person most familiar with the codebase of our primary project than I was at the time.

I understood the decision at the time, but still, having a position of power being handed to them just as a matter of inheritance doesn't command my respect. Nevertheless, I withheld my judgement at the time to see how his leadership goes.

Not even 1 year in and this young CTO started making jabs at me, calling my code hard to read and incomprehensible, to my face, in front of everybody else.

Motherfucker, I don't find his code easy to read either but I went out of my way to frequently ask him, the previous CTO and other teammates to clarify what they wrote here and there. He on the other, made no attempt to ask me for clarification and instead waited until company meetings to air these grievances.

Our boss started to ask me to follow SOLID principles (even though he can't recite what that acronym means) due to complaint from the CTO guy, even though the CTO guy doesn't even follow SOLID himself! But I took the higher road and didn't flip it right back on him.

What I did propose in return though, is that the dev team start using pull requests and have a code review process if the CTO wants to sign off on everything that gets in the codebase. Sounds reasonable enough, right? Not for this guy! He immediately starts complaining that reviewing pull requests would be more work for him. Motherfucker, you refused to go to my table to ask for clarifications about my code yet still want to understand what goes on, then do code review.

It was at this point that I realized that this guy doesn't actually want me to write good, clear code. He wants me to write code HIS way so that he can understand. Yeah okay, I can accept that idea in isolation. Some open-source projects require contributors to follow certain coding convention to make the maintainers' job easier too. One project that immediately came to mind is "In-game Debug Console for Unity 3D" (disclosure: I am a contributor to this project)

But guess what?

THIS COMPANY DOESN'T HAVE A FREAKING CODING CONVENTION. NOT WRITTEN DOWN ANYWHERE. NOT EVEN A VOCAL ONE.

What this CTO guy wants from me is a complete blackbox.

To all fellow devs out there, I hope you don't work with a CTO like this, or become one.

When you review a PR from a senior dev, find something improvable, suggest it and the dev updates it accordingly.

The first time when this happened made me the luckiest guy. It's still rare, though.

Me and my friend (let's call him Tom) have done tons of projects before and got some decent knowledge, but we got a dude (Bob) working with us on that final project of Uni and he doesn't know what Git is nor what frameworks are so we chose CodeIgniter ONLY to make it easy for him.

2 month after starting the project and getting like half of the work done (mainly me and Tom) Bob 'kind of' learned PHP, CodeIgniter and Git so he wanted to contribute because the project manager will review all the commits done weekly.

So Bob did some HTML (what now?) and wanted to push it on the repo and even using Gitkraken as opposed to the Git CLI he managed to merge two f*** branches, and when he doesn't mess up the repo he totally ignores the files' structure of the project and makes his own thing.

Worst thing is, when Tom tries (I gave up a long time ago) to teach him something or to give him advice he's all like "Oh okay" "Yeah" "Got it!" but he doesn't understand anything and he won't admit it ! It's like talking to a wall...

What?... really?... You read my code? ...*wipes away tears*

THANK YOU SO FUCKING MUCH!!! You sir/madam/undefined are a true gentleman and scholar! (even if you are just a troll picking random shit apart to flash around your superior knowledge of design patterns).

Any time I receive a code review, that is bearing that is an actual review, born of free will and not a mandatory report - I feel flattered beyond words.

> Think its shit? - GREAT FINALLY FEEDBACK!
> Have an idea? - I'm all ears.
> Trying to sound smart? - You still read/used my shit.
> Want to understand my approach? - Grab a drink and get comfy son.

In a world where I am usually the only person in the world that knows WHAT MY ACTUAL WORK IS and there being only a select few people on the planet able to understand it, I am always grateful for developer feedback.

Seriously... out of your own volition you used my code, read it, made an effort to understand my thinking and THEN REACHED OUT TO ME with ideas!!??

I could kiss you... you beautiful binary saint.

How do I even start?
The guy that's supposed to be our extra resource, our go-to person, asked me why node_modules and typescript output files are not committed.
Node.friggin.modules!
And by typescript output files, I mean the compiled .js files. Shoot me now...
All he does all day is waste time! Useless calls scheduled way too early, 'cause IST & why the heck not?

And don't even get me started on his "knowledgeable" colleague who spent 2 friggin' days on figuring out how to find an element in an array.
I mean ok, I get that the language is new and the syntax is different, but boy, how I wish that was the problem! But nooo, her issue was figuring out the damn logic behind it!
Not to mention that I gotta do the code review and she keeps ignoring the changes that I ask of her unless I raise that in our daily meeting and reports stuff as done even before submitting a damn pull request. Also, I gotta shut up and take it, 'cause they are the client's internal resources, which has me ranting about it at 2 a.m. T_T

Ugh...

Trying to explain functions to my coworker and why they should be used even if powershell scrips don't 'need' functions
I've explained it 5 different ways across multiple meetings when they've gotten stuck on something.

At this point I've decided 1. I don't have the patience or brains to be a teacher..., 2. I'm going to have to review every script they ever fucking write, 3. I'm never letting them work on anything critical or time sensitive for big clients. (Small clients ehhh) I'll fight my boss to avoid that headache lol

Inmates are trying to take over the asylum again.

Got a message from the web team manager deeply concerned because since switching to the new logging framework, the site is significantly slower.

She provided no proof or any data to what 'significantly slower' means.

#1 The 'new logging' has been in place and logging for 5 years. We only recently depreciated the ILogger interface ('new' ILogger interface only has 1 method instead of 5)
#2 The 'old logging' was modified 5 years ago, so even if you were using the 'old' interface, the underlying implementation is still the same.

She tried to push the 'it wasn't this slow before' argument, so I decided to do some fact based analysis.
Knowing they deployed their logging changes couple of weeks ago, I opened up AppDynamics, looked at the average call time to Splunk (along with a few other http calls they are doing)
- caching services - 5ms
- splunk - 30ms
- Order Service - 350ms
- Product Data Service -525ms

Then I look at the data they are logging, for the month of June, over 5 million messages. At 30ms each, that's almost 42 hours spent logging errors...yes errors. Null reference exceptions, Argument exceptions, easily fixable stuff.

So far for the month of July (using the 'new' logging), almost 2.5 million errors. Pretty close so far with June's numbers.

My only suggestion was to fix the bugs in their code so they don't log so many errors.

Her response.."Can we have one of our developers review your logging code? We believe we can find ways to optimize the http requests"

Oh good Lord. I'm not a drinking man..but ...I might start.

Meeting yesterday:

Senior E: "Man, every time I do code review I thought this is the stupidest code ever written - then I look at the author, oh wait it's me"

Me: "Well, the perfect code is the code never gets written"

SE: "Casting appreciative look with a nod"

Today I found an error in how we handle credit on invoices in our software.

This is the first time my boss has ever made a legit pull request for me to review of his.

Damn I feel proud!

We worked with that freelancer some time ago. Most talented coder I've ever known. Coding for only 3 years, and only 1 technology, but technical thinking already up to par with my own 15+ years of experience. Very rude but to the point. We loved it - "one of us". We hired that asshole for different remote projects over 20 times in 3 years. We send spec, answer questions, collaborate on chat, review work on svn, add tickets, get solutions. After about a year working like that we had minor issue with finance that revealed our prized freelancer is a chick.

Changed nothing.

Wrote a feature that took a week plus to complete that was reviewed, approved, merged and already in production.

Guy who approved comes in and says to make changes now with 1 day to end of sprint saying to refactor stuff. It won't make a difference other than some logging changes but I found the effort to be large plus the QA would need to retest everything.

When I brought up my concern, he tells me it is very easy and to get it done.

Now am feeling so stuck rushing on this work cos he called it 'easy' and I don't want to look like a fool...

Why review and approve code only to come back last minute asking for changes.. Not the first time and always last minute followed by calling it easy. I am almost forming a phobia to merge approved code..

So my company hired this very old guy. The oldest developer I have worked with. I feel they took him just because of diversity.

Because he was absolutely incompetent.

Nothing he wrote ever worked, he got in conflict with everyone, made stupid jokes at meetings, asked the dumbest questions. His stories would hang for weeks, hopping sprint over sprint. Once he delivered something, his code had to be re-written from scratch. A code review couldn't even be applied as the code was worthless, so it just made sense to reassign his tasks to someone else and move on.

So after much drama he was let go. It was maybe two years ago and I recently connected with him on LinkedIn. He's changed four or more jobs since then. Prior to coming to our company he also job-hopped all the time (but most likely he was actually fired every time). His average job duration was like 6 months. Apart from that, he had a 20+ year stay with some government agency.

I fail to grasp how he ever gets hired anywhere with all the red flags. Over two decades with some govt agency (in my country they are all crap). Then change jobs every half an year or so. Then the asshole attitude. And finally, they probably never asked him any technical questions, because he knew nothing. Our interns who were just one month into the job were better by a WIDE margin.

Once upon a time
Performance Review, "great job", "like all your achievements so far".. signed.

Two days later, same manager, "as you can guess, you didn't pass probation. Could have done more."
"Oh more like?"
"Just, you know, more."

Customer: "Yeah we need <insert bonkers 12 step circular logic> to find a thing(s) in the database."

Me: "Ok let me diagram this out and I'll send it to you to review.... but man this seems like the 8th version of this we're doing right?"

Customer: "Yeah well <employee Y> says they can't do B, C without this."

Me: "Wait... can't they just <insert the most simple step in the history of time> in step A, and then later on they won't have to do all this hunting later? Like you have that data at step A right?"

Customer: "Yeah but <employee Y> doesn't want to do that."

Me: "She's your direct report ....."

Customer: "Yes...."

Me: "Ok.... I'll send you the diagram and the cost estimate...."

Whatever reason sometimes it is a bit draining coding madness compared to making things actually efficient / people's jobs easier...

One shitty thing about working in a Japanese company is that they make you write personal goals/targets (目標). These goals they expect you to achieve don't actually relate to your work most of the time and it's not about personal growth, but more about what you did to improve the company.

Another thing is their expectations that you can achieve all this within a year on top of your work is kind of unrealistic. Plus even if you achieve such goals, it does not equate to good performance review and/or salary increases.

My first project at the job was implenting a website, designed by the same company we mostly worked with.
It was very stressful because half of the 2 months calculated for finishing the project, these genius designers needed for their design. Until then, I had almost no tasks to do...
When the designs finally came, I worked on it and two weeks later was a meeting for review and to decide about some details.
These fuckers then concluded, that the whole design did not fit the page and that they would rework it.
Two weeks later, on the planned release day, we finally received it. A completely fucking different design! Wow!
My boss was pretty angry and so was I. We had to move the release 4 weeks ahead, the client was pissed like a stinking hobo and it needed a lot of convincing to keep that client...

It's fucking nerve-wracking as well that we always have to wait in most projects for weeks for clients or designers to add the content before we can publish a website.
They don't seem to care if they have 2 months or 2 weeks, we never were able to release one single project on time, because of these lazy fuckers...

First code review ever, and it's for my job.

Guy was really nice and polite.
Even correctly guessed I don't have much experience with professional coding outside my associates degree and prior job where I was the only programmer most of the time I was there.

Said that since it works functionally and is such a small program there's nothing wrong with it if it meets our purposes ( low priority project )

Then he politely in his words 'nitpicks' 3 points and gives me ideas on how to make it more reliable and less likely to need replaced or completely refactoring in the future.

I think my first time getting code reviewed went well. And one of the things he mentioned was something I didn't know how to do and only took 20 some minutes to implement so I also learned something new from this

Gave the marketing team access to JIRA and gave them permissions to create tickets. Don’t know if that was a management’s design or what. Tickets were poorly written and I had to make frequent follow ups to figure out what the heck was actually being requested. I did get accused of “questioning the request” at least once. It was a big WTF because I think marketing thought they managed dev team but they didn’t.

Marketing also didn’t give a damn about agile processes despite being told some simple rules, such as don’t change your ticket details after a dev has already begun work on it. I would pick up a ticket thinking it’s just html and css updates, then it would change to include an api update. No no no. You’ve just turned a 1 day ticket into a 1 week ticket. I don’t have time for these shenanigans.

I would also submit tickets for code review and marketing would say it’s not ready for review. Then why was that ticket in the to do column for the past two days?! They couldn’t make a decision and would submit revisions every single day.

And they would think devs could do everything. No, never assume the front end dev can pick up back end tasks.

No one on dev team really cared because we were all looking for new jobs anyway. The company was planning to lay us off in a year. Every month a dev gave notice and left.

Spent a lot of time designing a proper HTTP (dare I even say RESTful) API for our - what is until now a closed system, using a little-known/badly-supported message-over-websocket protocol to do RPC-style communications - supposedly enterprise-grade product.

I make the API spec go through several rounds of review with the rest of the dev team and customers/partners alike. After a few iterations, everybody agrees that the spec will meet the necessary requirements.

I start implementing according to spec. Because this is the first time we're actually building proper HTTP handling into the product, but we of course have to make it work at least somewhat with the RPC-style codebase, it's mostly foundational work. But still, I manage to get some initial endpoints fully implemented and working as per the spec we agreed. The first PR is created, reviews are positive, the direction is clear and what's there already works.

At this point in time, I leave on my honeymoon for two weeks. Naturally, I assume that the remaining endpoints will be completed following the outlines/example of the endpoints which I built. When I come back, the team mentions that the implementation is completed and I believe all is well.

The feature is deployed selectively to some alpha customers to start validation testing before the big rollout. It's been like that for a good month, until a few days ago when I get a question related to a PoC integration which they can't seem to get to work.

I start investigating and notice that the API hasn't been implemented according to the previously agreed upon spec at all. Not only did the team manage to implement the missing functionality in strange and some even broken ways, they also managed to refactor my previously working endpoints into being non-compliant.

Now, I'm a flexible guy. It's not because something isn't done exactly as I've imagined it that it's automatically bad. However, I know from experience that designing a good/clear/future-proof API is a tricky exercise. I've put a lot of time and effort into deliberate design decisions that made up the spec that we all reviewed repeatedly and agreed upon. The current implementation might also be fine, but I now have to go over each endpoint again and reason about whether the implementation still fulfills the requirements (both soft and hard) that we set out to meet.

I'm met with resistance, pushback and disbelief from product management and dev co-workers alike when I raise the concern that the API might actually not be production-ready (while I'm frantically rewriting my integration tests and figuring out how the actual implementation works in comparison to what was spec'ed).

Oh, and did I mention that product management wants to release this by end-of-week?!

Makes me wanna strangle my 490 days younger self..

Finally got my Bluetooth earphones!
It's called Pamu Scroll, funded in Indiegogo.
I bought it for $49 without shipping fee.
Now let me write a review about it here after using for about an hour or so.

1. Shipment
Shipment from China is slow and hard to track unless it is classified as EMS, which mine wasn't, obviously.

2. Packaging
It has some shock protection layer, but without that, nope! It was staying still inside the packaging though.

3. Design
Beautiful. Just beautiful. Period. Just see the picture below.
It opens as a papyrus, maybe that's why it is called Pamu Scroll. Both the case's end, and earphones itself has magnets to hold each other.
It has a leather feeling to both the inside and outside of the case, and the touch control area of the earphones is also leather feeling, adding a nice touch that differs with other earphonnes.
The diamond feeling finish in the end of the case makes the case itself isn't earphones, more like some expensive jewelry case.

4. Fit
My ears are smaller than most people, for I am young, so it sometimes fall off when I jump, but when I put it the correct way, never falls out.

5. Audio
I am not an audiophile. I don't really care about the audio quality and how it sounds like unless the sound is too cringy and has so many white noise.
This earphones has white noise, but just a little bit, you won't notice except when you are in a quiet room.
The bass is boosted, but low sounds, and vocals can be cringy sometimes, so I should manually tune them with my phone's equalizer.

6. IPX6
Not tested yet, but they advertise as using it in the shower.

7. Stereo call
Yup. Stereo call. Call in both ears. But only right microphone seems to get the voice.

8. Pairing
Using BT 5, it is a breeze to connect.
Take both of them out, put to your ear, then ding! "Connected"
Done.

9. Charging
with micro-usb
wireless charging for optional purchase - 10 bucks

10. battery
Reasonable amount
You have 3.5 hrs of listening time in both ears, and you can charge 2 times more each by putting in the case.

===============

Overall, it is awesome and let's just pray it doesn't break for at least for an year.

One side note, I can activate assistant by double tapping in the left ear (yes it is touch control), but my S8 asks me if I want to customize with Automate/Tasker. Yup!
Will share that later as well.

If you have any questions, ask me! Thanks for reading my first ever product review in devRant! <3

Not the worst, but probably the only one I can sort of explain & not get into trouble for NDA breach..

Umm.. here it goes.. wrong id returned from db procedure, tried to do something on db with that id and got exception that the id doesn't exist. Instead of checking why the procedure returns nonexistent id, he just wrapped everything in try catch without any logs.. & of course, didn't tell anyone about this.. o.0

I know, I know, code review could have prevented this, but holy fuck..
Guy's cv had more experience than I have now, so at the time, I didn't think I'd have to check every line of code he wrote, especially not for shit like this.

Slowly getting better with RegEx problems! Warning, lots of non-computer linguistic geekiness ahead.

Been working on some functions recently to replicate the furigana (Chinese character annotation) functions available over at JP.SE in PHP for a project.

Managed to get the basic cases down fairly quick:

[Chinese character][reading] => <ruby><rb>Chinese Character</rb><rt>Reading</rt></ruby>

However I realized this evening that there are patterns where this repeats twice for one word, such as the following:

[Chinese Character][helper Japanese character(s)][Chinese Character][possibly optional word ending][reading for the whole thing]

Managed to get it working for both cases initially, but then I found out that adding a Japanese character to either of my test strings (see graphic) would cause the annotations to fall grossly out of sync. The next two hours disappeared pretty fast before discovering that the issue was that I was removing the wrong string length from the annotation string, and just happened to luck out with a test case where it worked the first time.

Probably going to do a code review of it with the intern next time he's in. One of the things I've been stressing to him lately is that however easy a task may be for a human, there are all kinds of extra things that need to be tracked in order for a computer to be able to follow your logic.

So recently my open source project took off and got trending on GitHub (680 starts and 225 forks). This was the first time a project of mine really gained some traction and invested more of my time and weekends to maintain this project - I wrote comprehensive docs, contributing guidelines and reviewed PRs and made sure I commented on every single one of them. Sure, it isn't easy to review 50 PRs a day after coming home from work but the excitement of seeing this project becoming trending fueled me.

First 2 weeks it was good. I would come home from work and have dinner and sit down to maintain the project. Whenever contributors would be stuck, I would help them and write comments on each PR.

But the problem started since last week. People just really want to see their contribution activity graph get populated and hence they would make stupid PRs and literally no one followed contributing guidelines - I mentioned in that that the code should adhere to Pep8 styling but no one gave a shit. Each day I would spend reviewing PR with crappy formatted code and no sign of Pep8, and even some will just file PR and add a fucking docstring to every function or add paragraph of comments. Also, the PR quality was bad with unsquashed commits amounting to 10 or 20 or even sometimes 50.

I wrote the contributing guidelines doc and in that I mentioned every source that contributors could find helpful like how to squash commits, how to file a PR and Pep8 and not to write useless comments. Seriously people, grow up!

Product owner/Scrum master: "We don't have any time to review pull requests. We need the development time for features"

One of our juniors was adding a feature and made a small mistake in one of their (copy-pasted) unit tests by forgetting to cast a return value of a mock

So he spent a ton of time changing the main code to do type checks, try/catching and error handling.

Poor soul realized the mistake in code review one day later

Client asked for time line for website I told them 6 weeks from moment they provide design (I had other active projects and would have to split time between them ) . For next 4 weeks they would send me design and then after few hours tell me to stop working and that they are going to change design.
After 4 weeks they sent me final version of the design and informed me that it needs to be done in next 2 weeks. We expected 10 more websites from them and it was 7-8 pages so I put other projects on hold and finished it in around week and sent link to them for review, 2 days before deadline they informed me that there are around 20 pages missing pages that are not in final version of design but only in version xx sent more than 2 weeks ago. In next day and half me and 2 other developers had more then 20 hours each to finish it on time

I'm usually nice to people and try to look for the best in them... but this one time one of my colleagues gave me a code to review that, something about trees, can't remember, and the function was hammering the databases with 3 nested cycles, that's when I could no longer just watch. I was kinda mean on him that day, but as a result he did fix the problem and was really happy and I sensed a bit proud of himself as well.

Long story short, I believe he's not a software dev anymore. Kinda shame, I liked the guy, but he seemed enthusiastic of his new job and that is all that really matters in the end

Got a new job in a new team.

Someone had to learn that software. I said I could.

I was punched by old team most of the time because they did not want to transfer the ownership to us, they had to and I had to learn that
Software.

I made it, worked hard to automate daily stuffs.

Described each victory in my year review with manager.

Each thank you, I poked my Manager to promote me if she thinks I deserve.

I got promoted a year later.

I'm so tired.
Got enough sleep but tired nevertheless every day.

Situation in the company isn't helping, would really like to get a review as I'm really close to a 'final' version for productive use, none given.
Didn't think far enough and didn't include various OO-things when starting to program this application, so I had to rewrite lots of it. It certainly got better by the time but as it's a grown structure I'd feel happier if someone other than me had seen and cursed the code.
Coworker that has most experience in C# only once implemented something with multiple threads, couldn't help me there.
Could not test the code yet because the hardware was inaccessible and is now potentially broken.
I really like working independently, nevertheless I feel a little bit lost at sea - I can deal with that, but it's exhausting.
Also, trying to get an answer from the colleague who should act as my supervisor whether or not I can work remotely during a CS related course in the semester break for > 2 weeks now. Course admission is the mid of January so I'd like to have an answer this year so I can repeat the basics I'll need if necessary.
Also, Midterm is coming.

It's a lot of little things piling up right now I wouldn't mind if there were only 1-2 of them.
I'm just so damn tired.
I'll go to sleep now.

(In happy news: my internet connection is working pretty decent now, technician that fucked it up apologized and said that he probably needs glasses, he misread the connection number. :D)

One coworker in my projects now.

I work with her on two projects. One project I'm doing a review on their test scripts and saw a lot of revision is needed on hers. It's fine, she may just need some help. Offered help and did sessions and gave explanations and samples. But she is still not finished. 2nd project I was acting like the project manager until the official PM gets assigned. Her tasks is just to create test data.

Little did I know she has escalated the 1st project to her team lead and manager and requesting for a project change. This is not the first time she did this project shopping bit. But what irks me the most is doing an emergency leave so you don't have to attend the meeting on one project you are failing and then not telling me as the acting PM on the 2nd project that you have an emergency leave. She may likely never thought there is need to tell because she did attend the meeting for the 2nd project later in the day. But for the 1st project I have to pickup her slack and do the test scripts because the PM in that project already was informed about her leave.

This would have gone to daily rant but she is the first one I've encountered who fails and somehow gets away with it and even gets promoted doing the same tactics. But she did that to our junior resources in other projects who may likely got burned out and resigned.

Crappy performance should not be rewarded. I hope this time our management won't look the other way.

Let's set your personal development goals for the quarter
Remember, they have to be free, align entirely with what the company is already doing and require no support from management.

Why do they even bother pretending to care about development?

Me: We have a new research project for you. We need you to test these 2 new services, see how they will fit into the new application, look at alternatives if necessary etc. At the end we need you to write a report with your findings, showing how you would integrate them to achieve X, Y and Z, and how much it would cost each month.

Dev: sounds good, I'll come back to you when I have it.

*2 and a half weeks later*

Document paragraph 1: The new language translation service doesn't support the languages we need.

Document paragraph 2: Here's my proposal for integrating the new language translation service.

*review*

Me: So I had a look at the doc and it says it doesn't support the languages.

Dev: yeah unfortunately not.

Me: Ok, so when you discovered that, why didn't you look for an alternative? Or come back to me and say it's not going to work.

Dev: I dunno, I thought you'd want to see the rest of the research first.

Me: ... not if we know for 100% undeniable fact that it will never function.

Dev: Ah ok, I didn't think of that. I'll do that next time, don't worry.

... aw how sweet, he thinks there will be a next time. Poor guy.

Most painful code error you've made?

More than I probably care to count.

One in particular where I was asked to integrate our code and converted the wrong value..ex

The correct code was supposed to be ...

var serviceBusMessage = new Message() {ID = dto.InvoiceId ...}

but I wrote ..

var serviceBusMessage = new Message() {ID = dto.OrderId ...}

At the time of the message bus event, the dto.OrderId is zero (it's set after a successful credit card transaction in another process)

Because of a 'true up' job that occurs at EOD, the issue went unnoticed for weeks. One day the credit card system went down and thousands of invoices needed to be re-processed, but seemed to be 'stuck', and 'John' was tasked to investigate, found the issue, and traced back to the code changes.

John: "There is a bug in the event bus, looks like you used the wrong key and all the keys are zero."
Me: "Oh crap, I made that change weeks ago. No one noticed?"
John: "Nah, its not a big deal. The true-up job cleans up anything we missed and in the rare event the credit card system goes down, like now. No worries, I can fix the data and the code."
<about an hour later I'm called into a meeting>
Mgr1: "We're following up on the credit card outage earlier. You made the code changes that prevented the cards from reprocessing?"
Me: "Yes, it was my screw up."
Mgr1: "Why wasn't there a code review? It should have caught this mistake."
Mgr2: "All code that is deployed is reviewed. 'Tom' performed the review."
Mgr1: "Tom, why didn't you catch that mistake."
Tom: "I don't know, that code is over 5 years old written by someone else. I assumed it was correct."
Mgr1: "Aren't there unit tests? Integration tests?"
Tom: "Oh yea, and passed them all. In the scenario, the original developers probably never thought the wrong ID would be passed."
Mgr1: "What are you going to do so this never happens again?"
Tom: "Its an easy addition to the tests. Should only take 5 minutes."
Mgr1: "No, what are *you* going to do so this never happens again?"
Me: "It was my mistake, I need to do a better job in paying attention. I knew what value was supposed to passed, but I screwed up."
Mgr2: "No harm no foul. We didn't lose any money and no customer was negativity affected. Credit card system may go down once, or twice a year? Nothing to lose sleep over. Thanks guys."

A week later Mgr1 fires Tom.

I feel/felt like a total d-bag.

Talking to 'John' later about it, turns out Tom's attention to detail and 'passion' was lacking in other areas. Understandable since he has 2 kids + one with special-needs, and in the middle of a divorce, taking most/all of his vacation+sick time (which 'Mgr1' dislikes people taking more than a few days off, that's another story) and 'Mgr1' didn't like Tom's lack of work ethic (felt he needed to leave his problems at home). The outage and the 'lack of due diligence' was the last straw.

Estimate for writing a custom WordPress plugin:

1 hour - Learn the API the plugin will support
1 hour - Review how plugins are written
60 hours - Set up XAMPP only to find that the version with PHP 7 no longer supports MySQL but something called MariaDB which my host doesn't support and then uninstall XAMPP and install MAMP only to get really frustrated setting it up and beat myself for not just buying that $99 Windows Pro upgrade so I can install Kalabox with HyperV which is much easier than all of this and why doesn't Kalabox have a way of supporting Windows Home because not everyone buys Windows Pro or can afford a Mac or has time to screw around with 100 possible Linux distros to figure out which one will work best and then buy gasoline and matches and set it on fire and watch it all buuuuuuurn such pretty fire.

Welcome to this week's episode of "sudo-woodo tries to get a single Python script merged", starring...

•The software architect so senior they were working here while I was still in pre-school. Wasn't added as a reviewer and was completely absent on this project for two months but came in on this PR with a few questions, including questioning design decisions they agreed on the last time they saw the project.
•The QA lead with ten years of experience... in Java. Has never even touched Python and asked to review, only for every issue raised but one stemming from not knowing the language.
•The CI guy. A script guru who will find a problem with literally anything. Honestly the most helpful person of the bunch.
•My coworker. Hasn't said anything yet.

please send help

"yo would you please review when you have some time?"

Imagine asking your friends to help you rate your app on the google play store and instead of saying NO I DONT WANT TO RATE YOUR APPLICATION no... they decide to fuck with your mind.

1)
I will rate it tomorrow. (she never rated it tomorrow nor the next couple of weeks later)

2)
I will keep it in mind and rate it later :). (she never rated it later)

3)
I rated it haha (less than 30 seconds later they deleted the rating)

4)
Send me a link and I'll rate it (i send the link, they never respond or read my message again)

5)
I dont have memory on my phone :) (because 13MB of memory is a lot of storage requirements but taking 1 million selfies of up to 25GB is completely fine)

6)
I dont have memory on my phone what dont you understand :) x2 (this is the second girl)

7)
Your trying to give me a virus?? No (i got blocked multiple times)

8)
You want to hack me by making me install this application from the link that you sent me that leads to google play store? No (blocked)

9)
Rate your app? Haha i dont care about it because it doesnt bring me any benefit only the fat cocks that fill my pussy up satisfy me and not ur app haha

10)
Haha send me a link ill rate it (i send link, 8 hours later no reply or reading my message, i text her back if she had done it and im still put on ignore)

...

N)
more

----

Notice how none of these people have said the 2 letter word: "no".

All of these 10 examples are based on a true story.

All of these 10 examples are different people.

---

How hard
Can it be
To just
Write

no

---

.

---

For all of you who are about to trash talk saying i am desperately trying to beg people to rate my app:

i know all of those people for a long time. But when it comes to asking (and not forcing) someone to do you a favor for free that takes no more than 30 seconds, no one seems to have 30 seconds of their free time. Dont get me wrong, some of my friends did politely rate it and left a review, even the people who i barely knew left a review and rated it, but the people with whom I was closer by, didnt.

---

In the beginning i used to not care about this at all. Then i started falling into depression because of it. I fell then into deep depression. Then i sunk so deep that i couldn't feel any emotions anymore so i laughed as an anti depressive mechanism whenever something depressing happened. Now i cant even laugh because i have no more energy. Now i actually leave man tears

---

The only thing more valuable than people, any materialistic thing, animals, coding and even money - is time....

----

why do you waste my time

if i ask you to do something that takes 30 seconds and you dont want to do it

why cant you just say no

why do you drag me

why do you say you're going to do it when you know you wont do it

what do you gain by unnecessarily lying to someone for such a small thing?

to someone who has been a good person to you?

do you feel superior?

is your ego bigger?

----

This experience has taught me that not even a human from the same blood can be trusted.

All of your are fucked up in the head in your own style and i am guilty of it too, all of us are.

But i have never seen the human evolution went from simplicity to overengineered complexitory bULLSHit where you have to lie to someone and waste hours, days, weeks, months and sometimes years of his time just because you dont want to say a 2 letter word, no.

But when that person becomes more successful than you and achieves higher status, Theen you have those 30 seconds of free time. All of you are fucking cynics. and i am so much overly disgusted by all of this fucking bullshit....

-----

This experience has proven to me to simply focus on investing into myself and learn and improve myself and no one else. To not even bother asking even for a small kind of help, a feedback from my work because people don't have 30 seconds of their free time. That is all.

Been busy, received this book today. Got some time and reading it on this nice evening.

I have no review as I’m still reading it.

I was applying for a job that I really wanted, and were told to code an assignment. I sat for 2-3 days coding an e commerce app in react which was super fun and challenging, I think I made a pretty decent app. but after I handed it in and a couple of weeks later I got back that I didn’t make it further in to the process. The feedback showed that I missed some essential stuff and I mixed typescript and JavaScript even though it was supposed to be in typescript (I’m new to TS) :(
I feel so disappointed, I probably had too many things going on while doing this that I didn’t had time to review it properly before sending it in. Oh well, at least I have a nice job now (but underpaid)

Chat apps. What's the idea? Those are basically tools of violence. They give you a possibility to in real-time stop someones work and start demanding service. Now. Immediately.

Usually people send you first email and then they after 10 seconds chat "did you see my email?? read it! serve it! please me!" Usually it's just a small request to document something, review someone else's document. Do it ASAP. If you were coding something, then drop it and do someones job for them instead.

You got a request for me to create some verification case list? Put it into my backlog. I might start doing that in week or two. Or month. In case there's nothing else more important. Since I know that you are working with something that you think is the whole universe, but trust me, I got my own problems already.

But hey, if I don't reply to your chat in a minute, please feel free to walk behind me and start explaining your life. No need to wait even for me to get my headphones off. "Oh you are in conf call? Well, this is just a quick thing blaa blaa..."

developer makes a "missed-a-semicolon"-kind of mistake that brings your non-production infrastructure down.

manager goes crazy. rallies the whole team into a meeting to find "whom to hold accountable for this stupid mistake" ( read : whom should I blame? ).

spend 1-hour to investigate the problem. send out another developer to fix the problem.

... continue digging ...
( with every step in the software development lifecycle handbook; the only step missing was to pull the handbook itself out )

finds that the developer followed the development process well ( no hoops jumped ).
the error was missed during the code review because the reviewer didn't actually "review" the code, but reported that they had "reviewed and merged" the code

get asked why we're all spending time trying to fix a problem that occurred in a non-production environment. apparently, now it is about figuring out the root cause so that it doesn't happen in production.

we're ALL now staring at the SAME pull request. now the manager is suddenly more mad because the developer used brackets to indicate the pseudo-path where the change occurred.
"WHY WOULD YOU WASTE 30-SECONDS PUTTING ALL THOSE BRACES? YOU'RE ALREADY ON A BRANCH!"

PS : the reason I didn't quote any of the manager's words until the end was because they were screaming all along, so, I'd have to type in ALL CAPS-case. I'm a CAPS-case-hater by-default ( except for the singular use of "I" ( eye; indicating myself ) )

WTF? I mean, walk your temper off first ( I don't mean literally, right now; for now, consider it a figure of speech. I wish I could ask you to do it literally; but no, I'm not that much of a sadist just yet ). Then come back and decide what you actually want to be pissed about. Then think more; about whether you want to kill everyone else's productivity by rallying the entire team ( OK, I'm exaggerating, it's a small team of 4 people; excluding the manager ) to look at an issue that happened in a non-production environment.
At the end of the week, you're still going to come back and say we're behind schedule because we didn't get any work done.
Well, here's 4 hours of our time consumed away by you.

This manager also has a habit of saying, "getting on X's case". Even if it is a discussion ( and not a debate ). What is that supposed to mean? Did X commit such a grave crime that they need to be condemned to hell?

I miss my old organization where there was a strict no-blame policy. Their strategy was, "OK, we have an issue, let's fix it and move on."
I've gotten involved ( not caused it ) in even bigger issues ( like an almost-data-breach ) and nobody ever pointed a finger at another person.
Even though we all knew who caused the issue. Some even went beyond and defended the person. Like, "Them. No, that's not possible. They won't do such dumb mistakes. They're very thorough with their work."
No one even talked about the person behind their back either ( at least I wasn't involved in any such conversation ). Even later, after the whole issue had settled down. I don't think people brought it up later either ( though it was kind of a hush-hush need-to-know event )

Now I realize the other unsaid-advantage of the no-blame policy. You don't lose 4 hours of your so-called "quarantine productivity". We're already short on productivity. Please don't add anymore. 🙏

Had a guy put in a pull request with an empty file diff. He comes by two weeks later and asks when am I going to have time to review it.

Long time lurker, I now have something to show you and it's something I've proudly made!

I've been working on OctoLenses lately, a Chrome extension allowing you to filter your PR and issues on Github. I find it really useful on a daily basis; and you might too

It can be used to:
- Monitor the PRs that need a review (or that have been reviewed successfuly)
- Find issues on open-source projects you like that you could take on
- Anything you can express with a Github search basically

It's good enough that I feel like I can share it with you, and I'd really like if you could take some of your time to give me a bit of feedback.

What do you like?
What you don't?
Which feature should I add?
Anything constructive basically :)

Thank you (and sorry for the self-promotion)!

Just had my year 1 review.
They love what I've done so far, exceeded every expectation. But the salary will be looked at 6 months from now. It's already awful enough at work.

About time to look for something new in case they take the piss out of me in 6 months.

"We need this project done by friday"

When:

Requirements changing on a daily basis.

No standards whatsoever, anywhere.

5 different people commiting changes with no code review.

Original team leader quit a month ago.

Current team leader doesn't know our own deadlines.

QA looking at layout through a microscope at every single possible resolution. (please move this 2 pixels to the left between 934px and 936px range)

QA being too vague some times (this looks weird some times)

Same thing being changed back and forth because no-one could agree on how exactly should it look.

PM implying at every chance that I did nothing and what little I did broke everything all the time.

I love it when my boss says "review the code with this guy since he knows alot" and that guy wastes your time by just skimming my code and saying "where is the final product?". I don't get people sometimes. At least I impressed myself making a small chatbot.

I don't fucking see how others get their stuff through code review, if when I make an enhancement it gets stopped for stuff other people did before me. Like, at this point it seems like I'm spending more and more time refactoring than simply doing the requested enhancements.

I don't blame the team, they're going off of the documentation. But this is getting ridiculous.

Few years ago as a junior android dev with couple years of self taught experience of working in startups I submitted a simple android app assignment for a junior android dev role. Assignment had only like 8 requirements so I followed them to the letter. That didn't end well.

App was simple just 3 screens. Login screen with username and password input fields, login button.

Had to call a login endpoint after login button was clicked, redirecting to home screen, calling items endpoint, displaying a list of items and when an item was clicked passing item data and redirect to item details screen.

Needless to say big swinging dick senior was not impressed. UI was not perfect, I forgot to display a loading animation when fetching data, didnt handle back button properly.

I agreed with some points but other comments were clearly just nitpicking: his preferred variable naming conventions, his opinions on architecture that was not up to his standard (official google arch at the time was not up to his standard).

He also was mad that app wasn't prepared for release to googleplay (another out of the ass requirement). Like I would prepare a 3 screen app for prod release that he will forget ever existed after 20min of his review.

Lots more of nitpicking, encapsulation this encapsulation that, omg now hes shocked that there are a few warnings after the project is built.

Regardless my self confidence was destroyed at that point and after few more negative experiences I dropped android dev alltogether for a couple years and switched to game dev.

After game dev ran its course I went back to android dev and found a supportive place where I could grow.

Looking back, they were actually hiring atleast a mid level for a junior position but I was grilled as a senior. The guy literally didnt wrote any single positive thing in that review about my code even tho my senior peers said my project was decent back then, its just that I didnt handle a few edge cases and that's all.

I looked up the guy in linkedin, turns out hes a uni dropout who posts all books that he red about software dev in his education section of his linkedin profile. Found a bunch of other narcissistic stuff on his profile. Guy was a fucking idiot. Even if I worked under him it would have probably sucked.

Learned some important lessons I guess. Always get a second, 3rd and 4th opinion and dont take criticism too seriously. Always check what kind of person is providing feedback.

PM in sprint review, after some colleagues complained about having to develop requirements on their own:
you are software engineers, your main task is to design software systems. this is the tricky part. coding is easy... it's a stupid task, i could do it, my nine year old daughter could do it.

shall i feel a bit offended? also i think, he is wrong... i also design while i'm coding, i'm designing all the time.
also, i love coding :( this is the most satisfying aspect of my job.
but then again, i heard there are people who code without designing... even though i cannot imagine how to work like that at all.

I don't understand how my managers suddenly forgot that my "down weeks" we're due to technical debt I inherited. The whole on boarding hasn't been in my favor. I've stayed at work everyday til long after work hours, digging through code, trying to get JIRA tickets done, encountering issues specific to our code base that no one would ever discover on their own without docs/help from the original dev. The whole time, I was told that they know what's going on and apologize. I constantly expressed that plenty of what we were doing was building on antipatterns. They acknowledged. When a ticket wasn't done, they always knew the very specific reason and I wasn't faulted. 6 months in, I receive a great annual review. 7 months in? I receive an email titled "Performance Discussion," detailing 4 of those incidents where a ticket was pushed back -- with inaccurate depictions of what actually went down. They actually wrote that I didn't communicate. One part of the report expressed that there were "bugs found in production due to inadequate test coverage." WTF!! Everything made it past code review and QA. What are you talking about?? In fact, the person who wrote that merged my code in each time!!!! Insane!! Anyway, Q2 is partly about cleaning up technical debt, which is a responsibility I have been vested (fantastic). I've deleted about 800 lines of code in the last 2 weeks and added plenty of doc strings. Two of the most important modules our application works from are about 1000 lines of JavaScript each without any comments/docs. I'm changing that, but I don't know if my managers truly know the significance. Someone was recently promoted to my position but manually wrote out a sorting algorithm (specified numeric indexes and all); didn't do shit to earn it but breathe. And while they get more and more praise and responsibility, I'm over here stuck trying to prove myself and live up to why I assume they hired me. It's ridiculous. I love the company, but I'm not getting any sleep and I'm stressed out. It's only been about 7 months and I've been doing everything I can. Why is this happening? What am I doing wrong? I've been developing a recurring (physical) headache and ticks. My heart/chest area sometimes feels like it's lifting weights. I sound like an idiot, pushing so hard for a company that isn't mine, but I take so much pride in being in this position, and I'm so set on proving myself this early in my career (I'm 25).

I just realized one of today's emails is asking to review again that spaghetti program and this time figure out how to optimize performance because it is getting flagged for high cpu and database usage. A Niagra of If-statements and nobody-cares-for-comments-and-technical-documentation.

*bleep* *bleep* *bleep* previous programmer.

I'll deal with this torture on Monday.

Imagine you work in a mechanic’s shop. You just got trained today on a new part install, including all the task-specific tools it takes to install it.

Some are standard tools, like a screwdriver, that most people know how to use. Others are complicated, single-purpose tools that only work to install this one part.

It takes you a couple of hours compared to other techs who learned quicker than you and can do it in 20 minutes. You go to bed that night thinking “I’ve got this. I’ll remember how this works tomorrow and I’ll be twice as fast tomorrow as I was today.”

The next morning, you wake up retaining a working, useful memory of only about 5% on how to use the specialized tools and installation of the part.

You retrain that day as a review, but your install time still suffers in comparison. You again feel confident by the end of the day that you understand and go to bed thinking you’ll at least get within 10-20 minutes of the faster techs in your install.

The next morning, you wake up retaining a working, useful memory of only 10% on how to use the specialized tools.

Repeat until you reach 100% mastery and match the other techs in speed and efficiency.

Oops! Scratch that! We are no longer using those tools or that part. We’re switching to this other thing that somehow everyone already knows or understands quickly. Start over.

This has been my entire development career. I’m so tired.

My most useless meeting was probably the review meeting for a new team I had to consult for a short while for. A review to find why nothing gets done on time. Everyone showed up an hour late, including the boss.

Recently I've started thinking about how we are always told "No you can't do that" to everything. That feels like a theme in our industry.

I've also been thinking about how often people say well done to each other, or just comment that something is good in a pull request. Everything is always focused on bugs and mistakes - not good bits.

The first point conflicts with the idea that when using languages and frameworks you should follow their philosophy or you're gonna have a bad time - but in all other instances you mostly don't have wrong answers, just answers that can be better so a lot of stuff is opinion based.

I've decided to change my ways and focus just as much on good stuff as bad when I review code and to make sure I'm focusing just as much, if not more, when people do something good.

I think I do a good job, but I don't think I've been told I'm doing a good job or that anything specific is good more than a couple times in the last year - mostly in mandatory reviews. What about you?

Dear team leader, If you tell me „I need to review this merge request before merging”, then make sure you are able to allocate time to do this.

If you need MORE THAN A WEEK to even start, then maybe your delegation skills are nonexistent.

I am a junior web developer, currently working in my first job for a small company, I was hired because I have an interest in meteor and modern web dev.

When I say small I mean I am the only full time js dev.

So the project we are working (my first ever professional project from start to finish) is a travel booking web app (being a little vague, for the sake of privacy). I am the lead developer, as a new programmer of a project that is far from trivial. There are no other javascript devs in office, no sort of code review. We have an outsourced dev but as I got in a flow with one dev my boss supposedly told him to do it part time (without discussing with me), but haven't heard anything from him, so assuming he's just disappeared (probably annoyed at being treated like a commodity).

Boss has set up the stages, and forces me to move on to the next stage before that stage has been finished. I will have to go back over the whole thing to finish things off.

He will only hire cheap juniors, one front end guy with barely any experience is styling the site.

He is used to churning out WordPress and Magento sites.

Wish I had a senior I could learn off.

I want to stick at this project and see it through, but i can only see it ending in a train wreck.

At the same time I want out, I want to work under a better team with senior programmers and better code review.

I just have to do my best and see how it goes I guess

"What is your project status? I need an update!"

So spoke the team leader. I was mildly hesitant about just rudely leaving work - which I was about to do, I was literally halfway out the building - without answering and delaying to Monday.

My project leader - the one that is supposed to look after me and my project every now and then - is on vacation. He's also the one, who is supposed to update the team leader.
It's not that we don't talk regularly, apart from his questions every two months or so, he is informed about my project on a bi-to-tri-weekly basis whether he wants it or not.

The team leader on the other hand seemed quite uninformed about my project.
Wouldn't it be nice if people would fucking talk to each other?!

Other than that, I'm learning C# for roughly six months now and today was the day it all started making sense. OO is a concept that is hard for me to grasp - I understand it, but I continuously failed to implement it. (That I have no regular code review right now isn't helping.)

Today, it just clicked.
I feel kind of stupid and in awe at the same time right now. :D

Because of high gas price, the government decided to lower our tax.
For me it translates to additional EUR 11/month ☹.
This is after deductions of thousands of euros each months (tax and social contribution) from my hard-earned salary. How come nobody is complaining about this?

During my yearly review, I told my manager that I expect to see significant salary increase next year (the inflation is 9% duh!).
She told me that I can expect to get 20% increase after 3-4 years. ☹
Now I know why a lot of people are leaving. How can you expect your employer to stay put if you're constantly paying them under market rate?! I have to keep switching jobs every 4-5 years to get a decent pay, right? Yet society expect me to settle down and have a stable job.

And then, how come a PM earn significantly more than a regular dev? Even the job interview is much easier. But I like the technical part too much to switch to people management.

By no means, I am starving right now working as a dev. I am happy that I even have a job, but somehow I felt like what I do is pointless just being a wage slave, and felt demotivated in a lot of ways.

P.S.: I am writing this now in front of my work computer. I have to catch up some work to do otherwise I won't have time to do it during the weekdays 😔
Pray for me guys I can get better job within next year.

*lunch time*
Designer: we want to put these graphs on the landing page.

Me: ok, well they are pretty simple I can recreate them in about an hour with JS, and they will look better and be inter active...

PM: we don't have time for that just use the images from the mock up

Me: ok...

*5hrs & dozens of emails later...*

PM: the graph doesn't look quite right, can we just build it in code so it looks better? Oh and we need to have it to the client to review by end of day...

Me: ...

i was hired to join a team of old devs (40+) in an unnamed European country "yay goodbye 3rd world it's time to enjoy the quality of life" assist with enhancing already existing software and creating new solutions.
prior to my arrival most things were slow and super buggy, looking at the code base it shouldn't be a surprise, amateur hour everyone, logic implemented that is not needed, comment driven development, last time code review was done back in 1996. lots of anti patterns.
i swear there is a for loop that does nothing but it loops through a 100+ elements list, trunk based development with tfs since git is "not really needed"
test projects are not there.
>enter me an educated fool, with genuine passion for the craft and somehow a decent amount of knowledge.
>spent the last year fixing stuff educating people on principles and qualities.
> countless hours of training and explaining. team is showing cooperation, a new requirement comes in to develop with react.
> tear my ass creating reusable shit and self explanatory code with proper naming etc using git with feature branching, monday is first deployment day.
> today a colleague was working on an item submit a pull request and self approve it
> look at the code..... WTF the dumb fuck copied and pasted the whole code from different kendo components but somehow managed to refractor the name to test component, commented out all the code that he didn't use did the api call directly from the component, has 2 useeffects that depends on the a fucking text box changes for no reason, no redux implementation, the acceptance criteria is not achieved, and it doesn't work it just look right.
> first world country shit cannot scold, cannot complain, lead by example.
>asked him why you did this, the response was yeah probably i shouldn't have done that, i really didn't understand anything in the training but didn't want to waste time!!!!
> rest of the team created a different styled disaster with different flavors they don't even name their shit the same way.

fellow developers I'm stuck in a spaceship with a bunch of imposters, seriously i never cried in my entire life now I'm teary and on the verge of a break down.
talk with management "improving needs time" and offers me to join a yoga session to release the stress as if reaching nirvana would deliver shit on monday.
i really don't know what do is this a rant, is this a cry for help, I'm not sure, any advice is welcomed.

I gotta say, I actually admire the work that content creators must go thru to make quality content.

So as I stated before I’m working on YouTube channel, under the name “TheSoftwareSage” ... to create tutorials and a way of me teaching software the way I believe it should be taught, not how the mainstream methods of today are.

Bottom up approach rather than top down

(Must start with a firm understanding of the foundation.. and build upon the knowledge as we go thru the layers of abstraction but the key concepts must be understood first)

Anyway, I’m working on this in my spare time and I was not aware of how much effort I would actually need todo this right haha. At first I figured I’d just screencast a monitor and have a ppt or text editor or terminal open and that stuff and just do it.

As In person with my interns I never have “planned” lessons or content is all impromptu based on the need at the time and I just go with it, with their computers and a whiteboard lol.

I was wrong for video recording lol... maybe it’s OCD... or perfectionism, I’ll make a video, review it like 5times and then be like shit I forgot to mention this or that or I didn’t like how I explained this or that
OR
I keep worrying too much about colors, and sound levels and quality and transitions and video angles and all this other shit.
And then post editing fuck.... I’m about ready to say fuck it and “do it live .. one shot” and just upload the end result.

I guess this would be in the content world similar to our “paralysis analysis” notion.

So I wrote a python code and was waiting for +1 on code review and I needed to merge it fast. That shit of a reviewer took his time to finally NOT give a +1 with comment, "if statement has no else part". OF COURSE IT DOESN'T HAVE ELSE PART. I DON'T NEED A ELSE PART. But to give him the benefit of doubt, I'd like to ask devRant community if they believe all ifs should have elses.

Come back from a week's vacation, 3 apps in review. Sit down, set up Xcode, pull latest changes. Run code for the first time, tap through two screens, find a critical bug and I have to reject all 3 apps and resubmit.

5 business days away and I found an obvious bug in 5 minutes.

Someone's not doing their job...

Code review day 1:

Me: Where are these three templates being used? I don't see any class that uses them.

Him: Oh, yeah. My bad. I'll remove them.

(Time passes)

Him: I don't know what's going on with my branch. Please ignore the PR for now.

(Time passes)

Him: Is there any way for me to get the files from staging. I don't know what I did to my branch.

Me: Hang on. I'll push a copy of the one I have in a new branch.

He declines his PR and stops by to say he's going home but he'll open a new PR tomorrow and remove the unused files.

Code review day 2:

Him: Hey, do you know what happened to my PR? It looks like it disappeared.

Me: You declined it yesterday. Said you'd make a new one today without those extra files.

Him: Ooooh!

OMG you fucking little cunt!

Previous issue with this co-worker we hate eat other but can maintain minimal contact due to covid. Last interaction was actually nice, we joked a bit.

He teaches me how to do the build and ‘updated’ the confluence page. By update he striked through one paragraph.

Been doing these for week and now others what builds done all the time and since I am not an asshole they can approach me to do this but now I spend all
day long doing builds.

Work on a classified app so it has to
be burned on a disk, taken to a ‘secret machine’ and deployed. Takes about an hour and people are like. Can you rebuild it? I forgot to commit something?

So I updated the page to flush out the directions. Did not remove one thing only added things simple things like do a ls -lah in the dist folder to make sure the are built correctly. Things like check to make the symlink works, bolded words.

He was not at standup so I figured he was out of the office today and was going to ask him to review tomorrow.

Fucker goes in to make changes while I am making changes and doesn’t think to msg me telling me?

He is removing things and moving things which is fine just let me know! What a dick!!!!!

Screenshot of all the activity today, I am
in blue. I will spend all day watching the page to make sure I get the last fucking edit!

My worst code review involves line endings. In one of our products we use the facade pattern, and one of the facades is about 5000 loc.

Well, a dude in our team messed up with line endings, so our diff tool showed that 5000 lines have changed. A newb I was at that time, I didn't know any other diff tool, so I went through all the lines manually only to see that 2 lines effectively have changed.. and the newb I was, didn't thought about rejecting the change immediately! We then had somehow to revert that commit, but messed up our central repo (was still with CVS). In the end we had to restore the daily backup for the repo because we couldn't manage it to do it right.

Never ever had such a disastrous code review again.

I envision a website where you can review individual HR personel on the basis of;

1. Knows technical aspects enough for hiring
2. Respects the candidate
3. Respecting the messaging time limits, ghosting vs
4. Skill to bring best verdion of the candidate etc

What else would be the criteria?

Code review:
i ? plus.push(i) : --i ? neg.push(i) : zeros.push(i) || printThis() || checkAge() || !!window.MediaSource...

F***ing such a brilliant programmer, spent 4 hours to write it in 1 line, and will take your the guy who replaces you 4 hours to decipher, why are you so adverse to writing #readablecode?!!!

\n is cheap, if(){} is too

This isn't math class where a 3 line proof gets you kudos, stop wasting my time with your genius.

So.. I have raised a PR 2 weeks ago.. it needs approval from 2 of the senior Devs on my team. The first one reviewed it within 3 days, without having to follow up. Then comes the second one, who is senior than the first one. I have been following up with him on a daily basis for the past 1.5 weeks, each time I request him to review my PR he sends me a "sorry" followed by a stupid smiley. I have tried tagging him on Jira, setting up a meeting with him to get it done, nothing's working out. He has already looked at the code and I have explained him the code and the context, but he is just not adding comments/approving/rejecting the PR. I have missed the release date for the feature because of his lack of concern and petty excuses. So done with him.

Management proposed to work with external freelancers, to "pick up speed so we can release these new designs sooner". We agreed, but of course we (the home team) can't have time to review their work because we need to develop other new features and bugfixes and such...
Weeks later, turns out that their changes are largely incompatible with the work we have been doing on the main branch. We are now rebasing/rewriting huge chunks of their work, probably taking as much time as it would have cost us to develop the design ourselves in the first place.

Boss needs certain stats pulled from database once a year for board meeting. This time I delegate it to a junior dba/sysadmin. He looks at my 3-year-old docs that I hastily jotted down and pasted and included my rambling notes with results from way back then. Mostly they were just to jog my own memory, not to be a really neat, clean instruction guide. He does the queries correctly, but in ticket for boss he pastes also all my notes from the docs. boss gets confused, "what is this other number, I don't get it?!" We have to have a meeting of the 3 of us and waste an hour or so just to figure out what went wrong, finally I realize what junior guy accidentally did. Moral of story: to avoid baffling the nontechs, always simplify, simplify, simplify. Alternate moral of story: before delegating a task that seems old hat to you, always review your notes/docs and make sure they're ready for someone else to use them.

So the company decided to go agile. I am now a scrum master. And we have the local product owners and all. They made us do daily stand-ups.

I don't know what is a scrum master. Nobody knows what the hell is a stand-up. It seems to be an akward 30 minutes every day, when local product owner asks questions and demands status reports.

I did some googling and it seems that the scrum master is supposed to just support the team and solve problems. In our version the scrum master finds out the system architecture and requirements, fills the backlog, does the system design and reports to the project manager(s). Also reports to the clients about the general project status in an executive meetings. I also do the sprint planning, in which we fit the vague features that we are told into time tables with ready told dates.

Oh yeah, the team is just 2 guys. One of them is me. And the other guy relies completely on me to daily tell what to do, review the work and also answer all the project and company level questions that pop into his mind. He gets angry if he doesn't receive ready-thought solutions to all problems, since "you're the boss and it's your job to tell us what to do".

This is going to be a great year.

While it's totally not without its valid use cases, I fucking hate pair programming.

Well, let me elaborate. I hate *remote* pair programming. It completely disrupts my flow and wastes so much time with additional water cooler nonsense, and pedantic argument for the sake of participation. Not to mention "oh hey let me see how you did this... Oh, you know what, I think it would be better to do it this way...". Ok, great, we weren't even discussing that, but sure, let's completely detail this session to refactor something that could have come up at a good transition point, like I dunno, say a code review?

Like I said, there are very good reasons to pair program, but I would much prefer rubber ducking wherever possible.

So I've been really Ill the past few days, like litterly been in bed for two days, popping pills like there going out of fashion. I contact work and get the typical "get well soon" so I get a message today asking how I'm doing (still Ill), I said I'll be back Monday and ask if anything is urgent that needs to be done first thing. So I get a list:

Project A: Deadline Monday
Project B: final review Tuesday
Project C: Still waiting on feedback

So I ask any chance we can extend the deadlines by a day or so I have enough time to catch up even though I'm going to have to rush it as I've been off.

Answer.. nope there non negotiable.. oh

So they want basically three days work done in one day, given the fact I still might not be 100%. Jesus Christ 😂

Quick Edit, I wasn't told there were deadlines.

Does anyone work on a team with multiple stacks?

For example we have batch jobs in Java but also have a JS front-end and APIs.

How do you divide the developers and the work across these projects?

Currently everyone does everything but I feel like this is inefficient and hard to develop expertise. And different people or even the same person will make the same mistakes over and over again because they don't know how to do X or they forget or overlook some quirk. When I switched Beck to JS took me like a week to get a Promises nailed down again. And this morning someone else had a production bug and couldn't figure it out. But when I looked at the code I could pretty much see where an issue could be (uncaught exception in a promise)

Also the testing frameworks are very different and there's a lot of infrastructure technical debt, things that really should've been done a long time or fixed but no one had the time or expertise to do it or notice it (until it causes a production issue and then everyone is like WTF is happening??!!!!).

I'm not the manager but I always feel that the team needs to be split along the language lines and specific people need to own these projects to review and code changes for all these common newbie errors. And also developer enough expertise to foresee problems before it becomes a production issue.

One of our projects migrated their file-repository to another one during a major release.

Instead of giving this task to an experienced programmer, they gave it to the head of the respective dev department due to the usual release panic.

Soo.... He wrote the migration tool. It was executed during the release. Everything seemed fine so far.

A few days later. Someone from the above project came to my team due to some "strange behaviour on the production database".
They reported that they couldn't download some of the user's documents due to unknown reasons.

After quickly analyzing the current state of the new file-repository, we concluded that the affected documents did not exist in the new repository.

Then we took a look at the so called migration tool...
Well.. After nearly 30 min. we knew the root cause for that.
They only migrated the first 4 levels of the folder structure. Due to the assumption that "we don't use deeper nesting". (Facepalm)

As the head of their department wrote it, no one seems to questioned it either. Nor did they made a code review and ended up with a tool with hard coded urls to the production db, no version control, no build tool, no ci, nothing. Breaking nearly every possible company standard.

However.. That's not it. When analyzing their migration tool we noticed another even more dangerous thing.
They mixed up the id generation of the migrated documents resulting in a random assignment between customers and documents. Which is quite bad as this contains sensitive information. E.g. passports

They offered us quite a nice amount of money to fix this until EOB. We declinded as it was simply not possible in that time, but agreed to support them with the new tool.

After some time I heard that they migrated production again. And they fucked it up again. They never talked to us after we offered them support...

The third and final migration was written by us. Not only migrated it correctly. It was also way faster. By factor 20.

In the end we haven't gained anything from this rushed project as the penalties were piling up due to this fucked up migration.
After all this time I'm not sure who is to blame. In my opinion, partly all of them.
Head of department who can't and shouldn't code.
Seniors who didn't review the code and didn't ask for help.
Release mgmt who put way too much pressure on the devs.

Long time no rant.
Here's the summary of a review meeting I & team just had with our programming prof:

"You did exactly what I taught you in class, and I don't like it."

"To get a better mark you should've done more than what was required."

"This wasn't a requirement. You should've kept it short."
except we asked about it being a requirement earlier and only got vague answers like "that should be obvious."

Also, printing a class diagram over 2 pages apparently is unacceptable and we should've gone to a copyshop to print that as one page instead.

Alright, it looks like everyone at this bank, a client, I work for will now start avoiding me. I'm usually the only person that takes the time to review PRs and give a feedback. Everyone just seem to click accept because they can't be bothered.

A few months down the line, they begin to wonder why there is so many tech all over the place.

Good luck to anyone that wants me to review their PRs. I pledge to continue to take the time to review PRs and give feedback. I will not be pressured to click the accept button on what I perceive to be sub-optimal code. So help me God.

If you have to review the code of other devs and they make the same mistake every f*cking time. But you are a friendly colleague so you try to keep calm and and remember them politely.
And so the only place to rant (and use the word "f*ck") is an app :(

Not to burn professional bridges every time I have to review a pull request, not the biggest challenge but the one I face more often.

So I've been just assigned a code review. For a complete new feature.
It's over 20k lines of Code.

Time to quit

So my colleagues don't proactively do PR reviews, even when they're assigned to them, unless asked for the n-th time by me or the PM.
In the meantime other PRs get merged, I need to merge master in my branch, and solve conflicts every time so that it is eligible for merging.
Additionally, while reviewing, the requierements engineer realizes that there were corner cases not initially covered in the ticket description, so I get review findings about covering these.

ok. been going full steam since December with 1 day off since. managing teams, review designs, designing, prototyping, code reviewing, mentoring, and doing project. management. i get that it's a "flat" org structure but hire proper PMs and BAs instead of trying to pinch pennies. all the while, i see marketing with deeeeeeep pockets spending money on anything like mommy and daddy are funding their spring break getaway. i need time to disconnect and recharge my spirit.

I’ve somehow ended up in a situation where I have a big project to work on - alone, since I’m the only dev in the whole company with any expertise whatsoever in that area… which is exhausting enough by itself, since I have nowhere to turn to when I struggle with it, no one to rubber duck with and share the workload with, no one to review my code. On top of that, I’ve somehow become thee go to dev resource when it comes to this integration, that client’s custom shit and so on. I’ve been doing this big damn project since late August, and I keep getting pulled off it for weeks at a time. I think I haven’t had more than a day or two in a row to concentrate on it for at least 3 months… and my manager keeps asking me when it’ll be done. What I’d give for a few more devs to share the workload with…

Got an update for Firefox 😊 ->
Updated Firefox 🎉 ->
Got a sticky popup that asks if I would answer 3 review questions, why not? 🙄 ->
Went to a fucking website that uses my fucking IP to identify my fucking language automatically, and the result is the one you can see in the image,
half fucking German and half fucking English,
meanwhile I'm the turd from fucking Italy!

Firefox, I didn't knew you like it 🤬 black (pattern(UX))

Message for ALL, take my example and WHENEVER THERE'S A TURD THAT SUGGESTS TO IMPLEMENT THE fucking LOCALIZATION BASED ON IP ADDRESSES, SAY THAT IT DOESN'T WORK, NEVER WORKED(not my first time elsewhere on the web) AND NEVER FUCKING WILL 😤

Next time onwards... Please try to solve the problem yourself before writing a bad review... Or you'll get trolled like this guy xD... He didn't know how to disable vibration lol...

If you're a PO; Please don't make the sprint review take almost 2 hours. Put it in text, make tickets, make roadmap and show it me that way. I've forgotten 90% of the meeting by the time I speak to you in the next daily.

I hate meetings. Waste of fucking time, especially when all you do is listen to what the PO wants for 1 hour and then both sides forget it the next day.
Use-fucking-less.

We've recently employed a new lead dev that seems to have a problem in that his solution is always the correct solution.

On a typical day, whenever I push code up for review via pull request, every single ticket I work on, he has something that has to change which doubles the amount of time of each ticket.

I'd be fine with this if the other 2 developers also think he's a bit of a headache in terms of his opinion but a lot of the time, there is always.. ALWAYS something that has to change because his method is better than mine.

For example, just now I pushed up some code that literally just adds in the user's email to the view which is already in the store for that action/effect anyway. I added one line of HTML.

He comments saying that I need to change the way it gets the email by doing a different request in the effect, to get the current user id, and from that match it against the email address, and THEN display it in the view.

This ticket took me 5 minutes. He's making me make it 30-60 minutes (to understand his requirement and implement it).

Is this normal? Am I over reacting?

Opinions please!

I had a week off. During that time nothing new was pushed to remote by my boss.

On the last day, before I started working again, literally Sunday night, a pile of garbage non-urgent changes were pushed directly to remote.

I guess it wasn't possible to wait another day for a review. I didn't really care much at that point, but it was just another confirmation, that quitting is the right thing to do.

This rant is about myself and anyone whos like me: using logs over a debugger

So, sometimes when I wanna quick check something or make sure, if and when something get's executed or I've ran into a Problem, I add a few log/print statements to check in console.

But I don't think about proper and helpful messages, since they aren't supposed to stay in code. So I often type what comes in my mind, like memes or song lyrics.

The last time this became a huge act, was Code review/ Prototype demonstration with Clients (which I didn't knew about, otherwise I would have removed them, I swear) and Boss and my Code printed "show bob and va...", "send nudes" and stuff... in loop... to stdout